Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1571819543-15676-1-git-send-email-zhong.shiqi@zte.com.cn> <fa46cad1-8845-78b7-eb6a-45942813020b@amd.com>
In-Reply-To: <fa46cad1-8845-78b7-eb6a-45942813020b@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 25 Oct 2019 15:32:48 -0400
Message-ID: <CADnq5_Nv9j5vDX5-Jkhy3TTiej7FcKBBOC8QQk59NQ=SsO-3pg@mail.gmail.com>
Subject: Re: [PATCH] dc.c:use kzalloc without test
To:     Harry Wentland <hwentlan@amd.com>
Cc:     zhongshiqi <zhong.shiqi@zte.com.cn>,
        "Wentland, Harry" <Harry.Wentland@amd.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Lei, Jun" <Jun.Lei@amd.com>, "Koo, Anthony" <Anthony.Koo@amd.com>,
        "Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
        "David.Francis@amd.com" <David.Francis@amd.com>,
        "Liu, Wenjing" <Wenjing.Liu@amd.com>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "cheng.shengyu@zte.com.cn" <cheng.shengyu@zte.com.cn>,
        "wang.yi59@zte.com.cn" <wang.yi59@zte.com.cn>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
        "Aidan.Wood@amd.com" <Aidan.Wood@amd.com>,
        "xue.zhihong@zte.com.cn" <xue.zhihong@zte.com.cn>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@amd.com>,
        "Park, Chris" <Chris.Park@amd.com>,
        "Yang, Eric" <Eric.Yang2@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "Laktyushkin, Dmytro" <Dmytro.Laktyushkin@amd.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Applied.  thanks!

Alex

On Wed, Oct 23, 2019 at 9:35 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-10-23 4:32 a.m., zhongshiqi wrote:
> > dc.c:583:null check is needed after using kzalloc function
> >
> > Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 5d1aded..4b8819c 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -580,6 +580,10 @@ static bool construct(struct dc *dc,
> >  #ifdef CONFIG_DRM_AMD_DC_DCN2_0
> >       // Allocate memory for the vm_helper
> >       dc->vm_helper = kzalloc(sizeof(struct vm_helper), GFP_KERNEL);
> > +     if (!dc->vm_helper) {
> > +             dm_error("%s: failed to create dc->vm_helper\n", __func__);
> > +             goto fail;
> > +     }
> >
> >  #endif
> >       memcpy(&dc->bb_overrides, &init_params->bb_overrides, sizeof(dc->bb_overrides));
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx