Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] tpm: Add major_version sysfs file
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Jerry Snitselaar <jsnitsel@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>, linux-integrity@vger.kernel.org
Date:   Fri, 25 Oct 2019 15:15:28 -0400
In-Reply-To: <20191025184522.5txabdikcrn2dgvj@cantor>
References: <20191025142847.14931-1-jsnitsel@redhat.com>
         <1572027516.4532.41.camel@linux.ibm.com>
         <20191025184522.5txabdikcrn2dgvj@cantor>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <1572030928.4532.57.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-10-25 at 11:45 -0700, Jerry Snitselaar wrote:
> On Fri Oct 25 19, Mimi Zohar wrote:
> >On Fri, 2019-10-25 at 07:28 -0700, Jerry Snitselaar wrote:
> >> Easily determining what TCG version a tpm device implements
> >> has been a pain point for userspace for a long time, so
> >> add a sysfs file to report the tcg version of a tpm device.
> >
> >Use "TCG" uppercase consistently.

And "TPM"

> > 
> >>
> >> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >> Cc: Peter Huewe <peterhuewe@gmx.de>
> >> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> >> Cc: linux-integrity@vger.kernel.org
> >> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> >
> >thanks!
> >
> >Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> >
> >FYI, on my system(s) the new file is accessible as
> >/sys/class/tpm/tpm0/version_major.  Does this need to be documented
> >anywhere?
> >
> >
> 
> Yes, there should be an entry added to
> Documentation/ABI/stable/sysfs-class-tpm.
> I will fix that up and the TCG not being uppercase in a v2.
> 
> Should Documentation/ABI/stable/sysfs-class-tpm updated in
> some way to reflect that those are all links under device
> now and not actually there.

The importance is that there is a common file that can be used by
userspace applications, instead of having to search for it, not that
it is a link per-se.

Mimi