Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4196434ybg;
        Fri, 25 Oct 2019 14:57:29 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwYjDKlTt0nxVX28zZ9J6RMtWWAvTCC/uns4TPVQ/V7jB6hf3gflhAjWC5wqRHFnB+5YY4M
X-Received: by 2002:a17:906:4813:: with SMTP id w19mr5701893ejq.258.1572040649281;
        Fri, 25 Oct 2019 14:57:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1572040649; cv=none;
        d=google.com; s=arc-20160816;
        b=yEunkZMV7QB959/n2RnOript1oqmdg1Xx3cqlBT9m9TSi0sIpaXCTuORv7LjKPy/IV
         tlOw79gkvLXRnLZvPsOCXliGIpyYEclXZLDc/LzRlUQN5MtuDT0wah2RDLUItEiIWlYh
         Od9TT7d1wo66b+gzuHL5e9nmZGferj2OZAW7a2LVW6Fk2KI/aM9zYUDuYpLhOPXRgeWw
         JIkQVz2httVzC1p9PTbWutTXIiob8TQcYByxuF0A6DOPXC6X/QOvkbj4yOb5Cuc0pBDx
         CBf7/hoWP069azugNU8mbAeNu+WvjQqghRxGSaBNxMGTzB1YJv/twX4WypbPo98XSs2G
         rK+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=1XzEIJ2Aij+O1b/FperTnyAwAtRoYUY3zHWpOIg/zwQ=;
        b=ibrZiYxo8CmdvW+D2gj7XMuEFEUDiP0n54a5IsQzEYviv9q9H1PV26UGpqhqJ/bfBY
         ufN7aDE/hDcDJoFMKmVHi+/xCGolw7C1kNBMUPN3f83lj6ifOg0KHGTH55+F7GyLmjZ3
         zuvqBwjkhzp/x91ch5rwR4lAdhcYBtc4VBPFB3CkrDV9hsY2bUodLfORLdTgs92gwnk+
         87smPqR4WDCOGrJhBDV6Bb3zc/Kv+MMDioGaB/u9ihSCoZ37yKpnyvlIP+pg8aiyh2KZ
         svPILpZZV6fwVR5d4OMIdsTj9Olwq14AUuuGJ8vLjC5xiHRDrwuwMS4Z/u6SK8C9O5Jd
         GwjQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b="klIBso3/";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a40si1936774edc.92.2019.10.25.14.57.05;
        Fri, 25 Oct 2019 14:57:29 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b="klIBso3/";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726332AbfJYVxj (ORCPT <rfc822;hackukernel@gmail.com>
        + 99 others); Fri, 25 Oct 2019 17:53:39 -0400
Received: from mail.skyhub.de ([5.9.137.197]:37794 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725801AbfJYVxi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Oct 2019 17:53:38 -0400
Received: from zn.tnic (p200300EC2F0D3C004597AB7732076DF8.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:3c00:4597:ab77:3207:6df8])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 88CEF1EC0CF6;
        Fri, 25 Oct 2019 23:53:37 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1572040417;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=1XzEIJ2Aij+O1b/FperTnyAwAtRoYUY3zHWpOIg/zwQ=;
        b=klIBso3/J/ahcYo1mvFm6+oVSDl+1NmdHZlWqCtkLn70/8O3vMkRDRTRRXqHshBb8bJduy
        cZOt2TqblbloRFXf9/1hVT7m1irHgxykhtyA1V+Sei/sxYkOQQNwr/nMM8Qq4XVPTzJ90d
        eRB02idCz+E/HzJrA5X/5AGFbp1cx7M=
Date:   Fri, 25 Oct 2019 23:53:33 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Robert Richter <rrichter@marvell.com>
Cc:     James Morse <james.morse@arm.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@suse.de>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, ghes: Fix locking and memory barrier issues
Message-ID: <20191025215333.GH6483@zn.tnic>
References: <20191025211226.2444-1-rrichter@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191025211226.2444-1-rrichter@marvell.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 25, 2019 at 09:13:14PM +0000, Robert Richter wrote:
> The ghes registration and refcount is broken in several ways:

...

> Fixes: 0fe5f281f749 ("EDAC, ghes: Model a single, logical memory controller")
> Fixes: 1e72e673b9d1 ("EDAC/ghes: Fix Use after free in ghes_edac remove path")
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: James Morse <james.morse@arm.com>
> Signed-off-by: Robert Richter <rrichter@marvell.com>

More staring at the rest later, just to point out that the SOB chain is
wrong: my and James' SOB must be Co-developed-by: or Originally-by: or
so. Or even as freetext in the commit message:

"Based on patches by ... "

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette