Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Roger Quadros <rogerq@ti.com>, Peter Chen <peter.chen@nxp.com>,
        Pawel Laszczak <pawell@cadence.com>
Cc:     "felipe.balbi\@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "nsekhar\@ti.com" <nsekhar@ti.com>,
        Rahul Kumar <kurahul@cadence.com>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: gadget: Don't manage pullups
In-Reply-To: <83a1da01-19d6-65a9-aecd-2027fd62a272@ti.com>
References: <20191023090232.27237-1-rogerq@ti.com> <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com> <20191025031343.GA13392@b29397-desktop> <83a1da01-19d6-65a9-aecd-2027fd62a272@ti.com>
Date:   Fri, 25 Oct 2019 13:14:33 +0300
Message-ID: <87y2x9xhbq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Roger Quadros <rogerq@ti.com> writes:
> On 25/10/2019 06:13, Peter Chen wrote:
>> On 19-10-23 09:17:45, Pawel Laszczak wrote:
>>> Hi,
>>>
>>> Reviewed-by: Pawel Laszczak <pawell@cadence.com>
>>=20
>> Hi Roger & Pawel,
>>=20
>> Assume gadget function has already enabled, if you switch host mode
>> to device mode, with your changes, where the device mode will be enabled
>> again?
>
> When it switches from device mode to host the UDC is removed. When we swi=
tch
> back from host to device mode the UDC is added, so,
>
> usb_add_gadget_udc_release()-> check_pending_gadget_drivers()->
> udc_bind_to_driver()->usb_udc_connect_control()->usb_gadget_connect()->
> gadget->ops->pullup()

I agree with Roger here. UDC shouldn't try to manage pullups
directly. If there are any bugs related to role switch, we should fix it
in udc core, so the fix applies to everyone ;-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl2yywkACgkQzL64meEa
mQZhnA/+KbCx3ho/LG/P+vHwaG8HWQT4rebxmRH2GjM8sbRwREGP0EDPJORGHscd
oLLXpFnLcoaph2dRzJaLi51CMdseCkEoPAC5ElNMRixhhIE0hvA6GEFlJh2CaBEl
tQtMZ5PTurQam4i8biyu9sGZtOzmg2LIibUsP5bcGJAqgPMSlmvuOpMaDBGuYi5I
4mvbwAszsizQT1skMDFiIuHYIMQ9shAOLkTz2k6ARC7nLFKtqBcaM/zSwkxrW3E3
u1CL7HQqWa5IDC4L2OvvVCdjc9JWMY35k1yvf4vGChyTUPLdksIo2TFJ5k3MSkP4
0djrSTQbox0iHimscZbaD9iPEX02/0et9M9/Lf+0phQ6GT5gRaDfRF+KN/gu5Jbo
EUTJIsmOKaXuLW0pxLs2HwiudpE3de8VG28acQayqCq5JEMcffGVOrsoBczE+0M9
jueAqXvy/e96hq5MnIsF40N9sWQG4qq53gChj7KU0VRlVlhXoIfP8hw59O4FCuPI
zw0RnmwhjMGyinh0E97j9WXRa6PjsjMWX68f1cOs1JSM08T+YdoiW9bjZK3yNqBG
PchUVJ5GgGiIEP02APziCb2rwCLFztI5wiZ4IlItQcyNxnRRqlB1jV1ilaN35Q0e
qlq6pcytzDHpvGQ/P8ehMJfWpDOxDwYpX58f5x7Jloue2aWT1bE=
=SMdL
-----END PGP SIGNATURE-----
--=-=-=--