Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp242096ybg; Fri, 25 Oct 2019 20:30:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5RFEHEHEjXOqmx5ps576S15FhZfp4Zwccchiub6VCNqvSUXI4ajsh5OU6nHFfIpt48nBu X-Received: by 2002:aa7:d8c8:: with SMTP id k8mr7487085eds.246.1572060631350; Fri, 25 Oct 2019 20:30:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572060631; cv=none; d=google.com; s=arc-20160816; b=WaiW5s2wbtvjuq2+9HEUAi2dRcfIMxO0rE/NzilcfdsY/vkMHGqU/V7I1VZmD3N252 v1iUMmWYtNnAhQddk8Fgb/nYK8Vr3US5EGrpZtWqskzjQ+xcYXw+p0jcd2yn28lx3OHn bJT+SdLZdmwUvffK0xMB8V7NwwfBc0gBFKhdfMVr8bYBZLSCLSA11qNZZJCXrFejVwsx UsIZWG2UvAm/2UJXmhUEkEWqN4ACtzUaN4qE2bEsCz9TNb85AAVJ8ETKUSGNTyYjBJGR uT43Ql1YofjO75HNVfBUoxG9YkVH8TYSZxPqFzIK0V5kXhZkbox6NMaePlmLUal2rWvv 4YKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=GAD53LJIDAlRMuq0ujQb7sRDQvwZBR3lHpUfNYQyzRw=; b=sclJxbzFbLjzebwiyI+9iK8ZVLF6jEjV5WFbIJPW34bAX2iBI03zNOik9UraUiycAR iUX0Ld55ZI+eSCtHOKg8159WRephQd1nfu46EtZTAN8xyxUdbjg0LEdd0sVohJO/NsI9 axE1ru2DjnUpsbUo1+MpTkMjG0XgRA0qg4hXTPirdk4q2DMbp9qTbNJePmZOPYztD1wo S9JAEAO0dYiE1aZmPzg3YLA2T4W+l2lFtB3LvT+ekrozIPtU/uMFpFp+kQ9t1r8Y6F8K bYqxdbWoD8NkfHescMm9nCoFH3YuLrYmWF88MS2taPwoZs5AJCy+uyyATyyM/GhyYKr2 fHpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=emoRtX2t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si2571749edd.8.2019.10.25.20.30.07; Fri, 25 Oct 2019 20:30:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=emoRtX2t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfJZD1Q (ORCPT + 99 others); Fri, 25 Oct 2019 23:27:16 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60514 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfJZD1P (ORCPT ); Fri, 25 Oct 2019 23:27:15 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9Q3PxxT037712; Sat, 26 Oct 2019 03:26:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2019-08-05; bh=GAD53LJIDAlRMuq0ujQb7sRDQvwZBR3lHpUfNYQyzRw=; b=emoRtX2taVpbl0COt6aH3LFB8PSzDNJr81cNQFCgJYXe8nWJNDZfehs0pFe6xFYe5Rli Y1GLydjtPXyWRd2/JkxeNDP2/vBLcPzNXyB809QF4sM8yHNQK0pSxe9E3lo7tOdUelCb r16ywIz9HLWssPVMD06HQfj/nRuSzBYnCdvWdhlf0+zh9iBvmUxJZ5T66tDeM9x5NE5Y DJvpIfd8zdEppGTobtCNa+MROE5Uw3/SoioeuL42lA2+IeNYTz9w4IHBTzae8z/ZcobH pUuV0gwNZkepMmEDbQZJQW5Hkq7cR8FOomv+OzQFSXL3oQ61Id4HYwM05s4wtqiXmzdT sA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2vve3pr11k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 26 Oct 2019 03:26:49 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9Q3OKvK082899; Sat, 26 Oct 2019 03:24:48 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2vvc6mmwjw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 26 Oct 2019 03:24:48 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9Q3OmRc025649; Sat, 26 Oct 2019 03:24:48 GMT Received: from z2.cn.oracle.com (/10.182.71.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 25 Oct 2019 20:24:47 -0700 From: Zhenzhong Duan To: linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, mtosatti@redhat.com, joao.m.martins@oracle.com, rafael.j.wysocki@intel.com, rkrcmar@redhat.com, pbonzini@redhat.com, Zhenzhong Duan Subject: [PATCH 3/5] KVM: ensure pool time is longer than block_ns Date: Sat, 26 Oct 2019 11:23:57 +0800 Message-Id: <1572060239-17401-4-git-send-email-zhenzhong.duan@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1572060239-17401-1-git-send-email-zhenzhong.duan@oracle.com> References: <1572060239-17401-1-git-send-email-zhenzhong.duan@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9421 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=911 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910260033 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9421 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=998 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910260034 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When (block_ns == vcpu->halt_poll_ns), there is not a margin so that vCPU may still get into block state unnecessorily. Signed-off-by: Zhenzhong Duan --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1b6fe3b..48a1f1a 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2371,7 +2371,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu) if (!vcpu_valid_wakeup(vcpu)) { shrink_halt_poll_ns(vcpu); } else if (halt_poll_ns) { - if (block_ns <= vcpu->halt_poll_ns) + if (block_ns < vcpu->halt_poll_ns) ; /* we had a short halt and our poll time is too small */ else if (block_ns < halt_poll_ns) -- 1.8.3.1