Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Igor Russkikh <Igor.Russkikh@aquantia.com>
To:     Yuehaibing <yuehaibing@huawei.com>,
        Simon Horman <simon.horman@netronome.com>
CC:     Egor Pomozov <epomozov@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>,
        Sergey Samoilenko <Sergey.Samoilenko@aquantia.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH net-next] net: aquantia: Fix build error wihtout
 CONFIG_PTP_1588_CLOCK
Thread-Topic: [EXT] Re: [PATCH net-next] net: aquantia: Fix build error
 wihtout CONFIG_PTP_1588_CLOCK
Thread-Index: AQHVi+3ed0tWLuNdk0SV6APBpRGF5g==
Date:   Sat, 26 Oct 2019 11:09:42 +0000
Message-ID: <379afbe8-adb8-5209-ac65-8bb9fb92966a@aquantia.com>
References: <20191025133726.31796-1-yuehaibing@huawei.com>
 <20191026080929.GD31244@netronome.com>
 <4edcf4c4-b8fc-00a1-5f13-6c41a27eb4a5@huawei.com>
In-Reply-To: <4edcf4c4-b8fc-00a1-5f13-6c41a27eb4a5@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [95.79.108.179]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3b67dfd8-cb2f-4002-6041-08d75a05006e
x-ms-traffictypediagnostic: BN8PR11MB3587:
x-ms-exchange-purlcount: 1
x-ld-processed: 83e2e134-991c-4ede-8ced-34d47e38e6b1,ExtFwd
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN8PR11MB35876706AC6B4F8027EA630698640@BN8PR11MB3587.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-forefront-prvs: 0202D21D2F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(39850400004)(346002)(396003)(376002)(366004)(199004)(189003)(386003)(6512007)(64756008)(66476007)(66946007)(110136005)(508600001)(6306002)(66446008)(3846002)(6116002)(36756003)(26005)(229853002)(76176011)(256004)(71190400001)(2906002)(71200400001)(99286004)(305945005)(66066001)(31686004)(6436002)(102836004)(6486002)(52116002)(86362001)(6506007)(31696002)(966005)(44832011)(316002)(4744005)(25786009)(8936002)(81156014)(8676002)(81166006)(5660300002)(476003)(2616005)(4326008)(54906003)(11346002)(486006)(6246003)(7736002)(446003)(186003)(14454004)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:BN8PR11MB3587;H:BN8PR11MB3762.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: aquantia.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: o2LcqlE7AluwnNhmkhmV75xHmvtquFu68OPrlmULNY48XlL2fVDnZ/M1eVmJ3rSwag5mHczaSn1Vk9dd1PLWnbVUsRoePOr1moGr7VMhJIxVUmjyHCGk1urXXTCAj6ND2TeKldmfLRkPKO5pvKGlO9M987HWqeIeZ2ua1S/1gu5t2ntQEv2m4uZL18wgtffWC813guvX+R0KimrYtElToDU5JDNJWyRZf+ujFhVGi/2389XED67RPutU36mTA0wsnaddxeuBIHyf9lSLCbHyk4tlR7JWDDKe59Tw3kcrF2mtLzfJsxIctMoJH/AiBjOl2kDn445FO+vSvth9tAM5MRmtHlg8kzkupBNOwGZocyrEMVe9VrlrCVBEduG7zfbpOPf2DW1EV7T1UVw+zElwvzUB5UOUPxf3NzXfS3BYMf+BWWTeN5Fzy+d4wrdwsDCSCUY6+JwLYhnNDGr1RqGnGYNcPjsmSeu4I0HOeb/7Lw0=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <37DC56B85AFE804EA363494B5A28D8AD@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aquantia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b67dfd8-cb2f-4002-6041-08d75a05006e
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2019 11:09:42.7343
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ymPd/620bwwT/tJLdWgRqsVvn5/aXzCRueAtISM7v8EuLyDyy9Z50iV1s91sxNdN9MMVvFgBsnatT4tBYrtpag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3587
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> Hi YueHaibing,
>>
>> thanks for your patch.
>>
>> What is the motivation for not using the existing copy of this function?
>=20
> I'm not sure if PTP_1588_CLOCK is needed at this config,
> using the existing function need to PTP_1588_CLOCK is selected.

Hi YueHaibing,

Please checkout this patch: https://patchwork.ozlabs.org/patch/1184620/

It fixes the problem without duplicating the function.

Regards,
  Igor