Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp753617ybg; Sat, 26 Oct 2019 06:44:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOCmlWVg4XPjOgb/vD4Vc0pbnL/uVA3okSj3mkZo8SF3WLxazWzspbgFothb4yZmPz/0Bp X-Received: by 2002:a50:f783:: with SMTP id h3mr9599441edn.294.1572097442812; Sat, 26 Oct 2019 06:44:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572097442; cv=none; d=google.com; s=arc-20160816; b=K5u4tSlLkMjxt2fNNGfMmTSEpXiV4CQmRixW3+FMvnmG1aakc7hcGpJH3M+K3YMMGR TtKvYAcKdpOsqS2xjmHfh+F2TGalp2cwM0Ohrdk4jygcgxFN/j8pp4IQY3dzw9zfgO7e NckqMUZr0yQlEz7aMDp3gTu193olIyMtN58vw76hCJjjYSvX1QvllBXaIJwLOAxOJVbi M2a53LKvIX5YTbgv5fWc9rvmQBirRElgfWnHAP5Sz9pv8K30/piHaXTIhA1ftvuY7YCh FeLKneCpQri6qvB36iG9/U3CI+LlCIp9pWpWo0SZya+AvaYx6HCrfHNk+EUPUsiTgJia NpXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3ebscc8Tca5DDoMLeOry3/YZPdlyBBbz3ysV+KZ776U=; b=owNQw4SCl06SmyRt7/7eow9GQOrCZT1z0YyGGLyH3uy0loDOEvzqCr1HETTzSL08bE jrL+RlZEYNusa0D16tkFYhZY8O2vm3M1SqKqj3ANpo8j5L3d+Lr9Lbg77Cgx28J/s+r5 SeSLXw12cDNc5d+t0gF3/u7mTIwq0RFPz+OcIsmANzd5j/vEcRnQe5R1AvZ+d+Yxbz6H IdlJyrtbu0cPPrI/SHWiFomOt0GNB4ayos4J6z/K3wuH0cksUpJoD2BUFxOjfIIuzQIe x92i/IuxaM2aeI6e+SauzerkU1wpGnIVvIDxWSJlAY6fJpnsF/qPJmLU42pjoBaOwgy7 aftA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DnHW0pSo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p30si3409797eda.205.2019.10.26.06.43.38; Sat, 26 Oct 2019 06:44:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DnHW0pSo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbfJZNnK (ORCPT + 99 others); Sat, 26 Oct 2019 09:43:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:54244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfJZNnK (ORCPT ); Sat, 26 Oct 2019 09:43:10 -0400 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F1D720867; Sat, 26 Oct 2019 13:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572097389; bh=MgueLOzk4O1/lxLZq3IymJWKFL5VawUHYQ3qLQlgLHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DnHW0pSoT8+Zn7M8REC6SGCFLOideIS0medhl9AZz5hH/cF7g1leZ5J/n9uKTxKXW c6wqJov0kwY0K+zpLxiRDCSEicZiYzri3jG6+WmVDomOUGozldlo1Ykmwu67uIYP0l JIudsG03+oi70SteTexGVNJR4ulojO1VWYARnEDg= Date: Sat, 26 Oct 2019 21:42:46 +0800 From: Shawn Guo To: Stefan-Gabriel Mirea Cc: corbet@lwn.net, robh+dt@kernel.org, mark.rutland@arm.com, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, leoyang.li@nxp.com, jslaby@suse.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stoica Cosmin-Stefan , Dan Nica , Larisa Grigore Subject: Re: [PATCH v7 4/5] arm64: dts: fsl: Add device tree for S32V234-EVB Message-ID: <20191026134243.GP14401@dragon> References: <1571230107-8493-1-git-send-email-stefan-gabriel.mirea@nxp.com> <1571230107-8493-5-git-send-email-stefan-gabriel.mirea@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571230107-8493-5-git-send-email-stefan-gabriel.mirea@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 03:48:26PM +0300, Stefan-Gabriel Mirea wrote: > From: Stoica Cosmin-Stefan > > Add initial version of device tree for S32V234-EVB, including nodes for the > 4 Cortex-A53 cores, AIPS bus with UART modules, ARM architected timer and > Generic Interrupt Controller (GIC). > > Keep SoC level separate from board level to let future boards with this SoC > share common properties, while the dts files will keep board-dependent > properties. > > Signed-off-by: Stoica Cosmin-Stefan > Signed-off-by: Mihaela Martinas > Signed-off-by: Dan Nica > Signed-off-by: Larisa Grigore > Signed-off-by: Phu Luu An > Signed-off-by: Stefan-Gabriel Mirea > --- > arch/arm64/boot/dts/freescale/Makefile | 2 + > arch/arm64/boot/dts/freescale/s32v234-evb.dts | 25 ++++ > arch/arm64/boot/dts/freescale/s32v234.dtsi | 139 ++++++++++++++++++ > 3 files changed, 166 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/s32v234-evb.dts > create mode 100644 arch/arm64/boot/dts/freescale/s32v234.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 93fce8f0c66d..730209adb2bc 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -32,3 +32,5 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-rmb3.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mq-zii-ultra-zest.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-ai_ml.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb > + > +dtb-$(CONFIG_ARCH_S32) += s32v234-evb.dtb > diff --git a/arch/arm64/boot/dts/freescale/s32v234-evb.dts b/arch/arm64/boot/dts/freescale/s32v234-evb.dts > new file mode 100644 > index 000000000000..4b802518cefc > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/s32v234-evb.dts > @@ -0,0 +1,25 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright 2015-2016 Freescale Semiconductor, Inc. > + * Copyright 2016-2017 NXP > + */ > + > +/dts-v1/; > +#include "s32v234.dtsi" > + > +/ { > + model = "NXP S32V234-EVB2 Board"; > + compatible = "fsl,s32v234-evb", "fsl,s32v234"; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&uart1 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/s32v234.dtsi b/arch/arm64/boot/dts/freescale/s32v234.dtsi > new file mode 100644 > index 000000000000..37225191ccbf > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/s32v234.dtsi > @@ -0,0 +1,139 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright 2015-2016 Freescale Semiconductor, Inc. > + * Copyright 2016-2018 NXP > + */ > + > +#include > + > +/memreserve/ 0x80000000 0x00010000; > + > +/ { > + compatible = "fsl,s32v234"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &uart0; > + serial1 = &uart1; > + }; > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0 0x0>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x80000000>; > + next-level-cache = <&cluster0_l2_cache>; > + }; > + > + cpu1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0 0x1>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x80000000>; > + next-level-cache = <&cluster0_l2_cache>; > + }; > + > + cpu2: cpu@100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0 0x100>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x80000000>; > + next-level-cache = <&cluster1_l2_cache>; > + }; > + > + cpu3: cpu@101 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0 0x101>; > + enable-method = "spin-table"; > + cpu-release-addr = <0x0 0x80000000>; > + next-level-cache = <&cluster1_l2_cache>; > + }; > + > + cluster0_l2_cache: l2-cache0 { > + compatible = "cache"; > + }; > + > + cluster1_l2_cache: l2-cache1 { > + compatible = "cache"; > + }; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>; > + /* clock-frequency might be modified by u-boot, depending on the > + * chip version. > + */ > + clock-frequency = <10000000>; > + }; > + > + gic: interrupt-controller@7d001000 { > + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0 0x7d001000 0 0x1000>, > + <0 0x7d002000 0 0x2000>, > + <0 0x7d004000 0 0x2000>, > + <0 0x7d006000 0 0x2000>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + compatible = "simple-bus"; > + interrupt-parent = <&gic>; > + ranges; > + > + aips0: aips-bus@40000000 { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&gic>; > + reg = <0x0 0x40000000 0x0 0x7D000>; We should consistently use lowercase for hex values in device tree. I fixed it up during applying. Shawn > + ranges; > + > + uart0: serial@40053000 { > + compatible = "fsl,s32v234-linflexuart"; > + reg = <0x0 0x40053000 0x0 0x1000>; > + interrupts = ; > + status = "disabled"; > + }; > + }; > + > + aips1: aips-bus@40080000 { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&gic>; > + reg = <0x0 0x40080000 0x0 0x70000>; > + ranges; > + > + uart1: serial@400bc000 { > + compatible = "fsl,s32v234-linflexuart"; > + reg = <0x0 0x400bc000 0x0 0x1000>; > + interrupts = ; > + status = "disabled"; > + }; > + }; > + }; > +}; > -- > 2.22.0 >