Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <cfde329c7ee3c9bb5610bd9b040f95214cc4d9e8.camel@perches.com>
Subject: Re: [PATCH] net: hisilicon: Fix ping latency when deal with high
 throughput
From:   Joe Perches <joe@perches.com>
To:     Jiangfeng Xiao <xiaojiangfeng@huawei.com>, davem@davemloft.net,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        leeyou.li@huawei.com, zhanghan23@huawei.com, nixiaoming@huawei.com,
        zhangqiang.cn@hisilicon.com, dingjingcheng@hisilicon.com
Date:   Sat, 26 Oct 2019 08:44:47 -0700
In-Reply-To: <1572079779-76449-1-git-send-email-xiaojiangfeng@huawei.com>
References: <1572079779-76449-1-git-send-email-xiaojiangfeng@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2019-10-26 at 16:49 +0800, Jiangfeng Xiao wrote:
> This is due to error in over budget processing.
> When dealing with high throughput, the used buffers
> that exceeds the budget is not cleaned up. In addition,
> it takes a lot of cycles to clean up the used buffer,
> and then the buffer where the valid data is located can take effect.
[]
> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
[]
> @@ -575,7 +575,7 @@ static int hip04_rx_poll(struct napi_struct *napi, int budget)
>  	struct hip04_priv *priv = container_of(napi, struct hip04_priv, napi);
>  	struct net_device *ndev = priv->ndev;
>  	struct net_device_stats *stats = &ndev->stats;
> -	unsigned int cnt = hip04_recv_cnt(priv);
> +	static unsigned int cnt_remaining;

static doesn't seem a great idea here as it's for just a single
driver instance.  Maybe make this part of struct hip04_priv?