Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: wireless: realtek: rtlwifi: rtl8192c:Drop condition
 with no effect
To:     Saurav Girepunje <saurav.girepunje@gmail.com>, pkshih@realtek.com,
        kvalo@codeaurora.org, davem@davemloft.net,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <20191027062255.GA9362@saurav>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <4d2b5e56-48ba-4af5-e7c6-b6171210cb32@lwfinger.net>
Date:   Sun, 27 Oct 2019 12:46:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20191027062255.GA9362@saurav>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/27/19 1:23 AM, Saurav Girepunje wrote:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---

The patch is OK; however, the subject should be: rtlwifi: rtl8192c-common: Drop ...

We do not use the directory tree in the subject. By convention, it is the driver 
directory and the driver name. It is common for the driver name to match that of 
the top-level directory, but not in this case.

Thanks,

Larry