Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2238576ybg; Sun, 27 Oct 2019 14:07:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqx15x2dhnmdXYg81IAstRd3VTUkCTITpcBH0HK+R+HxLoOWVegnGM0nOEK4KRyz4cYUccV0 X-Received: by 2002:a17:906:1cce:: with SMTP id i14mr13452406ejh.296.1572210472920; Sun, 27 Oct 2019 14:07:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210472; cv=none; d=google.com; s=arc-20160816; b=nlOMSRwYdUYembIvEQwXANDisBpId7CnscEzHNbWE1eiuH2vBrfo4ILG/DIYMc+dGY rQ/mIQ+gS+UiMN2Rxjp61IRQypoUCh46y0C3cObSv5dVpcdK/C0VyLsYrsikzxnAPLR5 1RysEjxqW5YACqdRIn04FFvx4eUKZy9oIn9s06pd4k+4UYsy3CkeWPC1j0OKWbh/WsdD 1ZIRpVhixl9QDPNtxTlJ8T1ymCQFsADhYd4zdPavhlZE4QKiS/7aqqaiUHB78wa6V25o rIw8sJIg+dFFLZOiNZylS+MTq/p8NjiNksIC0Sot9uaKppJIGCtRb8BGz/2rDH9JHyVv S8OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ukqglxI4jANpxOrCxGay5Hut02zFhLtBvmbFa+GL9KM=; b=D8q8SgIt6qWxu+JZEr0iAtRC9JTVg34YCt5itRnqxKaaLrPB1Ww95C46n11scd/Roy HxsHUjMcF+jAtWSzN5BCiYlu2jA1IWbbLd4wQch0F7RMT5lTkQ8L7sdFF5/FN1mLY2BC 9y99QCOuKpc2RUJ0wLrQC+D/0WZhGmR13Ynj3GqTC45N4Z/T1q813edgSvwMqve+Jal/ PfB9WbJ9p2/9EZd4Z4htqHHPyCeLBWj8C/SDHtI4r/eAEVqVPRT7qWQu6MplhoIC4SR6 eNNhN/1jW/tVBuRYyD/eckdw9ZG8B9/BUSt+iK3dMMeGCzXMUVLJbCjKb2SvBbnlrY9B yUtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PbjfgKX7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id uz29si5377758ejb.68.2019.10.27.14.07.29; Sun, 27 Oct 2019 14:07:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PbjfgKX7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbfJ0VD3 (ORCPT + 99 others); Sun, 27 Oct 2019 17:03:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:48716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728289AbfJ0VD0 (ORCPT ); Sun, 27 Oct 2019 17:03:26 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 221C12064A; Sun, 27 Oct 2019 21:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210205; bh=XsUiFacgZc1EmsQMXFnWjIiZN8J08qKJUkr7XAuI3xc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PbjfgKX7lRHI8b4aWp6Efr74KEWaoOtOyFJsCBUCB0c6Czn7IUzd6KS48IgIZBqtN AsUjbqweETj70uOrYCr6En2F9Xyu3ZmnEyA7bZMY6aEsuNYES5pbGIeAG7w9f5X+AD l4sLhE2zqYNi5IObrhFoMhmEAwz9PrFR1ZjCFTHw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 03/41] scsi: qla2xxx: Fix unbound sleep in fcport delete path. Date: Sun, 27 Oct 2019 22:00:41 +0100 Message-Id: <20191027203102.118327803@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203056.220821342@linuxfoundation.org> References: <20191027203056.220821342@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quinn Tran [ Upstream commit c3b6a1d397420a0fdd97af2f06abfb78adc370df ] There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Link: https://lore.kernel.org/r/20190912180918.6436-3-hmadhani@marvell.com Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 824e27eec7a1e..6c4f54aa60df6 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -437,6 +437,7 @@ static void qlt_free_session_done(struct work_struct *work) if (logout_started) { bool traced = false; + u16 cnt = 0; while (!ACCESS_ONCE(sess->logout_completed)) { if (!traced) { @@ -446,6 +447,9 @@ static void qlt_free_session_done(struct work_struct *work) traced = true; } msleep(100); + cnt++; + if (cnt > 200) + break; } ql_dbg(ql_dbg_tgt_mgt, vha, 0xf087, -- 2.20.1