Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2238619ybg; Sun, 27 Oct 2019 14:07:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2L+SGyv65CPnVJdJxtILV7TcHz4r2/0NUnBgjQxTd+mSUIPYyPrD2y8KTHbZhOykDdGEG X-Received: by 2002:a50:fa84:: with SMTP id w4mr16324868edr.250.1572210474846; Sun, 27 Oct 2019 14:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210474; cv=none; d=google.com; s=arc-20160816; b=e4b8bvOchC57IC5DGDqZZFd2gEeE6cXOYIOKi64J3LZ40k4Py+83ml7qH1yDcYn7/X 5upenKgcJyar2kNB3r4ShcXz76ReXkiBc4pubzyCZ0JBZAGJqmbLDw5c8Ywsy27CF+r2 oS0IXylxWBl9rooyXF7q121oKPf3AEevlosqZaQBlJE4/jzbJUZS8wS/bJwQ8jPMDP9A cEQ0+H8tfxoHbLrpFZuzUOfxNLp2GbyENBxAtFb12CqUlODfEUi8N1R/8U2MpEuQfi2c 9yViJ166VjHPZ+YesYrwpYMjxjzDK99bf2/QWcWUr3ffEnZToipO7fzn84sNv5udlyzF zJVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gT7zQ5vtgCRLF9blzrSu0NwysON2BztIh/5Wh1qnu4g=; b=c3KbZknrsBClWNmX64uTjT95rNuphDlpfpmshb4gYuVmWWiJ6rynalFIM0O2czqsis Jqq3xF0ML3MQLoG/FyfAPfq9W9H5XJQ2PaY2bdnGgaCBVGGQGYtmrBjHgV/oXcYGqrQa +W5O83BBYbjonwpXxJ0OWBBpx8F8Hvy+qpax6vHA8hAJUOzqj+33rGHhpnWUmVx2NhAY SCRcqV6kl5wSr4t3twtTAjcABrhThOMLb7oNhSPWkyU039KE59gI90yp5CJvaHJPSBrl MXQYIF1BcFh79P3Hl4pBpMokxw4c6op2sWpKHdM1XRu75BMVcDrV8hkXqy2C3vsEb0Mh KxIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ujjHoHO8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si6988231edi.22.2019.10.27.14.07.31; Sun, 27 Oct 2019 14:07:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ujjHoHO8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbfJ0VFc (ORCPT + 99 others); Sun, 27 Oct 2019 17:05:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbfJ0VFY (ORCPT ); Sun, 27 Oct 2019 17:05:24 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1950D2064A; Sun, 27 Oct 2019 21:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210323; bh=wgCt+YZ5RNpB3TdtQz/yGRs20B5SCGe3XuJHby44QTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ujjHoHO83fZPyvrpb2gzSBCuowJ5bZkx9YE1xzp7/gJhFDRFKSXOsghwpLkCytIiR HdHBxc7mNHp6GrpOPLiqET3+dzbDAcYPbOgPwj3LFqe2U/iBH80BQsMmsknk2zKZzZ Taez3RMpXeleeH7XH5hIPadEBnxLl0BrATjPQi7k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 4.9 25/49] usb: udc: lpc32xx: fix bad bit shift operation Date: Sun, 27 Oct 2019 22:01:03 +0100 Message-Id: <20191027203138.367796220@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo A. R. Silva commit b987b66ac3a2bc2f7b03a0ba48a07dc553100c07 upstream. It seems that the right variable to use in this case is *i*, instead of *n*, otherwise there is an undefined behavior when right shifiting by more than 31 bits when multiplying n by 8; notice that *n* can take values equal or greater than 4 (4, 8, 16, ...). Also, notice that under the current conditions (bl = 3), we are skiping the handling of bytes 3, 7, 31... So, fix this by updating this logic and limit *bl* up to 4 instead of up to 3. This fix is based on function udc_stuff_fifo(). Addresses-Coverity-ID: 1454834 ("Bad bit shift operation") Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Link: https://lore.kernel.org/r/20191014191830.GA10721@embeddedor Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/lpc32xx_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -1178,11 +1178,11 @@ static void udc_pop_fifo(struct lpc32xx_ tmp = readl(USBD_RXDATA(udc->udp_baseaddr)); bl = bytes - n; - if (bl > 3) - bl = 3; + if (bl > 4) + bl = 4; for (i = 0; i < bl; i++) - data[n + i] = (u8) ((tmp >> (n * 8)) & 0xFF); + data[n + i] = (u8) ((tmp >> (i * 8)) & 0xFF); } break;