Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2238810ybg; Sun, 27 Oct 2019 14:08:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqwiUaIYUzgsTrP8N/ifU0ckgg2uApGuWqovLDJUYHw+QLKETjA9X0FnL/u/U2Bs51WCVi46 X-Received: by 2002:a17:906:1542:: with SMTP id c2mr13510947ejd.80.1572210488975; Sun, 27 Oct 2019 14:08:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210488; cv=none; d=google.com; s=arc-20160816; b=JXfRsGWgL8ARVK/GmVFV1rm0RXfLcOLCa2A/txXdpNPq9YBwez8R55oPLwkZPDX5zA RSJ4+4ag4oW+M+TFvhNQiHX9EVqajv7lpWc18m15cnR/nLend9m0OgvzW1Ezux0bqVNM izhmyWNReFB4SNY3UaELE0C3omhMl+x2W0hMr2Il0It/WrOsWboTIGl5qmj4Ru56pq+e Bio9A0G1QOFapXzRKbnf7dwIDRu3fWTnWt4MZBcR5DbmlJvSskBhMURh06Wmdp8RFeFa khuqO2fADmHWSZaGLaR2/tz7HMgSWI9ph/XQf2DpEmlfmlmC7ytmVJCQzHs0vD0kIItH cSyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xI59wZd3mjX9UcDEJSoqQEL6rKSLVwmOhj+siogc144=; b=xfaDHmeJ+/BOMj4OHir7VMh9o1csfPH81R28tC8RSgtob9NwFJh5utTW90ankyrEp+ JgJY1qYHvDF3el7KzvcYKgCus4hEvQxmj6ROF+gggrtIJHmODT5yug/aBqBtaXIFZtil l3TUPzbsKhGIcnkGm3JogIPwKRa25eZvOa/p5fneocpGC8Yh2rU5AGjhrYactz/tBtpF /or7KdM+9Qdog1j+6pn7gAbExdMHKAG3jcuwedJbSk/wlJlkv8iIVMZtQAp52kXGIDhS qslCvYti3mMerLRYDbOokgjyeDlbQtumO1n/GIzOO6/qjHbMcP2hRvLCZxttys7hqkpv n/XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ip/r+I2m"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si6373718ede.121.2019.10.27.14.07.45; Sun, 27 Oct 2019 14:08:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ip/r+I2m"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728224AbfJ0VDG (ORCPT + 99 others); Sun, 27 Oct 2019 17:03:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:48236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728216AbfJ0VDD (ORCPT ); Sun, 27 Oct 2019 17:03:03 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5569720873; Sun, 27 Oct 2019 21:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210181; bh=3HIHj0GIBcAutRMnLSPPpw5aosuZHolhLDv0a8ZBVuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ip/r+I2mY23UAeQ5gf/yN3m7fg9cNZtM+hVZHMKrz14NQ0Exy8JTlFtRHw0msUe1Y sLKzA1fcoXc2bbPQ+T7o3kIuc5IPFs/dKnFuKXbeg7I45Qn1LMNXCrXKuwyRQrwFGc wB8cYLLnnV/Yom/FknwoJ4+HIBbamMZmDwKVPMkM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 19/41] USB: legousbtower: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:00:57 +0100 Message-Id: <20191027203116.029871693@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203056.220821342@linuxfoundation.org> References: <20191027203056.220821342@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -425,10 +425,7 @@ static int tower_release (struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->lock)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->lock); if (dev->open_count != 1) { dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",