Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2239134ybg; Sun, 27 Oct 2019 14:08:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxHiCaYDb4KWH1sxLX1xga3XuYUWdUuPF2patLH6CCIszQcu1QskWJDePtTaxG3diuo3UxK X-Received: by 2002:a17:906:22cc:: with SMTP id q12mr13974660eja.131.1572210514216; Sun, 27 Oct 2019 14:08:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210514; cv=none; d=google.com; s=arc-20160816; b=vjFRbw2wVsLzv+KtrJMvdo84Whd6BAPbS6EKVG6Hs+KcKCl9BlcuRopC6vra5IAYMU F1RAThM+3xByjXl93eucpwmUXtRq+wiD2I4n6/Sk3SYXZH9Y13gJFZnnOmij/WFcX9kX RgLfaCjSnCIGbbwUvBQC0kBS230U1nvZgYcJdfg/4dNOP3T+QF1xVSQZwgY7SYI6qwL3 7N/GfzyedJ/jxG1C+9Fj7TGhy80n8il3WjeYtflXvrniyr98AwOq5rjJ/SaLNh0kaNIp 7PVeDz1aeHuEidRsZYPtmyRRtuku4p2RGa/sEY4aMZ1M08fv/fALO/+4pYgSl9MlsYP6 uqQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ONN0uhWzYGDKyfAvCBakFTHE5b232BKq38Qs8pjHuqw=; b=K/MxcJoTe4bx8wzM/4C5OF2/l4lDSbHSUqqAt+zIlFcQg31L/znu9RaNW1fUr4bOVG RfH1/u86xvYrt/sXQ3Lq5738qWgSC0f3Jj1R5NF/v0TYiR0RLzoZAcG8ZoA1SQfNdvpK R4ufUkvxbm3G7+n5XQilzXNeUVTy86aDvS0Ymv8bf7anIAocNbU/47UMln7TpwNqUg8X b0J5UH8t5nByfMNiAJEMK7Tjz86Dv0cllA2tScOGOho4AyfSRaDV6IrW2tN+RQM95gMQ hufmsHQnTufwpTfwZE347N4iVqhlP5lDB4aVGt27E6A7egQMUynU6UJUOLjEwDGu0ywr BG6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EWAuzzkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p57si3404296edc.295.2019.10.27.14.08.10; Sun, 27 Oct 2019 14:08:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EWAuzzkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbfJ0VFe (ORCPT + 99 others); Sun, 27 Oct 2019 17:05:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:51304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727511AbfJ0VF3 (ORCPT ); Sun, 27 Oct 2019 17:05:29 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F017921726; Sun, 27 Oct 2019 21:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210329; bh=vSzc9HsvO8864r7VU+6QocCqs8J+dgGiZwvufdgUIlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EWAuzzkFMC3HxeyKEDt4HAs8efXfFCWLYjdDdShsZ7SndB9+Vvbld6U0uiPt61ogd R1ZbtQ+qQ3K+HyvBOaU+BrXm9e6IUgWD1JzPNqmR8MeE3PIt3O0pPHNextVxgHYWyy oGGG1Lf1fYzluwZgudVDuUXMTYRP7yh85vXZJCzQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 27/49] USB: ldusb: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:01:05 +0100 Message-Id: <20191027203140.678843977@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b14a39048c1156cfee76228bf449852da2f14df8 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 2824bd250f0b ("[PATCH] USB: add ldusb driver") Cc: stable # 2.6.13 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/ldusb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/ldusb.c +++ b/drivers/usb/misc/ldusb.c @@ -384,10 +384,7 @@ static int ld_usb_release(struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->mutex)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->mutex); if (dev->open_count != 1) { retval = -ENODEV;