Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2239949ybg; Sun, 27 Oct 2019 14:09:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyukPTd8+JsSJZYeJ2OBWJ2F08g2gxQxWyVBySTpqhkVBRsuQUKCOCTVXnhK6Yf6rT6LcQ4 X-Received: by 2002:a17:906:73d5:: with SMTP id n21mr13563892ejl.228.1572210573298; Sun, 27 Oct 2019 14:09:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210573; cv=none; d=google.com; s=arc-20160816; b=S7mR6tDtIjv1bjLdTH1ck4UZPUGQLMuuYnU18jJRuZ6Vurg0RqfX9qqteN8uh1Yhlq XSuQSebw3LTHzs39j4u+oocYb7oeTJkkiFpIYLdqDhYoZAlJ2qwsoRvEv6cvnzknoTDm g8HTBzijwYwJOBiDd7aOS69w4v6hqFM5V6BHYu0bqafV8pbgFRMpRVu0OSZzNmnqyE0w nDr9XHgCvGr09tych6RpTCd7kXA9uSdZel+D9zFvPhlWomvVhxYImoqCE2FTgaDvyzYk lSkKyOToBoS+CO3AmQUnjxTwhi6jY0QPReZ4KEp0EvliU9BPpX/+SdhkdJ6tdrcQvLh/ ykgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DwQM+xxoUoqCOenKnO7xqzMDniV6iKASxYBwGnv8q7w=; b=AoQB/BEBa5a7JIRFU3veqxPiIU4zRJiCkaZODEaShMpmubk185ob/ZXfhbIlxmljLA sDINd7YBBfoeW4dVz40u7w++33nrJDtSWsBnb4YOOesoxsuvmrkXtcYSFNawl8GuZVme Bpf90KoNFgSEoiphwIzhmYAdyqqNkyQyYJ00Vkof+ngCQh8piAJpxyOqNB/PsBn1AHlR 3W1y7YydKAnrpMjVyXJ9F1c1GqhibdGeq69ui3jJccDIFqT5f8zxfMNAadOHOyMHLqgK BFQVYtsdwLIb6t4qTuqVsArCbeo78DjhMBdQbzaxuAi6M7a+1OJy+zOf+vGU9dEygT6E Dauw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LkJdXVec; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oe20si5196875ejb.228.2019.10.27.14.09.09; Sun, 27 Oct 2019 14:09:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LkJdXVec; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727695AbfJ0VFk (ORCPT + 99 others); Sun, 27 Oct 2019 17:05:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:51480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727511AbfJ0VFi (ORCPT ); Sun, 27 Oct 2019 17:05:38 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20F06208C0; Sun, 27 Oct 2019 21:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210337; bh=VTE3iNMsGVPx5aIFWaap7QbAngR+xbH2tN1CHoJh/kE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LkJdXVecpL55Mgo9lUuILKUBxZF/31gUC4l/haqzUoiTrdEZWg+CLvVfh5ifDFYw7 gMtEpl+J/qJNTjjBxwOxYRdbpbfgRfGyapakRIT1pSgoBxpfACMwwABevjefAeFc+8 o2NJTMbE+rb6Qt2rnciUeP3z7OnmXADt+E2Sr//k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 03/49] scsi: qla2xxx: Fix unbound sleep in fcport delete path. Date: Sun, 27 Oct 2019 22:00:41 +0100 Message-Id: <20191027203121.970264406@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quinn Tran [ Upstream commit c3b6a1d397420a0fdd97af2f06abfb78adc370df ] There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Link: https://lore.kernel.org/r/20190912180918.6436-3-hmadhani@marvell.com Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 11f45cb998927..d13e91e164258 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -572,6 +572,7 @@ static void qlt_free_session_done(struct work_struct *work) if (logout_started) { bool traced = false; + u16 cnt = 0; while (!ACCESS_ONCE(sess->logout_completed)) { if (!traced) { @@ -581,6 +582,9 @@ static void qlt_free_session_done(struct work_struct *work) traced = true; } msleep(100); + cnt++; + if (cnt > 200) + break; } ql_dbg(ql_dbg_tgt_mgt, vha, 0xf087, -- 2.20.1