Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2240314ybg; Sun, 27 Oct 2019 14:10:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbJ/0DLUvzpwgFBhi54JbZdKw2piM1ViSJ+yTsDu/PG0x99w+osKEWG0f/kbo56cu9GiZ3 X-Received: by 2002:aa7:dcd7:: with SMTP id w23mr16258102edu.34.1572210600823; Sun, 27 Oct 2019 14:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210600; cv=none; d=google.com; s=arc-20160816; b=ZpetdXFABXlLHN4uHz/pxpR5t1Wp+M4ZG+pjcScVOrfVdCFKZoXFqGCFMSlaKd3aqC uaxOgYU/dgZywlSiaLxtZW7Zw1Ft9AvQe86vliS5Ft/KtTRag3WTkWY2dklgJ/WBlxLM r6/A/PTHbKH5KhNjguFYNMMuF9XNxH/xpP+ugHYlEktTqsCkFmBCHgIKDpIVuGC3Zx6Y 58NhRbOucN5YK9mzEkgWW3ZglGXV47PjkmcqAodz/uLQ7rJtIw2+sWA01idtcSKnIC5u hC0WGckz+U8oANu48q0H7dLjgnU5e68fB/RaBGB24NY4+b5M7QvRXQInb4l+cSBP9agh 5OOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mGF0U2hBwNZLp95L7L9lLwpl1P5D9Q7r0TZnZv474bQ=; b=JCYtEsKueTC5S0b3jq3S6SavtpQ9o/L16HaTY+h92ExAi5+OPOdTrQSZfucumbdkdx 2imgAgOcdQJxorN1/gwg/gzqAkeo+UTNHgNSHswnqYtEgzb+7U0xjImbwH2maLQegvxt 1cNmswZI8MeBH3AR2mL2+BMOpnu+PKsGBoQAW4quL62u/YFgez6n7kU5zZvwEJpvbxqq PQElI8SHi2NnEDp/M7JpPD/y8pFplzM/ttsQsyQl1Dt3aqNz29W6+VGkdbRKMDja2YG5 aF6NCmx38EjYMyKXch9mYU348a1js7uCZor4BgoT8vfPKdCWz2UXG30cviVOsmwJ2ujM pKEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dT01JIz0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gy5si4994055ejb.223.2019.10.27.14.09.37; Sun, 27 Oct 2019 14:10:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dT01JIz0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728111AbfJ0VGR (ORCPT + 99 others); Sun, 27 Oct 2019 17:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:52118 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727465AbfJ0VGM (ORCPT ); Sun, 27 Oct 2019 17:06:12 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2970E20B7C; Sun, 27 Oct 2019 21:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210371; bh=V3L3ajqgIIvjGrqd9v+vqSVseo6kV+2bOOOWCgjVJ4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dT01JIz00BSbqvIFLZuJ1EqlJj8lvY63q0F1MOhNVIC2+3N4voMdoI3EwmQSum6jm OUWqY4Xptu4dER5a3UYX4jJbDgAZZLwWE4IE3XaCKMEYQ4oZkVw1uuqT3zgmlJW/Vn npdFqWHIXgrGZEoHqgbnIrtO5qSFqagehhbi6g3k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anand Jain , Johannes Thumshirn , Qu Wenruo , David Sterba Subject: [PATCH 4.9 43/49] btrfs: block-group: Fix a memory leak due to missing btrfs_put_block_group() Date: Sun, 27 Oct 2019 22:01:21 +0100 Message-Id: <20191027203201.084029289@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qu Wenruo commit 4b654acdae850f48b8250b9a578a4eaa518c7a6f upstream. In btrfs_read_block_groups(), if we have an invalid block group which has mixed type (DATA|METADATA) while the fs doesn't have MIXED_GROUPS feature, we error out without freeing the block group cache. This patch will add the missing btrfs_put_block_group() to prevent memory leak. Note for stable backports: the file to patch in versions <= 5.3 is fs/btrfs/extent-tree.c Fixes: 49303381f19a ("Btrfs: bail out if block group has different mixed flag") CC: stable@vger.kernel.org # 4.9+ Reviewed-by: Anand Jain Reviewed-by: Johannes Thumshirn Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/extent-tree.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -10325,6 +10325,7 @@ int btrfs_read_block_groups(struct btrfs btrfs_err(info, "bg %llu is a mixed block group but filesystem hasn't enabled mixed block groups", cache->key.objectid); + btrfs_put_block_group(cache); ret = -EINVAL; goto error; }