Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2240443ybg; Sun, 27 Oct 2019 14:10:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLaIENMCazZv7v1mx1MHdrRS3+kXzN8SF3fyyVczgM8LI4n3UzCTRXU99mB3+waICHVXFh X-Received: by 2002:a50:b63b:: with SMTP id b56mr14480624ede.165.1572210610597; Sun, 27 Oct 2019 14:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210610; cv=none; d=google.com; s=arc-20160816; b=TprY3ClaMk5dtCTIWZWPo7z4HHJ29QiRBP7maLtBA/rfm/hOxQ3lyDso4xFv/MYKHP RBtavowHrt5yg7GXYsfX5gW/aonxYP+zpvF3quy26R1d5fiMc1Eqo9u54ncC9pKxUmaD vvTqm26ahEVNlAp787LxyvGXRsEkDC2ea1mXmJINS2e7OXaqPq6ZB8rqH3xgLswfAHSg JGvrD9MEYNXKQHrb11zjA66S0uHOlVgL338FWAgysw9W7ULnvQXgP7E0qc2TBtVsxxB3 +62jbEGPWUd5mYif2gs7yXkezgZJfCNu5u7not9GYDSMeethubajrJTtUPcstvQmR6vy 2Xow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=s3nc2oU2EGW6YfSoazUFOdIxA9eqX2P7vqGy7WuMtak=; b=A5rwva4EE4DiRfahKNEBawLz7kkQ+dLHHL094cnPhZnQT1X4izuJjdcB0ncGvfFdGj lAAxN1/3C/Cmq9dtXo0cXCdgeW6cSOSToUXiLDndE5EYOZmOYfxx/GVovYEQiTvYlrff yXyNk9IWu+EFU7AQvA1ZmWkW8QiITOz5KazMU4OVZ8SKc0IN4ednebTAUVbesS81Kt8F J4eSz4DZhdGMv1Lr9xP32+EfjnLe574x5ta9EW9EQ62EPYHibzHUKNjYervO8au76elx ojkvHGotwDAoJRAr4/Ia4fhhKdUiIEO5/j9a3L7DDGJxTQuW4x1+z/goAU2TMZLk/tws iOoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RQEp1udP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e25si6190634ede.335.2019.10.27.14.09.47; Sun, 27 Oct 2019 14:10:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RQEp1udP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbfJ0VGY (ORCPT + 99 others); Sun, 27 Oct 2019 17:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:52318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbfJ0VGU (ORCPT ); Sun, 27 Oct 2019 17:06:20 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B94E9214AF; Sun, 27 Oct 2019 21:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210380; bh=P5TbDHn4L8lp7SJMwGX8ysHqwlmcFsq8WwQEoWNuwV0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQEp1udP1XmstkZoazwqCEE8cFJJgNCUUyfEnOY7uw0QvATCe8fw44ro+nfz49qD6 6FHP/E+sJkO1w65t/4jDywNggZrdDAMIiSDUsH+Att9IdOalhGprPvGcV2/mIotMCS dJUnyUWvrc1EpnXqY7nMT0PUT2cQQ8udjSejYqI0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Juergen Gross , Paul Durrant , Wei Liu , "David S. Miller" Subject: [PATCH 4.9 46/49] xen/netback: fix error path of xenvif_connect_data() Date: Sun, 27 Oct 2019 22:01:24 +0100 Message-Id: <20191027203203.808402034@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross commit 3d5c1a037d37392a6859afbde49be5ba6a70a6b3 upstream. xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: # 3.12 Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Wei Liu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -706,7 +706,6 @@ err_unmap: xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; }