Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2240657ybg; Sun, 27 Oct 2019 14:10:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqyN1MjVfexzT2MNVQXB3jZykAK2k3YS/V1j4FXPW3Pgk3TTvL89RQc5IJROK48+gXJiWmbv X-Received: by 2002:a17:907:42cc:: with SMTP id nz20mr13058852ejb.324.1572210625350; Sun, 27 Oct 2019 14:10:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572210625; cv=none; d=google.com; s=arc-20160816; b=mYhkRvF+PjLpmI1nWE6SM84aTNznMN7+C/r7RusDjzmPxJcXtzSG8p5S07UDWjOoQ/ /ByQZlVW7XYPMq9KgJwv9qrY2Xvy4W0+/ZK4Pp3ZqiP7h/wI5IpMLDRk45yMgDAQDwnS HZtR/fC92+juVsl2OeqLc+mcGA4YoheYCt84hp4ubnEkXmUcvVmWoA0XmxrTS3iW8AbL sgYsiu7XfR9VKHYoH2IWB7OG+5VNKA2gF2+W5ciKsUQEgeoMAdVVxvCK5eD131RUKisA XKRsRwzM/OYwurxt4LCtQQjeel14ysRakJ2diB2Wmh3GNvOfy09sVkQ8JjFcWf1F3RlD jb2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DwW35GmGboZcM4ywFeI/kO28IHkdc76FHDi1Bi1TSu4=; b=ItDhqpPeXZfl2aOZWB1E1z4TyEQGWx5rf4z1S6z5VLwx+hoENQzQO9qE4MwMtGai8r IHRCAh2MmAebzT159y8vFKRUaFqQyeNprq488hHtWMWJyXAmzhqffi4xrk11mxYtUGs1 3EsrwtdzymJN2qpUe+7IfBWLE+usOyuz+Db4HyNcF2jptXpOK0zGLtM6g+cfKHm7z8hN XCzWowQrOlbo8e/xeZ3NPGH2LiplPbEwFZpbsGF4gdTmZCkLc5iew3xnnvpCs7iiaA8D c9rHRFeHaHkoosp3CKyS355U38jd8VMHBdjrpEinRfk2sB5NDk2jXsZkE8wkB/dGgdTc te9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="FlU04/V3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c31si5845031eda.343.2019.10.27.14.10.01; Sun, 27 Oct 2019 14:10:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="FlU04/V3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727258AbfJ0VGg (ORCPT + 99 others); Sun, 27 Oct 2019 17:06:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:52488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729015AbfJ0VGe (ORCPT ); Sun, 27 Oct 2019 17:06:34 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D6FD21726; Sun, 27 Oct 2019 21:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210393; bh=l/WXLIXBxK9ewrr0gNrLX93jPViXHepG5+D0tblXfOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlU04/V34M/oKW5Ypl3O4pxtriY0oegW7stBoabGWgribBErTqyNl71KB2xS61msc bHe0xioBADqdHoZai0BUJ0llWRGyjkhsKl0DZcET26pCI7n9T5dTskuee/EjiEhr0J ssto9Aq8vQzpgvm2ePnF5/V2s4RrqpTqATHcIjNw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Gabbasov , Jiada Wang , Timo Wischer , Junya Monden , Eugeniu Rosca , Kuninori Morimoto , Mark Brown Subject: [PATCH 4.9 34/49] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting Date: Sun, 27 Oct 2019 22:01:12 +0100 Message-Id: <20191027203148.024594991@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Junya Monden commit 22e58665a01006d05f0239621f7d41cacca96cc4 upstream. Unlike other format-related DAI parameters, rdai->bit_clk_inv flag is not properly re-initialized when setting format for new stream processing. The inversion, if requested, is then applied not to default, but to a previous value, which leads to SCKP bit in SSICR register being set incorrectly. Fix this by re-setting the flag to its initial value, determined by format. Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior") Cc: Andrew Gabbasov Cc: Jiada Wang Cc: Timo Wischer Cc: stable@vger.kernel.org # v3.17+ Signed-off-by: Junya Monden Signed-off-by: Eugeniu Rosca Acked-by: Kuninori Morimoto Link: https://lore.kernel.org/r/20191016124255.7442-1-erosca@de.adit-jv.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/sh/rcar/core.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -629,6 +629,7 @@ static int rsnd_soc_dai_set_fmt(struct s } /* set format */ + rdai->bit_clk_inv = 0; switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: rdai->sys_delay = 0;