Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2250328ybg; Sun, 27 Oct 2019 14:23:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqyBUxiB3gtgILruTrBv98BaZyaZqJUnXxPne5ksVWBqd8pIyoDGNPTAcKefNagRs8eG5iNa X-Received: by 2002:a17:906:4c52:: with SMTP id d18mr6100681ejw.291.1572211385645; Sun, 27 Oct 2019 14:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211385; cv=none; d=google.com; s=arc-20160816; b=EkUqggXdI2VGPmXXjXI6LEoN9UJWsAZ3iOKnYsq50k1/scDphTnxCLPQaCcFQ+wWiL 4rbG6C+uk6xOF53Pn1O4oJrhghQuMZLBe46aWrhMFvJeKRMaycKblyPPnufUM6iJg5w2 gn9GiGnigToGJyF4tO+3KLeTjmdaZ18pj412x4bHwvAhdELFA78+aFcI6+fVBEgYqZLK Ucrvn0oIaTNVOrqQ1zFu96iwLmSja9NUS8rBUXue0XElM2vsJK/qYai+eKQZ+FLZC3cM NO24AKFrRB/7fOi4hLhWIhyfuDBN/4XmmGeXqLLPPx2//mvRs4HUQ2wE05ybLnp/FLC1 +rbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UVKJGfXk3SKtKOAo6EwWEbCGNJYlZ2tXzje9AdvHmlQ=; b=E9BUR8ZOQUmqE0BFws+rUzTVSnxsw+BFUW51zgcBMRqzJQzi/ulMhncojg9n9gGrNQ M1QDsLhxkU/7P3NQkhRg+aFtDeY1zPMTIx5VIPpyvqiqXr1HkfXeo8s1RgOa2qrBapzk c8q/VZPrls4wABjYtnBHhGP1NfHz4TS1e5usPbICc2PKPrI6DP5g1oPWFcVvEi2EGgAQ baZlxJyzynIfYzRENXIexqCthXvSvYVlSYfBc4XEVwEnzftQERYCo6zGp0d683FKEeza GS6Ujtr3IWtTsjCHGxXvAIzTOfwWEw6TRhG0fbSey3ZGDPN69/L9IWrsFtcu0fjJ9zyi XBxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HSMQrnDf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si6042456edd.204.2019.10.27.14.22.41; Sun, 27 Oct 2019 14:23:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HSMQrnDf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731474AbfJ0VTY (ORCPT + 99 others); Sun, 27 Oct 2019 17:19:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:39666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731452AbfJ0VTV (ORCPT ); Sun, 27 Oct 2019 17:19:21 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2AA2E205C9; Sun, 27 Oct 2019 21:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211160; bh=Htv05VN3kJsdeDZwi8YBPXw24VJr2khxFpXcM28opdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HSMQrnDfvIVV+VVxfR6QUW2YwgsQ1+LOimr7p/a/J+u+86+rA2YRtj1vvalvr8seT YhGflVISzcsoG1sZcsIadUNjXk1Orao8fi9/nAMq5CsZsaQQpOqlusvRWyIQGF1Le7 ZiMOgl5IlCHpXi44Lq7/fq/8vYbjUyNofNLsoT1w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrea Merello , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 5.3 054/197] net: phy: allow for reset line to be tied to a sleepy GPIO controller Date: Sun, 27 Oct 2019 21:59:32 +0100 Message-Id: <20191027203354.593849810@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrea Merello [ Upstream commit ea977d19d918324ad5b66953f051a6ed07d0a3c5 ] mdio_device_reset() makes use of the atomic-pretending API flavor for handling the PHY reset GPIO line. I found no hint that mdio_device_reset() is called from atomic context and indeed it uses usleep_range() since long time, so I would assume that it is OK to sleep there. This patch switch to gpiod_set_value_cansleep() in mdio_device_reset(). This is relevant if e.g. the PHY reset line is tied to a I2C GPIO controller. This has been tested on a ZynqMP board running an upstream 4.19 kernel and then hand-ported on current kernel tree. Signed-off-by: Andrea Merello Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/mdio_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_device.c b/drivers/net/phy/mdio_device.c index e282600bd83e2..c1d345c3cab35 100644 --- a/drivers/net/phy/mdio_device.c +++ b/drivers/net/phy/mdio_device.c @@ -121,7 +121,7 @@ void mdio_device_reset(struct mdio_device *mdiodev, int value) return; if (mdiodev->reset_gpio) - gpiod_set_value(mdiodev->reset_gpio, value); + gpiod_set_value_cansleep(mdiodev->reset_gpio, value); if (mdiodev->reset_ctrl) { if (value) -- 2.20.1