Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2250697ybg; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsnFD1oNXw6VEHFWFD2oXu73eLdgcEdJvC9g3ewh3/GACA4DtHw1VlGkzL1u3Ha7D2Av8j X-Received: by 2002:a17:906:6d89:: with SMTP id h9mr13221970ejt.169.1572211415317; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211415; cv=none; d=google.com; s=arc-20160816; b=h6qxry005ZvIY8YtlLO/Evl1Ds/a5FKFynTUYSMDiof5OejBF0mGgxeVuxnt5QOfmw qU/GTnuH5FkuWP7C/h6aZvZcQvudDVA5OFFxHgI9Iz/F3SFmngq9gxN/tbqrKIsgNIsd 0s8nDf11E61ym/iVlH2vsk4B1xDrXUtyCaDmYy7eqQ04XtQBG7czV/uRQr/vzdt54cgg pQipYktIJU14FOJG3O1SnDjF7Dq5O599/5xUgrxRxfzyocQulex/rwLy4dqFRTY21S7b IftEzsMxbY3MIbfrvdTbjKvAwkcAZa7PTNb0P/YbhR8/iOlRSQr8okuwMZeC/YqtwzOV 5JLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=omuSgqn1mcVJoMSf0f288Ii1TrGz9uRRFXLT52bdQhc=; b=sVmqlRG1pPwy3jOFE+vi68JfxNLKRyV9fD0ZUBAqgC4X89IJ5RsBjUyPuwo2CRNh3Y xtsK9zDK4At1Vstcnv2rqu+d+TnwlfUe4h51mTmaRiRSBzcI+nxSV5nn4dnc5NwEPf2+ 7j2vwQLZT6LyL4pYD0cKxRI5LxH24Ttmx6sb4dmVO2rO3YoWIZHOkYBLCJdfjZ8gvBZn yYh8rEEI2Ad8aC9PhCqpqpa3FGQX8UZqsvojHj7N4TietolJpVuDZV5wPHxq4OjCbntb q4b2wSi65rYl0lpXM7tG0tFPvdvsSd3h0QU+FGPFIurro+yiWvB4vBUPM0FOAwgTSgB3 Dv8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HduiD5EZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si6536720edb.401.2019.10.27.14.23.11; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HduiD5EZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730742AbfJ0VVo (ORCPT + 99 others); Sun, 27 Oct 2019 17:21:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:42580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731332AbfJ0VVi (ORCPT ); Sun, 27 Oct 2019 17:21:38 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA9422070B; Sun, 27 Oct 2019 21:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211298; bh=DioYuE2Fc1xH/kz026vrOKLVWTO8UGykrlspo4l5FX8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HduiD5EZd6P9RI3Ehg1s9Ai9mAxsQQ2YsEyBE2AqkSHA2Do4it3T+RFnHK8chYcjn aVqTl9DbWUvrbYe8jgTbTv5TgwKWmYCNrvHHGGt43kDicftgD3iZ+NR+/YXmv1latr +XcOrRa+rHLS7qYkcK3C1Ih2TBJxm54kd4IHLYfA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 5.3 103/197] USB: ldusb: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:00:21 +0100 Message-Id: <20191027203357.324669754@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b14a39048c1156cfee76228bf449852da2f14df8 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 2824bd250f0b ("[PATCH] USB: add ldusb driver") Cc: stable # 2.6.13 Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/ldusb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/ldusb.c +++ b/drivers/usb/misc/ldusb.c @@ -380,10 +380,7 @@ static int ld_usb_release(struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->mutex)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->mutex); if (dev->open_count != 1) { retval = -ENODEV;