Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2250695ybg; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxLcpvzJMZyJ6GN92bxaygne2kxROHvYGCPHbKR7I8dATkF53tVL0pTG2tQDT59JJVvsCri X-Received: by 2002:a17:906:2458:: with SMTP id a24mr3847507ejb.139.1572211415270; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211415; cv=none; d=google.com; s=arc-20160816; b=fABna+FerlVI0ynU0LLdsflEf4Ovatt2K46WPKHYq4F14hfly7KL+LDei0/0LjBaZF uJyB/FZ7Px1OJqbwOrmd8M9JL6/lVNLfxyoiE0diBYj4KugLMbE3AEoaEXcTkiVun+b5 zYzvDC97or7xzVe6VPzl4jHUM/I33SCy9ylK/9P4/mTB4l9qa1V6OQRCmENcAvDYrkbJ meqMnxrjVyxfmEZ+H2nms+x8gFrg+kXCEXWeqhjEjEHuDNR9pyUJwpr9m9tgl0vkokhf E60f2MFKNE2WBqQXYwczDOUaVc5B1zY4skTtRal3FB2378/qF8q5q1LwzATF/55O9ECm xblQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mm3lCLt1YrA1aeJxki25HvYIRAE8IGMwDeElYeIuU74=; b=EHb34kPTAk8qjyRzka3jQCknxC6wjD/xAFT63Nxl/39s3v9we82va8Mrp7VgvDZwwE 3v5Sgm/BTY0jAno9Tvg+HUBs31CjLTYhHc5i7MzRfLxFPlE0PyeunfHf/YjuWGJLGV1E dNGUxyjyuGktUWb/fhIjLK6IrR3Up5RAv9EfGiPn69CjMhOfRElol0EascV90YaIoDso YJpNmnYTf2wa2fxoTihbwpL3dvy0+VAr1h5+3/jPzoIw6RnLUxK3wef6ZBAQUJY5iQIU HEkrAEa9LWPLIcXW2Ov8ZMYUiRZ5HZT1C+OJBrraPN65QNgyBjE2fUeVfVAJZHNKpfrw as7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AuIWn4Ir; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si3927690eds.215.2019.10.27.14.23.11; Sun, 27 Oct 2019 14:23:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AuIWn4Ir; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731976AbfJ0VVk (ORCPT + 99 others); Sun, 27 Oct 2019 17:21:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:42478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730893AbfJ0VVe (ORCPT ); Sun, 27 Oct 2019 17:21:34 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59F97208C0; Sun, 27 Oct 2019 21:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211292; bh=gSQJtAxrFbMVdanez9BjPKXiMSWioG2yotDUzWuEOFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AuIWn4IrRnkscYxTZI1jzFA4JKGwInC/OyeasFparISQXoiA7U6dQSC1X2Lt/tu90 e+oZmOqsXAc9Q5ChiMb/JHTn2bqNYo2bfmPrzkLGkmV2hN6mQOMpjddTOq30BHjXX/ LkkIdCRSSPuC8YUICU6CkqIqHpUwS857+bwpzv44= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 5.3 101/197] usb: udc: lpc32xx: fix bad bit shift operation Date: Sun, 27 Oct 2019 22:00:19 +0100 Message-Id: <20191027203357.217806484@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo A. R. Silva commit b987b66ac3a2bc2f7b03a0ba48a07dc553100c07 upstream. It seems that the right variable to use in this case is *i*, instead of *n*, otherwise there is an undefined behavior when right shifiting by more than 31 bits when multiplying n by 8; notice that *n* can take values equal or greater than 4 (4, 8, 16, ...). Also, notice that under the current conditions (bl = 3), we are skiping the handling of bytes 3, 7, 31... So, fix this by updating this logic and limit *bl* up to 4 instead of up to 3. This fix is based on function udc_stuff_fifo(). Addresses-Coverity-ID: 1454834 ("Bad bit shift operation") Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Link: https://lore.kernel.org/r/20191014191830.GA10721@embeddedor Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/lpc32xx_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -1180,11 +1180,11 @@ static void udc_pop_fifo(struct lpc32xx_ tmp = readl(USBD_RXDATA(udc->udp_baseaddr)); bl = bytes - n; - if (bl > 3) - bl = 3; + if (bl > 4) + bl = 4; for (i = 0; i < bl; i++) - data[n + i] = (u8) ((tmp >> (n * 8)) & 0xFF); + data[n + i] = (u8) ((tmp >> (i * 8)) & 0xFF); } break;