Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2251294ybg; Sun, 27 Oct 2019 14:24:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxA2bM+Mhg01MgfpeY7ay7AvW2yQrB06MCnqebzzYthWSzeNyEi1zZ+foik7kM7vdTpB9fb X-Received: by 2002:a17:906:6a8e:: with SMTP id p14mr13766995ejr.137.1572211464941; Sun, 27 Oct 2019 14:24:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211464; cv=none; d=google.com; s=arc-20160816; b=qt327E5grFTs8UtxGhpYQQQMcmuqNjbsYcPb27CKVI5+xdXFZnQ6lGT3EUfeK0EO85 0U40Pr1nlZJKH3reML6TEF+iOy6OSeruvN9a7wJxlzRCmaS377Qfm+sH721Xwkl9/NvL mxnU/zVQ1gkd/bIPngKqMhZBhGHuFeU7gi3R/g9dy7MXnWTyVKcUFspfTb2tSdFpCUnh 2PRkrXmnKCtLxP5DmFV9dCnfmWhZsXE+124I35md/j6kut/9ZO+ZbXclnceNQoEstUJW Op29roHy9EDTms3vJPmeKd9CQU/h1HmsGk/XcRF+2uVW5Q+sX497x0YHHJbe2V4Up8am mtWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fFre8/Nag2A1Kpd3GYKv9JN8IyWaflSw15mEWC0D/zQ=; b=Cclb093zzniWtF19cTpMRHk1MglVNrHhC8NKuQRDWtVOZrYPtHUXsF7SEqNpvPZMmY i//HJ06xJUzBa1GTG96YJCTxvo0nVMzvtlQfWcoPaufFdmGFki6zC40oQUAbLjY8bJJ/ zs9RbP+xv9Hg/aFD50yK86QKSRbH0p58jQok71ACHWAtbsTyu+00NzQuP0zQ3GHfjnzE wFNl24FW1jscX5MxzeLouVYevWZIgWSI40Vs0Sc2k8vI49T1+VPdAi7V2O0iwAoI9DkV NNwWD6nBUPmjPWnU6Q5dDzRXKF8DVFYfwxhc+srz2O1xp3h/ugkplRZ+QHHoBiOg4n1j mhZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=luGGqku0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si5989145ede.119.2019.10.27.14.24.01; Sun, 27 Oct 2019 14:24:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=luGGqku0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732162AbfJ0VW3 (ORCPT + 99 others); Sun, 27 Oct 2019 17:22:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:43472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732146AbfJ0VW1 (ORCPT ); Sun, 27 Oct 2019 17:22:27 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6320B2070B; Sun, 27 Oct 2019 21:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211346; bh=2ZPOl9cUdX5/sAga0CKsMxcp69D8i9gJwHMKO1SyhNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=luGGqku0cGN69QyL+HTLxCVfzOREXwuUimUJRBVd2qxMA446Mn2Q/9kz2zNgcAjTy buWn73PURDvHHZzZoQzuwYskzOpUv5QdoM9j+vJDdBROQyeTB3p1CFXhk/GFD/TSnx cKVi5I4kSwKxwiW2C+nW6hzZlczk5l7asP9ssrOQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Gabbasov , Jiada Wang , Timo Wischer , Junya Monden , Eugeniu Rosca , Kuninori Morimoto , Mark Brown Subject: [PATCH 5.3 118/197] ASoC: rsnd: Reinitialize bit clock inversion flag for every format setting Date: Sun, 27 Oct 2019 22:00:36 +0100 Message-Id: <20191027203358.101191673@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Junya Monden commit 22e58665a01006d05f0239621f7d41cacca96cc4 upstream. Unlike other format-related DAI parameters, rdai->bit_clk_inv flag is not properly re-initialized when setting format for new stream processing. The inversion, if requested, is then applied not to default, but to a previous value, which leads to SCKP bit in SSICR register being set incorrectly. Fix this by re-setting the flag to its initial value, determined by format. Fixes: 1a7889ca8aba3 ("ASoC: rsnd: fixup SND_SOC_DAIFMT_xB_xF behavior") Cc: Andrew Gabbasov Cc: Jiada Wang Cc: Timo Wischer Cc: stable@vger.kernel.org # v3.17+ Signed-off-by: Junya Monden Signed-off-by: Eugeniu Rosca Acked-by: Kuninori Morimoto Link: https://lore.kernel.org/r/20191016124255.7442-1-erosca@de.adit-jv.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/sh/rcar/core.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -761,6 +761,7 @@ static int rsnd_soc_dai_set_fmt(struct s } /* set format */ + rdai->bit_clk_inv = 0; switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { case SND_SOC_DAIFMT_I2S: rdai->sys_delay = 0;