Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2252310ybg; Sun, 27 Oct 2019 14:25:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjuw4r/ZHuDbQWCiPjLswO64C6yZUlvppkvUKkkpeL9HTvjosiFv901mE9p+W/A9GaVwrN X-Received: by 2002:aa7:c757:: with SMTP id c23mr4164308eds.209.1572211554705; Sun, 27 Oct 2019 14:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211554; cv=none; d=google.com; s=arc-20160816; b=xJyJUNssV4CyFBdW+flsDZIq0g/2Lxa2CCfP4JNQH3bhymy1wtZE3+Txqgs6ciewOf xQojBAm/kErg6tVRSbQLefcGAhb4usIj+xPR3wUXcUuSnO5FBUlaYTVe7/zIM5YHfdKZ fjjQM7AHp1x+JHEmQ5XBdhOiRNYGO/NqiXitCa6upMPCpf2dlOcHx2cbifHCAdtAYCec sFqT5jP7juKw++0+A6nLxDtjvAYjSlHM9pztvw697YZbI/h1wqPDrjbePPG6+gUskDP/ im0M4XlREHP0KET8YYav3vY6x+oDiHnUv2bM//FLsSId36VvvDYvCSMVSbEyMbc/C0/D NREg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eeWX7v3mCJkie8JxyChOPZGxBhayJemHVHehVmASuUI=; b=qel3ZbhWVEaMllk+docIno9Pxhlj8kA0JQJPSc2gafyIVLsept1kH8OiEganalhohu jxsUOSz2U7J5yGUNiUGceXPeO1IqoxlL7RqUpL8NW1POeLHRYXXVUWnk4sHEXt9dSI+m KkqkIfeh8hOpvxxw03x9jw39zCkl2DUUrLPeU4u7yKYjdVdaYG82yeLay5a9HDMYblAN 291OCmQ6ShuWz8lyf5XFAL1bTrhZ35nImr9Jftcsq7NP5uzW4EOTDU2ZAYuJmfwH/Gog 6wYj691wHqfHR+EmkYEqpM42lWW0YxDle4deZz7NOBY1NdF7YCSl90AwjkY5ibzabFxR My0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fSSIxS/2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si4975402ejr.84.2019.10.27.14.25.31; Sun, 27 Oct 2019 14:25:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fSSIxS/2"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732064AbfJ0VWD (ORCPT + 99 others); Sun, 27 Oct 2019 17:22:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:42980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732053AbfJ0VWB (ORCPT ); Sun, 27 Oct 2019 17:22:01 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDC282070B; Sun, 27 Oct 2019 21:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211321; bh=ReglJFEYFZJHDzlpCC3pzyMEJOdfKYqm49G+LpI+siY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fSSIxS/2aLYb2Moboa2+wiFHNeMW435BcVxCgBHpv5eqDlbPHHhlyuphmXY2SpNQg YRMWPJH/iP9LuKEBVEiKKo/PMGwRQ9Kz/y3H6CmN+jK0HDqH5V1XrCAY04wG07uHHk r11bb9CJ9vOGdPPdhsbmouosG9os4ia3qbbzDBHQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum , "Martin K. Petersen" Subject: [PATCH 5.3 110/197] scsi: sd: Ignore a failure to sync cache due to lack of authorization Date: Sun, 27 Oct 2019 22:00:28 +0100 Message-Id: <20191027203357.686595342@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit 21e3d6c81179bbdfa279efc8de456c34b814cfd2 upstream. I've got a report about a UAS drive enclosure reporting back Sense: Logical unit access not authorized if the drive it holds is password protected. While the drive is obviously unusable in that state as a mass storage device, it still exists as a sd device and when the system is asked to perform a suspend of the drive, it will be sent a SYNCHRONIZE CACHE. If that fails due to password protection, the error must be ignored. Cc: Link: https://lore.kernel.org/r/20190903101840.16483-1-oneukum@suse.com Signed-off-by: Oliver Neukum Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1655,7 +1655,8 @@ static int sd_sync_cache(struct scsi_dis /* we need to evaluate the error return */ if (scsi_sense_valid(sshdr) && (sshdr->asc == 0x3a || /* medium not present */ - sshdr->asc == 0x20)) /* invalid command */ + sshdr->asc == 0x20 || /* invalid command */ + (sshdr->asc == 0x74 && sshdr->ascq == 0x71))) /* drive is password locked */ /* this is no error here */ return 0;