Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2253318ybg; Sun, 27 Oct 2019 14:27:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAalRc3wPjHxqY/5o4DWQpTQR52KuzLbDQoDxFL+f+E8fZbN+jtJcxdYF3XkblM1OXPvJw X-Received: by 2002:a50:f699:: with SMTP id d25mr15857253edn.72.1572211662639; Sun, 27 Oct 2019 14:27:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211662; cv=none; d=google.com; s=arc-20160816; b=Ar8d90cY2sh5XUrTONccoN+OF+wDX+P2f059eTw9/+oyPtGnwpP2+pVPGEI0B2nrwi FvkVjRxsFLGGq7L+SOxuI9XxPjLQkgUjaCNyBg34OJZlntnNMMjS+zQu5+6x5uxbvHfF 8JXLNu55SxwnZrJF1XspOxB6Wo/1ovsA3mcelazEFZoMN7nWWVdC+2Uw07OlMiRcZ/4d +ry/QM74V5CPtPi6GQi33W7tud6AC9Oy6RiEFwy5j0VtNxReiXTHYqhTOWmQewdTx/lI g+Tislrpapt9VhnJXND3V6ymEqOzXN79dVKWc8SYeyxQSmOAkpORH055wu5LiXhwbq9r d4ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6gYDfv+YVMJmWZuV/A/9wo8jIoBjvdp3Hl3xcBsiiRg=; b=ERWvbXtzXUa2eHzS4EL42CtaaTFRbQYDukOh+H6WZNrlTfIMMax+EFZOLJJioREIcL jAf6xauKwnM/ZH8ITZ9e6Dk6f7ucUxnDGima6mlQzgCXkiqkbdm1tagpq/NhOvPzk+fQ NWAixC246WhI/Mu8Nfmrom0IWrKi8WLH6+ZQRO0xsrC4Vejz/erXMTUz/aM93aVdBKED NgKCUjBY5eYcWU6GMt+W/Z93dGzP0GP+u+q48DVEcONJHX0nQA8Go7z64DZ6PxItGec6 HmfDbz2rhWG4bMnqPzN2sbvNURlmmyIlcRPjZO6BJhguj9dyoRvw5VJEe5tVkFlAyVnV BJCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Op+8Kh7E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 49si6351311edz.9.2019.10.27.14.27.19; Sun, 27 Oct 2019 14:27:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Op+8Kh7E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732820AbfJ0VZx (ORCPT + 99 others); Sun, 27 Oct 2019 17:25:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:47766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731794AbfJ0VZv (ORCPT ); Sun, 27 Oct 2019 17:25:51 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C011121850; Sun, 27 Oct 2019 21:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211551; bh=Tm4BdJN9ne3+ntdGFp4Y+4aAsgJ97NXwx5V7GJ7chI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Op+8Kh7EXJQc92IJOpQhd60ZfkJeKHvnmOYmoK4pBknFdMkrazeQfbH+UITOrOI8T XMPz1QzdeomLr8kFdYZm+AAp6MgzQoCZoAxs8Be+hP/mCNkyS8yQIEP0oUw9edl+Cl laN62rHa2IfQPXam5Pg5WG7zKJ3OmXzZYAGjZP5A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Juergen Gross , Paul Durrant , Wei Liu , "David S. Miller" Subject: [PATCH 5.3 192/197] xen/netback: fix error path of xenvif_connect_data() Date: Sun, 27 Oct 2019 22:01:50 +0100 Message-Id: <20191027203406.850717453@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross commit 3d5c1a037d37392a6859afbde49be5ba6a70a6b3 upstream. xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: # 3.12 Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Reviewed-by: Wei Liu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ err_unmap: xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; }