Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2254104ybg; Sun, 27 Oct 2019 14:28:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqynA5V2ux77xIdIrxBxqavIqOdd/UfeZJVMM1Ci+XCMcAXFSs9++KvWQtWxSvl/mcRxd+ap X-Received: by 2002:a50:fa0d:: with SMTP id b13mr15851729edq.101.1572211728657; Sun, 27 Oct 2019 14:28:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211728; cv=none; d=google.com; s=arc-20160816; b=IiViN0N8CsB9j5YIPwqdlwbDkdfo7ouN1u4nbJoX3GSmGi+Uu5s3YIs/BTITVrXfqv Z4wA3iHppFNBT2HZLXYYwqBMK5zBpCttSO0Qp/hjBTNK9DRLeFSpuK7IaEgyNrYLp7wd DMqRquX8ykMbcQn92SClBBLh3Z56DouCzLfwx/Sx3WHwml0406VyBlepGigw4Leg9pFx Zq8XQK7O7F6Sbb65EbWGkzO0gkxv8lG/0yTW/9lgdOiFgcSmda9ePDMawdXOZSwZradm u78rDfg1nWgh9Jg1AwOvtatokIpRWYH4jGp1641vzY+g+4MQbB3N95iV9QPd8PwbciLI UXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HdkqHJaOmOdD7y4vY5VZvnrLoz8rVCiVDgo/ABazgtg=; b=J8AdKrDJ1wnlaTBJGQYbP58wZPDb8yuBtMbL5zlM8aRQMKHHFWPFIbKsFDfPTSs06R TYn/VNPRA3bBYXYGeGiQO1+kpoM+wOsiQcqyDIncLTZoYnli8h6PZ6Ts7+pqN+C04e3Z wQrxp04tpO/HX8Ni9bjkD9W4ZyQc0yJzAJrSeziWcpYvf1oAOQhqkzbot6dKyi0KUdMo KPtMsB9pR2xpGbyRLcHEGzZ+2TjYW+GL2Md+y/0GNDI4mhS8uEsqbAETULLUaNY80xkz ghO7pthLtBS2KxcJ9uTjKyY8mmB5RX69MwZmxkEd9sm704wecNpi9fMLw1R5JZ7qCKIZ 2V1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lPn1s50c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s38si1872437edd.351.2019.10.27.14.28.25; Sun, 27 Oct 2019 14:28:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lPn1s50c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731783AbfJ0VZq (ORCPT + 99 others); Sun, 27 Oct 2019 17:25:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:47554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730905AbfJ0VZk (ORCPT ); Sun, 27 Oct 2019 17:25:40 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6971F21D7F; Sun, 27 Oct 2019 21:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211539; bh=9hY8NZOhxzV2KeZA0eTHKZPgwdCjCBrLUUEhiwi4SYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lPn1s50cbuAgD026+8a9f46XJqiQYtwOn51UFheiHaWqdb723wEpmmxbqPGu2MI7f JVP1WxFmtGfpgLP2p6ym9RCLJOlKQpNk0ckA8whotqVBTrPJKoOOWe7KGwOXKmsb+M B121Mw3ZoLCFDwwAiBGpGX1eNgxAVmT/5apVPhoU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Patrick Williams , Linus Walleij Subject: [PATCH 5.3 180/197] pinctrl: armada-37xx: swap polarity on LED group Date: Sun, 27 Oct 2019 22:01:38 +0100 Message-Id: <20191027203405.720033249@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrick Williams commit b835d6953009dc350d61402a854b5a7178d8c615 upstream. The configuration registers for the LED group have inverted polarity, which puts the GPIO into open-drain state when used in GPIO mode. Switch to '0' for GPIO and '1' for LED modes. Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx") Signed-off-by: Patrick Williams Cc: Link: https://lore.kernel.org/r/20191001155154.99710-1-alpawi@amazon.com Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -183,10 +183,10 @@ static struct armada_37xx_pin_group arma PIN_GRP_EXTRA("uart2", 9, 2, BIT(1) | BIT(13) | BIT(14) | BIT(19), BIT(1) | BIT(13) | BIT(14), BIT(1) | BIT(19), 18, 2, "gpio", "uart"), - PIN_GRP_GPIO("led0_od", 11, 1, BIT(20), "led"), - PIN_GRP_GPIO("led1_od", 12, 1, BIT(21), "led"), - PIN_GRP_GPIO("led2_od", 13, 1, BIT(22), "led"), - PIN_GRP_GPIO("led3_od", 14, 1, BIT(23), "led"), + PIN_GRP_GPIO_2("led0_od", 11, 1, BIT(20), BIT(20), 0, "led"), + PIN_GRP_GPIO_2("led1_od", 12, 1, BIT(21), BIT(21), 0, "led"), + PIN_GRP_GPIO_2("led2_od", 13, 1, BIT(22), BIT(22), 0, "led"), + PIN_GRP_GPIO_2("led3_od", 14, 1, BIT(23), BIT(23), 0, "led"), };