Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2254201ybg; Sun, 27 Oct 2019 14:28:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjct4GXLn9IzKkvBHXxCxL361I8xt76UgwvRI37NPxMQIBtU/YN8jt+bBR3mZKv7ertPdv X-Received: by 2002:a17:906:7208:: with SMTP id m8mr13623040ejk.141.1572211736552; Sun, 27 Oct 2019 14:28:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211736; cv=none; d=google.com; s=arc-20160816; b=c1rdcJo8xAoBH/vAmEUTqzVtp1XlBuXfOLxNFlxgQhazY1EDhgt2CWSLyGep2wgjsa wMW7R8kcvEG0epEF5ujKFYAJjLgQgnqamcTIs9EnObCD73OYgISIfKKzN8dPK8jzNoGO ZNtfCnhh+m7iGGjU6U/66TidHbCt7vwB5vI4KtDuixnL+7vA8xfJEocTHOUUlKuQjhAi Cr6Iq2lYWVFcPyGaPzVop0QE0/nWValqYcWlg+lWCIfhBJ9Fv5euFFop9BD+oOvA2adT bYKPPrGXBnX//blOXvioIMlCwa0fK5iIZqJzGpXYVXshtI3XsBWmpUv8BXcv6AshwH2A 59DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u5V5oTOgXBsFZ3pvrwem8Q9MhMdymVsM23F3f7f7ngU=; b=zl6JFrik3ypdbjwr2Ze3fcOcUaAunpGLTcXCpyHPUchZaAAjnLrq0zUi2kKbQFA9x+ mkOhQPfjhg5TJNJ3jahXwVPFi5H+dW4Jy/VYaJDuMdkLekfGW/dG8xORllldMoYEfSjL wIifQlIePMHsVZlnfJ/ai2SPr1GoFekqWDxMBkcumLXn1rK7G8RbIn8x45FxJtigmuLl 0/Le2NXbETUXHk3TNRqhfH6SkCYgZeWwFvOTdfjmn+u5ZOQz1wQ/I4d+SsBAb9RCYx+3 StCNfSOB9e5M/18vaX1j3uU0udReuSygU/i0ktssSlzzUM4IRdVTSsJbQyAwbO8aezOZ 6KUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RFN7OwTO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si6949513edv.422.2019.10.27.14.28.33; Sun, 27 Oct 2019 14:28:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RFN7OwTO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732647AbfJ0VZE (ORCPT + 99 others); Sun, 27 Oct 2019 17:25:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:46720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732634AbfJ0VZB (ORCPT ); Sun, 27 Oct 2019 17:25:01 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F29221848; Sun, 27 Oct 2019 21:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211500; bh=3v2CFzO8u+SwFTSx3GvJ7V2Rq8W5YnaxDv4MV1yXFjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RFN7OwTOR+nPTbeHxx0iegMIZGOiGeeTqLXbJT0UdKTH+1aGKrjWjvwMUF8QHv8oC ADknZ5a7f0pTmqEOZeBZ5Gj/xK7rpMybYJ1S5thHtcp83T+nOIZb5JQCNKKMFeBakT 5rSgFcYbrkhYZ8V6Ll4cjN4MFoEcEJ1H9CkdKP74= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Hildenbrand , Naoya Horiguchi , Michal Hocko , "Rafael J. Wysocki" , Andrew Morton , Linus Torvalds Subject: [PATCH 5.3 136/197] drivers/base/memory.c: dont access uninitialized memmaps in soft_offline_page_store() Date: Sun, 27 Oct 2019 22:00:54 +0100 Message-Id: <20191027203359.053510896@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Hildenbrand commit 641fe2e9387a36f9ee01d7c69382d1fe147a5e98 upstream. Uninitialized memmaps contain garbage and in the worst case trigger kernel BUGs, especially with CONFIG_PAGE_POISONING. They should not get touched. Right now, when trying to soft-offline a PFN that resides on a memory block that was never onlined, one gets a misleading error with CONFIG_PAGE_POISONING: :/# echo 5637144576 > /sys/devices/system/memory/soft_offline_page [ 23.097167] soft offline: 0x150000 page already poisoned But the actual result depends on the garbage in the memmap. soft_offline_page() can only work with online pages, it returns -EIO in case of ZONE_DEVICE. Make sure to only forward pages that are online (iow, managed by the buddy) and, therefore, have an initialized memmap. Add a check against pfn_to_online_page() and similarly return -EIO. Link: http://lkml.kernel.org/r/20191010141200.8985-1-david@redhat.com Fixes: f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") [visible after d0dc12e86b319] Signed-off-by: David Hildenbrand Acked-by: Naoya Horiguchi Acked-by: Michal Hocko Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: [4.13+] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- drivers/base/memory.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -554,6 +554,9 @@ static ssize_t soft_offline_page_store(s pfn >>= PAGE_SHIFT; if (!pfn_valid(pfn)) return -ENXIO; + /* Only online pages can be soft-offlined (esp., not ZONE_DEVICE). */ + if (!pfn_to_online_page(pfn)) + return -EIO; ret = soft_offline_page(pfn_to_page(pfn), 0); return ret == 0 ? count : ret; }