Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2254938ybg; Sun, 27 Oct 2019 14:29:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqyb6zZmM0KIW3eHdhwlfVBSJ6DO/qJmNHFoTwEhPjJBohcO32UAJ5zNGeqYWJzIxjnY7Acv X-Received: by 2002:aa7:d81a:: with SMTP id v26mr15882673edq.213.1572211797816; Sun, 27 Oct 2019 14:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211797; cv=none; d=google.com; s=arc-20160816; b=U8FQy6KOfCmwQVcYyZQeOafSLEpapnW9xsQ+fN3WaXu6NmtehIY95TIMRigB+cQdoT 7B06x2VCKhSsTnFi2vqTkkuQ0drZN5FLUKn9BjI8Kh8rpu3WxfCV+cGE9GFMrO+4+Yp8 UWwPQnfgld532vOROZVKxipNuCih+1fGiRS46hOemQQZT8QH1R6OTOn2bzMrdcwdBY4n MpDADGpFOBG0GtV0slF5flsF8NN8uXxVOzhhOAzajE4/GTPUwA0wjIzYm1tdhswPMtaI jPx3DgJK4NaFnTyZV5DxoXNWORnLbokdwyyQfp6GTmlO33md/Si1h9mY4iOouPNj8611 MvOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pM6UVA1ZX59DJ5bNqb1uAZqwODPIVPeETBJ2GWn6DZY=; b=K59YRBKhJv3K0kcp+9XBJ8xjUO+WW58o+5Z74WH+5UiJsWwtdlLpxr7WYtrsyxAuJF qOb8Svp2dIGvU2LslHkpMTrxSMmVXr+NfOK6qrsFSY8bbz1ks4+iBm85EfIYTZ24uWEW NRYV0bpFsiIl9uEUWjWN6hyiI3roEanamJVJ7tlOraQNMnZWKoHpFVcbZbu/hXt5HP0n UtgAOvZH7q7mZ96VlZzw2bpJCVNtNnybLzzhpSe/R7auQVVyOe8ta86KuRzKL3vd4+gP l5aQJ4VFjd3UxJ+4+8S8J3Lt0lAozCN9PXMjVvell0BO6niX0RbocA30FX343GOIDOSu 8AUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NmUi6tEx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 26si6130956edz.340.2019.10.27.14.29.34; Sun, 27 Oct 2019 14:29:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NmUi6tEx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732883AbfJ0V0K (ORCPT + 99 others); Sun, 27 Oct 2019 17:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:48084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732871AbfJ0V0J (ORCPT ); Sun, 27 Oct 2019 17:26:09 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D01FE222C5; Sun, 27 Oct 2019 21:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211568; bh=SuWVog35rq4t9m85OJPt6eblq9oTPRJl2/Qpvf7D4LQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NmUi6tExTKDorG4EB73CgIzqASzZhsaRgVFTrSz8ILydVSwZbAnY4ap70KsmyJYU+ vooFOze1CEYg8GMdMfFvOCxvKLCi/M826kxZfSxw4E3prVGz2pN3vioierR8oZa/Xu pxlBbt7Kib2zVHOCFSdlzG76Ps9OkTZewhPhoUpk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anand Jain , Johannes Thumshirn , Qu Wenruo , David Sterba Subject: [PATCH 5.3 181/197] btrfs: block-group: Fix a memory leak due to missing btrfs_put_block_group() Date: Sun, 27 Oct 2019 22:01:39 +0100 Message-Id: <20191027203405.822561757@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qu Wenruo commit 4b654acdae850f48b8250b9a578a4eaa518c7a6f upstream. In btrfs_read_block_groups(), if we have an invalid block group which has mixed type (DATA|METADATA) while the fs doesn't have MIXED_GROUPS feature, we error out without freeing the block group cache. This patch will add the missing btrfs_put_block_group() to prevent memory leak. Note for stable backports: the file to patch in versions <= 5.3 is fs/btrfs/extent-tree.c Fixes: 49303381f19a ("Btrfs: bail out if block group has different mixed flag") CC: stable@vger.kernel.org # 4.9+ Reviewed-by: Anand Jain Reviewed-by: Johannes Thumshirn Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/extent-tree.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -8117,6 +8117,7 @@ int btrfs_read_block_groups(struct btrfs btrfs_err(info, "bg %llu is a mixed block group but filesystem hasn't enabled mixed block groups", cache->key.objectid); + btrfs_put_block_group(cache); ret = -EINVAL; goto error; }