Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2255764ybg; Sun, 27 Oct 2019 14:30:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqyGgeQ4xQRRX2wiymBv6pNC8dTkG7RkCx3Ljc4/Z0gZLCeMw4+XdLPYR6JtXDlRPzS21FUp X-Received: by 2002:a17:906:4d16:: with SMTP id r22mr13992241eju.244.1572211859532; Sun, 27 Oct 2019 14:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211859; cv=none; d=google.com; s=arc-20160816; b=pYui19AaOt1SJS6pup0SuGJG4q/Pu7xTddrHSET+7EDiyzCOa6hbA4HLkXwVckeRf4 oeLTuVxqAFHToJZDShz98gukgSHl+nwnUv6GulkGmi0ufDaMTdbs/1R3RCX+0CWVbLh6 FS87PTFvl46tKi1+RYfgr48AY7HqxvOtPNtcBNRqWGa/ch6RlUNGtman2V8ZtULTtVP6 Rfr5nXY0h54u7QLTOYFonXzsAlklSEbpmo3DaFgExrD7NYdJXHbpV56+qjSXPrY+NMRv hKs+N+moZPNxUK/2d+P4Op1ntvF4P1mXlfbqFuBWwPyDaBMGI5pjb5Oqkcs8Tv2xlIMb BVmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EKInaT+MF6kGoQy1UPXC0b8tw+UUzutDI4gUwmnAUO4=; b=zUni+57AsbCJFjioWC7mJMQiMKulADTlKPBNzJ9KvE1OF81QCecA/AmogRSs3etnm9 cARCUL8iANUsl0g4b8v6mDDC8Z0ej0Wy3LC2faRSFPNMYu8zMhajXq+6sJ3P1kbS94DT CKX4pSiALIMKVz89yU8VUz/R1DoFE4+63pFgp6MkZQXJlbj5sk0oHe8wIP7OFSUfDyPp zkSC0bam3Ud47zynn6cr2wGThro2pVFyELUK1fBolsYtifsA+YX6icxcn/kXXGbHa5aZ agMu9/WPud0rP8IlPZscNxUfnqd3JBBk134saOwFv+Oqfp9bn4ev/1hIngnjPME5O4eh o0Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HyQHS0N8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si6501631edi.308.2019.10.27.14.30.36; Sun, 27 Oct 2019 14:30:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HyQHS0N8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732174AbfJ0V3K (ORCPT + 99 others); Sun, 27 Oct 2019 17:29:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:42116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731905AbfJ0VVS (ORCPT ); Sun, 27 Oct 2019 17:21:18 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E66D205C9; Sun, 27 Oct 2019 21:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211278; bh=IDU0l7Efib0taqOJVNYTz6XobOyDC5hC4mNkcR0XXIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HyQHS0N8+WK22a5gqk+7v4FchY327vrhsBDz5rvfn9Qx5xaKfn5bS2/VtDPMatPD+ paMx3vxLvDRpbqNUh7wFi9D8v91jrjYLqyR/Y3n9L95Ve+FNM23AYXVdUbyOvvkYig KdCPu2tLO5TOTUOPH5lD+Zu+k9pOGOmfzq2Q8jkQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 5.3 096/197] USB: legousbtower: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:00:14 +0100 Message-Id: <20191027203356.951598018@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -419,10 +419,7 @@ static int tower_release (struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->lock)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->lock); if (dev->open_count != 1) { dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",