Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2256119ybg; Sun, 27 Oct 2019 14:31:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhngWDRbOm+UrFt4N89FVomKT9WVT53WE9WGLr9o8YzGZlI6TbACyqXQOCoG3DuYRKW9HZ X-Received: by 2002:a50:875e:: with SMTP id 30mr16438264edv.45.1572211884663; Sun, 27 Oct 2019 14:31:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211884; cv=none; d=google.com; s=arc-20160816; b=EgNzxUipJEL8CJtshvAxPdc+tKRhUvmL3XyQu4KDP7GCxrDAE+bk83kc2wSaOHVAXw QqSdkvl1f/fnZxCfJzVxjCBCRj7WkedHsJB98BDxjfmVqtTPh6IfQA8GjD4uW/sNtf05 kQqYVR6W76QG6PSA0b/nJnltnhFPCoZEEM+gLdIDxkJMVVnErgTgbJIDIkgCAqDy6M45 PQEW/PgLbCO3kACGcYCPvdnfKarUJb8rQzW2JKj+59jvU7IaxNiimtGJZkema1ajMFOv eY0RwMxOi4SKjyiPCeTHClvwU+nuzEl+CwZzhmqSf6Sdixbz0PraUt2npwATYoX7yVYF BBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AahogUKvUFLcUTq0u3hiykbA4RPEXoc6PBfG7Yp3JLs=; b=MY7lD9plNgsAjZP2NCVJRKt0OVCufKgQ3b6p5l1lhPHaCqbWhb4/BLMsNmWRTPNZTO 5rTbJ/cNiolqwdr8FnwG9FSehXgDu0r5PnIRo5SjTE8H1C1vsT+MpPdOUfze7KrjcKfj HkuI5pYHSQ+Zd/wwvv0HkhrRl+GQTvYtXPnCHAMWi4OvMw9YWfP2aM+qq9n+xqVUqaZv oXPKTjAeH9rPKnDL1CJ3YPaNtf3M9SLFb6Yig2HpmA1KXbGaCYhD7fdwZ30CWD08/KsA RWdBv1ChS8FajZbBGHxSFOdSKsylaO/Nae/Zr6GvJFtecCKNBn1SXNB8TV7JAXuJnHFR PypA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hRYxCCpy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si6574337edd.364.2019.10.27.14.31.01; Sun, 27 Oct 2019 14:31:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hRYxCCpy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbfJ0VYv (ORCPT + 99 others); Sun, 27 Oct 2019 17:24:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:46480 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732602AbfJ0VYs (ORCPT ); Sun, 27 Oct 2019 17:24:48 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C3DD21726; Sun, 27 Oct 2019 21:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211487; bh=N+kWJLwgSsVt7OHRx66ZKiIwoYg4+RuJ2BmXw6eqNzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hRYxCCpyXerg9uVUzbaHHtbxx8TOwoCCbuqU2ubrQH0RiJZVTnJErKkFlKDKO0Gw+ iFQ542MwxbK7xn/CbfIIOx3gE6OeEnxgcCvqjr8ut1xnxBpUfJkRCm5HuI/nD6xEiF Vio6CNPjNOtE2epNBG4tfzO60kZezmiBcLoQ3x+8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Steve French , Pavel Shilovsky Subject: [PATCH 5.3 168/197] cifs: Fix missed free operations Date: Sun, 27 Oct 2019 22:01:26 +0100 Message-Id: <20191027203403.449576521@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan commit 783bf7b8b641167fb6f3f4f787f60ae62bad41b3 upstream. cifs_setattr_nounix has two paths which miss free operations for xid and fullpath. Use goto cifs_setattr_exit like other paths to fix them. CC: Stable Fixes: aa081859b10c ("cifs: flush before set-info if we have writeable handles") Signed-off-by: Chuhong Yuan Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky Signed-off-by: Greg Kroah-Hartman --- fs/cifs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2465,9 +2465,9 @@ cifs_setattr_nounix(struct dentry *diren rc = tcon->ses->server->ops->flush(xid, tcon, &wfile->fid); cifsFileInfo_put(wfile); if (rc) - return rc; + goto cifs_setattr_exit; } else if (rc != -EBADF) - return rc; + goto cifs_setattr_exit; else rc = 0; }