Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2257109ybg; Sun, 27 Oct 2019 14:32:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpAaeCnrzM83pKGaQwd/FgwqIKcb/ZtPxf6hKZ0b4MKJOEj9Xj5bQ15TW1GK63vtvCu2Wp X-Received: by 2002:a17:906:1949:: with SMTP id b9mr13683819eje.277.1572211964191; Sun, 27 Oct 2019 14:32:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211964; cv=none; d=google.com; s=arc-20160816; b=h8FMiJI4muRjAW96ixZabhPH3F+yEa3YaJVUSibXldQl4MJgx07Rt3KdDXN1Y4v/49 h9AohRQB7gBN2zFZ3kPNOzi/b2MFpUINwrOsG1egOUJdsnicmfUsYWGIfiW1ku3Qy4ym Tb3b4TW9fgxuYhWywbuJyLynFtjhr2bQYit9W74liXXu7/zUpLobr/Tj2YpNJR9GEWZj r+nX+WxfyoLYt5KiJiCInBqqwxnfXvQTwuGv4PXYLWscvn20+LVD9afukPwyoQzAjZ9q C1ERFUxtFWz9AMuCumnoIocV55LOmeqaqyjPQbb45RUzB0z6EpYv747eT/OTkR/PAh/r AvGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ij3JZecX5WRt5H5FGO7RVIT8tpYQTJbguTCWhw6lQOA=; b=MCpRN0ZeAndu4U7DpjbHBn152fHr7z+mLZFYlAMdOKgue0Ax+wdmHcsI0ehjZPwjQg n+F6IgpRMPTQOwMnqSj8J8NjYQ4neyqbFqH7ES9ttPyZ4xqCmCLwxv6HW/W8ugxuAs2u s5HFOLWvAh4ZP4wOJeCkJbn0xoDCQp7WOIKGWWMXD43JbPKngzbE3kDpEcQH5ggclTqI Hva3fYlpDaGOQHZK0uN/u/nKU3LbYyvUx3/dyShezcDbajHXjsc3ERk2pWtosGefL+Li hRa8gFSkVxtAfZFSSA9FfS1DwMPRIPk+APr/pFHSPbsBz0Tk9Nuzqz8icXpMQHHKwJtb mpaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xYhGSP44; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si5030619eju.349.2019.10.27.14.32.20; Sun, 27 Oct 2019 14:32:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xYhGSP44; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731197AbfJ0VSA (ORCPT + 99 others); Sun, 27 Oct 2019 17:18:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731189AbfJ0VR7 (ORCPT ); Sun, 27 Oct 2019 17:17:59 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D20521783; Sun, 27 Oct 2019 21:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211078; bh=dIhYXqC6zsENCqrC+i8wUr7eKSJQEN4dFD25TriTo3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xYhGSP44w0VeCqzyLfd7MeiCp8cCao2QideoMGG5+wST55IzcbYHjXPSMJWhzuI5+ +HiBHIB/R3B1kSLcwjCw0ODeF+LzBgt9a8vgHr1G1diP6F7vuyURQmL5E0jak1TwTf kUjKZvgDOvZ6U0KqP7DXTXX5hcXDEnxfacXEwIp8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "James Qian Wang (Arm Technology China)" , Sasha Levin Subject: [PATCH 5.3 024/197] drm/komeda: prevent memory leak in komeda_wb_connector_add Date: Sun, 27 Oct 2019 21:59:02 +0100 Message-Id: <20191027203352.994952769@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit a0ecd6fdbf5d648123a7315c695fb6850d702835 ] In komeda_wb_connector_add if drm_writeback_connector_init fails the allocated memory for kwb_conn should be released. Signed-off-by: Navid Emamdoost Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: james qian wang (Arm Technology China) Link: https://patchwork.freedesktop.org/patch/msgid/20190925043031.32308-1-navid.emamdoost@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 23fbee268119f..b72840c06ab76 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -165,8 +165,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, &komeda_wb_encoder_helper_funcs, formats, n_formats); komeda_put_fourcc_list(formats); - if (err) + if (err) { + kfree(kwb_conn); return err; + } drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs); -- 2.20.1