Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2257292ybg; Sun, 27 Oct 2019 14:32:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNUDGLVdrJN9IiSVqlgkTALmalMr5adBWIgKThrKXyyMolzqI4iI4f/JWDdbhUce24toHF X-Received: by 2002:aa7:db17:: with SMTP id t23mr16097320eds.135.1572211979442; Sun, 27 Oct 2019 14:32:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211979; cv=none; d=google.com; s=arc-20160816; b=cpZC9dXx8e+JGOgkQmuvoTQRUm0yOqYxmKvEv1twCb06sxsx9FDPfV4H7hXi75G+10 D/RlaB+5wlKbL3KHtxOMx2Ys79CkzZXtyIj+S8jl7QEkwIl7a94NNRW4m7d957I6ckvj kLWCaCmMSGptuk9fXRQDbk88bv05PzQQvQYXm0nW74NPrTSxspIH18gLSl34E/P36oBq HiuYopNHizSMELQW5fTeWqI0fu4yWUIqriCbfxbLMXbgvzlAA4O7yO7NQwcsGeTRYpPs N4LLXaCDXRRzBSRoJYoMNeEOHkW9sKJACZYC7YE8NB9gEObFWyq5s2QbOJHv7Emv4W7Q vTKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Nc1bMhYS7FS6TeOv/6a48SDw5/6hdcnA3t09sZRVFoQ=; b=EQaFgU3KNNOrje6k+IIAFGfLqkYNF8x2II/pKW5pkUdewlL9mYvTddpqiYPquQLVA3 EXAqVPcj/EnX39mtg7FneV66sbvPOm62+SlPPRyP0s2YDYOlmlHNxZnn35yB7PDokqDE P8A7S/t3xxJC6LrMB9OGVHBEwBrE5fZWyt0o7szak3A1ipYx2Q8dNPjCWKznZTo23Ty7 KaNtBtHBqlv98i9NQT2Pvm+jTqFxIMheTnFKgQEps+y666iwNUyu97KIVEdDR9M13+sU pmp2YkEV+JukG6moN8sY+o4fNHUaDy6vdZEPm6BYtwGSLMURSauRwjHrwGL+Do9ob/nf 0Zjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UMbkxQeF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b18si5849452eda.307.2019.10.27.14.32.35; Sun, 27 Oct 2019 14:32:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UMbkxQeF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731106AbfJ0VRn (ORCPT + 99 others); Sun, 27 Oct 2019 17:17:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:37604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731078AbfJ0VRl (ORCPT ); Sun, 27 Oct 2019 17:17:41 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E319208C0; Sun, 27 Oct 2019 21:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211060; bh=iezhzlRdqtRKrCvQN3UCRIlAx7UiuWRw/K0Y0zQsiyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UMbkxQeF97/GEIDciOOzduThES3te8/DjruSqYHqm3lCyuJ+7emP3vq80pYS0HzWx r+4T2oL2LEfK/PuDoh9K+mJIIaqbGZtWml3rdBFgvjyrkx++uS/oytkDrgsOarWcJy xzjI3XZeopiDtK71JE6xbu6b+aYkWafU1FADTjYo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Keith Busch , Sagi Grimberg , Sasha Levin Subject: [PATCH 5.3 019/197] nvme: fix an error code in nvme_init_subsystem() Date: Sun, 27 Oct 2019 21:58:57 +0100 Message-Id: <20191027203352.711340891@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit bc4f6e06a90ea016855fc67212b4d500145f0b8a ] "ret" should be a negative error code here, but it's either success or possibly uninitialized. Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list") Signed-off-by: Dan Carpenter Reviewed-by: Keith Busch Signed-off-by: Sagi Grimberg Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 28217cee5e762..ac2ac06d870b5 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2513,8 +2513,9 @@ static int nvme_init_subsystem(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) list_add_tail(&subsys->entry, &nvme_subsystems); } - if (sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj, - dev_name(ctrl->device))) { + ret = sysfs_create_link(&subsys->dev.kobj, &ctrl->device->kobj, + dev_name(ctrl->device)); + if (ret) { dev_err(ctrl->device, "failed to create sysfs link from subsystem.\n"); goto out_put_subsystem; -- 2.20.1