Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2257365ybg; Sun, 27 Oct 2019 14:33:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRcReER+i7CHxmrfSFS4WrQ3pq+C+Es1Oh/ZduESjav/E7yWbdt+VAJbMEpcoUsXGxEQNL X-Received: by 2002:a17:907:11c7:: with SMTP id va7mr12147381ejb.182.1572211985419; Sun, 27 Oct 2019 14:33:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572211985; cv=none; d=google.com; s=arc-20160816; b=u+945GkAV5AZHAXpctevyu7FPIAmJEQ3bMRGCQSQoNbtw6oz8MaI8kV0xxqwK2x7kN 6NFd+bot8pqf6HPTR/lgTj77B4boO9JM3+RuGJo0eKmPxmcs0EXDVCyltdf80PFvoY9G GSblXuwILPrHaJ86I4qj24dN5lNVo4nsicq/iUEjZmmers4A/v3CHFcOd1au3FknhrwO aDbKt3NR8GJYw2+iMQwoLbkd7ha7BVOtMIusRNlvYwrTRX4NDBlHsV78PlSjHyGU4SyV RTAduoBZldJDr9/yD0vdMMoOQY25+1BF8dkJS2UUifHETrGW5QF/rB2TfJQ2TOISna+u AzQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CknhAJuVOI8r9hFleg+PT4F6+zsD9akR9d5fJvbf8Wo=; b=NeC+KDM5h2KX4p7nq/DJ1fZapMDim7UsjkTD7mwo040BXvitfqd1a8WXWHc4zmp2Cg EwOulglOJz7Cr+mYGXevgKpUSCrls72aTEAHGwXltMZPRBnAySaQyaK7ss9fOswuCHJY D+YjDxofxLbq0iIbvuRQ22m5fz/gSwveJ+SaAJl8XCrnABIJlbrHdX368cgSpPw/W3ot Gd64zjNp1g7UcwJ0gBgG7evtZCZeRNKXcgP5Yg2eJR270DfFPa4gnv/j/3z2+0yxoHf/ 96zAf378EnPGy2fopcGfaWG5yVCiI757YaJBm8FSvlvB26zMHSeG6xiwKKzM0dNUh3HT WA/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AbTcRIih; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w54si6543514eda.214.2019.10.27.14.32.41; Sun, 27 Oct 2019 14:33:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AbTcRIih; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731072AbfJ0VRe (ORCPT + 99 others); Sun, 27 Oct 2019 17:17:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:37320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731059AbfJ0VRa (ORCPT ); Sun, 27 Oct 2019 17:17:30 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 42071205C9; Sun, 27 Oct 2019 21:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211049; bh=DoZbOJkyEpxr8O1/upunQtXlKDIbBtKBteci4Ek32YA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AbTcRIihGC+DCpWC3IpEyNpE2uqd5CAHxIGW7DXRSdJUqyE9P18SmEFEqRoJ3zNZu XGbHOimgyn7jD8TGFYFWhchLm5TwnaK2ISkRt5GItegfiJO5o6iHG1I6Es9qMYB5Zo xdZWTvEAD+NkozFzNlK9vhE3wkFrrfWO20vJJxO0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jyri Sarha , Keerthy , Robert Nelson , Suman Anna , Tony Lindgren , Sasha Levin Subject: [PATCH 5.3 015/197] ARM: OMAP2+: Add missing LCDC midlemode for am335x Date: Sun, 27 Oct 2019 21:58:53 +0100 Message-Id: <20191027203352.497559276@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lindgren [ Upstream commit 17529d43b21c72466e9109d602c6f5c360a1a9e8 ] TRM "Table 13-34. SYSCONFIG Register Field Descriptions" lists both standbymode and idlemode that should be just the sidle and midle registers where midle is currently unconfigured for lcdc_sysc. As the dts data has been generated based on lcdc_sysc, we now have an empty "ti,sysc-midle" property. And so we currently get a warning for lcdc because of a difference with dts provided configuration compared to the legacy platform data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in the platform data without configuring the modes. Let's fix the issue by adding the missing midlemode to lcdc_sysc, and configuring the "ti,sysc-midle" property based on the TRM values. Fixes: f711c575cfec ("ARM: dts: am335x: Add l4 interconnect hierarchy and ti-sysc data") Cc: Jyri Sarha Cc: Keerthy Cc: Robert Nelson Cc: Suman Anna Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/boot/dts/am33xx-l4.dtsi | 4 +++- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi index 1515f4f914999..3287cf695b5a4 100644 --- a/arch/arm/boot/dts/am33xx-l4.dtsi +++ b/arch/arm/boot/dts/am33xx-l4.dtsi @@ -2038,7 +2038,9 @@ reg = <0xe000 0x4>, <0xe054 0x4>; reg-names = "rev", "sysc"; - ti,sysc-midle ; + ti,sysc-midle = , + , + ; ti,sysc-sidle = , , ; diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index c965af275e341..81d9912f17c85 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -231,8 +231,9 @@ static struct omap_hwmod am33xx_control_hwmod = { static struct omap_hwmod_class_sysconfig lcdc_sysc = { .rev_offs = 0x0, .sysc_offs = 0x54, - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), + .sysc_flags = SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE, + .idlemodes = SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | + MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART, .sysc_fields = &omap_hwmod_sysc_type2, }; -- 2.20.1