Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2331056ybg; Sun, 27 Oct 2019 16:12:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhOp1W5m8L14+lmIuKjuufJ2uaAaqGtzuvumCeoV2M06XWwlSqMD34cbd9iL0+PD3fH6GQ X-Received: by 2002:aa7:d397:: with SMTP id x23mr8122599edq.75.1572217969649; Sun, 27 Oct 2019 16:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572217969; cv=none; d=google.com; s=arc-20160816; b=Ito/QsMca/oEI5PsRmbrWDarMh/5hTzLIiQP93V2qJc+TNLEzgySMndVrCHyKbjHiu 4NzCtzvzIkHTbXnPZMlA/TdUb4JvH3HUvuHVv7PuLqWETF2EfZ9UjhBktn76NOSGjsZ5 wSmMYQsEGv8/K5OPHB5lEMcQrkkB4kdtie5blAHRLSokStt1Tx2Yp9TFHBfdhsBYXItN BnLphqkiVe1n2dWPoleDlewTj16QOOuM2K3WhpNxG85IzBxwUPaa/PlvcWFma9GCMrSH Efgl0R6fzUNTgtApY+/Aqv7XnGAMsjm+EYcgtOh36u3IAHQjsrGOab7KL+Cut0AF0udw agpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wHBTylFj0Hm64+ofIRYO0/WpDMfFdGlYbisXW0hwtKg=; b=hypAzDOgW+PAWf2kpFQZtZP6lv7gyUGlogfLtYpKGwr7ROuty6FHiaqVPN4ApTnv69 lMWXEjq9tfwsE6KxULA48j2s3a0t5XBk6vDZTGB+V2czDjCRuuHWI3d21JquyfDlL7m6 iLQ84gYmGzhec9AHrKNky0P5H/tF3r9iKGN9o2BJ2sPJAC5nJhJy2vaL2DIHo0G5p2oz sCAciqZrZUAyT45R+DAJSaq7gr2TepAjebrtmwuiePb9y3ztNAYY4UZCsGWMgl6XdlXQ JI3bLRWc9Vv5IqJNKYezXT09+C31jI8SyHLWMUA2cnHpa4YyoIeofTQa3Nt6ddLRYGLU 5mWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f8W7MgJx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j3si3202969edh.14.2019.10.27.16.12.25; Sun, 27 Oct 2019 16:12:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f8W7MgJx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728884AbfJ0VFm (ORCPT + 99 others); Sun, 27 Oct 2019 17:05:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:51358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728838AbfJ0VFc (ORCPT ); Sun, 27 Oct 2019 17:05:32 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B342020B7C; Sun, 27 Oct 2019 21:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210332; bh=DNogohxJudpJgaAhRb6Da2/JiIzdCiOlJWxWHOT7MTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f8W7MgJxKZvG0WgvKs9TlGQEHhqS7BKE7FETT5dXayyJtMxV1rQTi48FTBqQUp4k3 GgcqVxKPlJIvKR7BCGF330VlryGd4quGTlLvoQT/EEhPQ0k0toUjV5IbU3G5jgwc20 corj0JiJhZNc5E6wFFCrGqgjFUD5JXp9pQMr5dgs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+cd24df4d075c319ebfc5@syzkaller.appspotmail.com, Johan Hovold Subject: [PATCH 4.9 28/49] USB: usblp: fix use-after-free on disconnect Date: Sun, 27 Oct 2019 22:01:06 +0100 Message-Id: <20191027203141.415037922@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 7a759197974894213621aa65f0571b51904733d6 upstream. A recent commit addressing a runtime PM use-count regression, introduced a use-after-free by not making sure we held a reference to the struct usb_interface for the lifetime of the driver data. Fixes: 9a31535859bf ("USB: usblp: fix runtime PM after driver unbind") Cc: stable Reported-by: syzbot+cd24df4d075c319ebfc5@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191015175522.18490-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/class/usblp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/usb/class/usblp.c +++ b/drivers/usb/class/usblp.c @@ -458,6 +458,7 @@ static void usblp_cleanup(struct usblp * kfree(usblp->readbuf); kfree(usblp->device_id_string); kfree(usblp->statusbuf); + usb_put_intf(usblp->intf); kfree(usblp); } @@ -1120,7 +1121,7 @@ static int usblp_probe(struct usb_interf init_waitqueue_head(&usblp->wwait); init_usb_anchor(&usblp->urbs); usblp->ifnum = intf->cur_altsetting->desc.bInterfaceNumber; - usblp->intf = intf; + usblp->intf = usb_get_intf(intf); /* Malloc device ID string buffer to the largest expected length, * since we can re-query it on an ioctl and a dynamic string @@ -1209,6 +1210,7 @@ abort: kfree(usblp->readbuf); kfree(usblp->statusbuf); kfree(usblp->device_id_string); + usb_put_intf(usblp->intf); kfree(usblp); abort_ret: return retval;