Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2331118ybg; Sun, 27 Oct 2019 16:12:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjQ8x1TH+GZjNGQMLWzrQFFV/8fFPnpTarp2nJyNAppBomf4Cx3SQef+/pTpnYGkXbK2Bb X-Received: by 2002:a05:6402:689:: with SMTP id f9mr14176338edy.79.1572217975455; Sun, 27 Oct 2019 16:12:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572217975; cv=none; d=google.com; s=arc-20160816; b=RBsC11RxLD/OVfkCmOyTbhXkQdAsSUJC/MF2muuNmBhIQ1M4JYSSiAKrNFdk+6tCna 2odRNlXBQLtu2wm5W9D96CBdcSkBccYMhtFX6T08kIW1voiXMqpJi6jSw8j4e24xZhv5 YJpaOXhXMfdUO4rKIivcUU31KMKaoyCRRmsbrUa2V0YGiyMcqnlh3mjQVvd+MBWgU6Wo 1gCnybI6q+DEiF2A3813lJUb1X0kiKHD46Hs0Kgu583L50fR+XN+1Xe1GjXGxcALOdxL Y2GyC2O0+XgjEhWZCgrmD2zIK9TXVW0UDkGh02QNunf/ieYEsGuj7Ar8N6L3perGHoIl rgkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xI59wZd3mjX9UcDEJSoqQEL6rKSLVwmOhj+siogc144=; b=rAR1NjBiCxcO+u1HSLwcJ6LDqnvrVBluDIIEaxlt37PYK+lzFbUruK9QxwJHKGRo9C rKBiAAMDA+hPxuHGPlF0GOL5b6WI3U+DoKCnq30qu5c4qoBvvSd5dmXCZDQVmEl6B3tF h2jxK0cjW8nUVtQPlTrroRFUbChy52e/2iOPLBuG/6iiSeY43XAKWS5dH5MejoWRzoaV OcbnuI36lHnP5CfHzIKR2IoSZXdBP6611x3LaxpriR4wKMv2SCHNHjIocvnIluLDpJFT FT50G4rGwp9+94kcJSsu7yi9F/Qup0jqFDJyAbsU9X/Al0+eGAVU1+9CtahD+WHDCh40 476w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dKje+3Ix; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a45si1680822edc.332.2019.10.27.16.12.31; Sun, 27 Oct 2019 16:12:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dKje+3Ix; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727837AbfJ0VFW (ORCPT + 99 others); Sun, 27 Oct 2019 17:05:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:51066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728077AbfJ0VFS (ORCPT ); Sun, 27 Oct 2019 17:05:18 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05FB3214AF; Sun, 27 Oct 2019 21:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210317; bh=3HIHj0GIBcAutRMnLSPPpw5aosuZHolhLDv0a8ZBVuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dKje+3IxgFOaMU2bU5eP22rQ4yRWdsU+2gjxTZtANYcgtKOSx8tVDZ1ZKUAI7P1vg lxbKyshJXAsjmLWUp2Dq3ymHNx8J/Q7+6Hw42xnxJDS59oI00Ph5z9HJFP52vexn7O 02XLl/B67JwKGLBQXFEVaAab4zoBBC+kMnq5DUrU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.9 23/49] USB: legousbtower: fix memleak on disconnect Date: Sun, 27 Oct 2019 22:01:01 +0100 Message-Id: <20191027203137.269668005@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203119.468466356@linuxfoundation.org> References: <20191027203119.468466356@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 upstream. If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/legousbtower.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -425,10 +425,7 @@ static int tower_release (struct inode * goto exit; } - if (mutex_lock_interruptible(&dev->lock)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->lock); if (dev->open_count != 1) { dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",