Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2492572ybg; Sun, 27 Oct 2019 19:56:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCjuicVrJ6hrdpHudDE7t/G8nNnP2qkWYoo+vNraHwq4nnJibeevKWqGSdC5aldLUlnBVB X-Received: by 2002:a17:906:ce39:: with SMTP id sd25mr15070681ejb.331.1572231409815; Sun, 27 Oct 2019 19:56:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572231409; cv=none; d=google.com; s=arc-20160816; b=RVI9yYm9QngbM2dbkxkElGLdCOqVax/G3BINquB0uh+0QQ5kNxEj3SxcHzODFRUmQn 8DvpHsxuLq3NQY+8sbbauMB7Qxm3X8AGPO4ikWVdRrz7aSD8lrAyACnyCjPRfxQ/ONrk 33olwzmaYECcoGYTSrXJmnWhJdviv85WScdJFemdtA43e9zxdSh7LZ0x1l6BOhYXWQTS TTLEZGOvgUgYVZra7eR8wY5tk4McIsvrS6DkTDXhjq3o/Bt7YEvkAhKXyJK2SjPedHFy wSqaXKK2C1mcfdyqAhawGAH8qCTEkxh/o6iqN8/Ge+tNzoOHE0hvlQO2AE1fwZbYIv5E 2/fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Fgv872WNf0wIRGoST6FsxkdTF79cYJ819OXDev5QgRs=; b=DVkkKX9E7gas2ki6UjPuGi1gg5u5+ZV0b0DqubrqQHwmVe5F9LPeVRC/UvdBKEj1Zw qwXXVPI0LbBUxryKnZYfAcElzb3biIhesiNEjKfakjXI3F7UJPLxYrfBxrEBbGpUni84 fJl/22ByOn3hnTUUY87gzighIBorHiRU1Gr3JvqDOwmArPvvJ942vbC3qvA6OWP1gY75 zbXbgjQxWSMiuvwCyP8Q4HtT8C/jxWJuche+MxL2A9xa26Z92AD2ThvpgHjKEVvmawSj IBVNmLwi4hrMbPmVa2sEboXt9fietb3NUAq3pfYrWOCMRdCS9qEhKHCiB8qyR/wlGCFn xySQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pdovGfCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34si6100878eda.268.2019.10.27.19.56.25; Sun, 27 Oct 2019 19:56:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pdovGfCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730045AbfJ0VMU (ORCPT + 99 others); Sun, 27 Oct 2019 17:12:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:59020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730037AbfJ0VMT (ORCPT ); Sun, 27 Oct 2019 17:12:19 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C402208C0; Sun, 27 Oct 2019 21:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210738; bh=UwVtbbT58WKj2ejT1LaVytt/OzL+CzP+J5ulerQNzMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pdovGfCfHidFgHsJ07lr0OHNIwoUzyjBW4y2i1k6Cd/caSZQUdpYBEM7i+IELxyje 4+fJFo+q56spSQK8c5bOxzJcaxfAuRmnOMaoMLwiuqOWG0/+LWsK3tO/xfBKYPfySg 0K9SjkKmd4FYztSwuZ1aHjO/MHyqhxvZ1R3N2mcc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Waisman , Potnuri Bharat Teja , Jason Gunthorpe Subject: [PATCH 4.14 119/119] RDMA/cxgb4: Do not dma memory off of the stack Date: Sun, 27 Oct 2019 22:01:36 +0100 Message-Id: <20191027203350.079648942@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203259.948006506@linuxfoundation.org> References: <20191027203259.948006506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg KH commit 3840c5b78803b2b6cc1ff820100a74a092c40cbb upstream. Nicolas pointed out that the cxgb4 driver is doing dma off of the stack, which is generally considered a very bad thing. On some architectures it could be a security problem, but odds are none of them actually run this driver, so it's just a "normal" bug. Resolve this by allocating the memory for a message off of the heap instead of the stack. kmalloc() always will give us a proper memory location that DMA will work correctly from. Link: https://lore.kernel.org/r/20191001165611.GA3542072@kroah.com Reported-by: Nicolas Waisman Tested-by: Potnuri Bharat Teja Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/cxgb4/mem.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) --- a/drivers/infiniband/hw/cxgb4/mem.c +++ b/drivers/infiniband/hw/cxgb4/mem.c @@ -260,13 +260,17 @@ static int write_tpt_entry(struct c4iw_r struct sk_buff *skb) { int err; - struct fw_ri_tpte tpt; + struct fw_ri_tpte *tpt; u32 stag_idx; static atomic_t key; if (c4iw_fatal_error(rdev)) return -EIO; + tpt = kmalloc(sizeof(*tpt), GFP_KERNEL); + if (!tpt) + return -ENOMEM; + stag_state = stag_state > 0; stag_idx = (*stag) >> 8; @@ -276,6 +280,7 @@ static int write_tpt_entry(struct c4iw_r mutex_lock(&rdev->stats.lock); rdev->stats.stag.fail++; mutex_unlock(&rdev->stats.lock); + kfree(tpt); return -ENOMEM; } mutex_lock(&rdev->stats.lock); @@ -290,28 +295,28 @@ static int write_tpt_entry(struct c4iw_r /* write TPT entry */ if (reset_tpt_entry) - memset(&tpt, 0, sizeof(tpt)); + memset(tpt, 0, sizeof(*tpt)); else { - tpt.valid_to_pdid = cpu_to_be32(FW_RI_TPTE_VALID_F | + tpt->valid_to_pdid = cpu_to_be32(FW_RI_TPTE_VALID_F | FW_RI_TPTE_STAGKEY_V((*stag & FW_RI_TPTE_STAGKEY_M)) | FW_RI_TPTE_STAGSTATE_V(stag_state) | FW_RI_TPTE_STAGTYPE_V(type) | FW_RI_TPTE_PDID_V(pdid)); - tpt.locread_to_qpid = cpu_to_be32(FW_RI_TPTE_PERM_V(perm) | + tpt->locread_to_qpid = cpu_to_be32(FW_RI_TPTE_PERM_V(perm) | (bind_enabled ? FW_RI_TPTE_MWBINDEN_F : 0) | FW_RI_TPTE_ADDRTYPE_V((zbva ? FW_RI_ZERO_BASED_TO : FW_RI_VA_BASED_TO))| FW_RI_TPTE_PS_V(page_size)); - tpt.nosnoop_pbladdr = !pbl_size ? 0 : cpu_to_be32( + tpt->nosnoop_pbladdr = !pbl_size ? 0 : cpu_to_be32( FW_RI_TPTE_PBLADDR_V(PBL_OFF(rdev, pbl_addr)>>3)); - tpt.len_lo = cpu_to_be32((u32)(len & 0xffffffffUL)); - tpt.va_hi = cpu_to_be32((u32)(to >> 32)); - tpt.va_lo_fbo = cpu_to_be32((u32)(to & 0xffffffffUL)); - tpt.dca_mwbcnt_pstag = cpu_to_be32(0); - tpt.len_hi = cpu_to_be32((u32)(len >> 32)); + tpt->len_lo = cpu_to_be32((u32)(len & 0xffffffffUL)); + tpt->va_hi = cpu_to_be32((u32)(to >> 32)); + tpt->va_lo_fbo = cpu_to_be32((u32)(to & 0xffffffffUL)); + tpt->dca_mwbcnt_pstag = cpu_to_be32(0); + tpt->len_hi = cpu_to_be32((u32)(len >> 32)); } err = write_adapter_mem(rdev, stag_idx + (rdev->lldi.vr->stag.start >> 5), - sizeof(tpt), &tpt, skb); + sizeof(*tpt), tpt, skb); if (reset_tpt_entry) { c4iw_put_resource(&rdev->resource.tpt_table, stag_idx); @@ -319,6 +324,7 @@ static int write_tpt_entry(struct c4iw_r rdev->stats.stag.cur -= 32; mutex_unlock(&rdev->stats.lock); } + kfree(tpt); return err; }