Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2681246ybg; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyn8hjCjoafMHCMCGyi0HfvOV1W6Xt2geekkMJuwZeTATQF6idhnof3J6zq5I5cRcg9l5h8 X-Received: by 2002:a50:9353:: with SMTP id n19mr18063769eda.258.1572246523853; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572246523; cv=none; d=google.com; s=arc-20160816; b=yS/ZjlmPz2xKMkVBKebS+usLK8dt+EatqpXcD1aOjbeQos7GGxRDOfTEmcz7xUVqDK +8FOuQrY9cM2w8q4e/33lTk2RCCpq4NE90/ltrWSTknqJ9F24qhNyW2doGsZSFZb/JgI WVgzqdZ06B0/4RTaoUBh7xOCnVPwrQNg+SIBrLluCJh5tuxH5MXwC3b4ZxsYIPlKHHyz 1xrkGhTBSzMiDaHKLo3e1A5abz39Pou+eUZY8JpbRMw6ZFLr9Pjlcz1VMjdZVOAiSvDG q9m8xQPafyV6SJUqhz5xjEm/mEVYo284Ie4/CeYPmn9sWZ4q4IEMs8d2xStyH/IwaqNR ihug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=636/EAxQM9f5KdbG6B0BkNRS4J/6S6YJOGT30nQhqRU=; b=t8kq6umJ+ERbqsBSaqQj8eGqsgo7px6GAGHFFwsDBdXJ8PQVGPviBIzD0WHOlRkl/S AGuzEVSgF+TkX7wYWItAiDlI8TGozKaSzFDlR2SazQoozOY3+tULyHcS3gZgL9sobIfV OGZjaDZDPzLoVzHvQnZmR3L2TFU6rucuqYlC0hgHCNjUXgfJiXnrmspLikqbMfC6qHjR AelKnidhsthAOkjtlJwG+pn9SSqUVY17DFO7W3FGLm6RaLZJKV7lSXH2caMQWdd2QxyM eFbcCI7dZ6Rr5FdjlZ8etEu4CzgDyRPWIMBgo+/luZ6SQgLJoRFZcjDR4tLqTwGDjT/L KOpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eJDWTdKq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j25si5127421ejt.4.2019.10.28.00.08.02; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eJDWTdKq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730851AbfJ0VQd (ORCPT + 99 others); Sun, 27 Oct 2019 17:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:36124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730843AbfJ0VQa (ORCPT ); Sun, 27 Oct 2019 17:16:30 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4444B222BE; Sun, 27 Oct 2019 21:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210989; bh=oWLVevFRVAgSur6naMxCgVk3E87T6XC7c++lmjFzl5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eJDWTdKq/DXLjnu4VocRQQ0bEUirgrBIF5zWXoDfZP3HNKIomnmtUfYFfCwyxige3 qZLZzYK1fG1HimIqFBfWgoone3O98K3xxrKGC1y04KMmqDqlxxDuD8C031b9FFr47p p43i4uDex2PtmCdM+GJmcjSdLfkDKS9ZhYG3Cxcc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Ulf Hansson Subject: [PATCH 4.19 88/93] memstick: jmb38x_ms: Fix an error handling path in jmb38x_ms_probe() Date: Sun, 27 Oct 2019 22:01:40 +0100 Message-Id: <20191027203316.505354869@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203251.029297948@linuxfoundation.org> References: <20191027203251.029297948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET commit 28c9fac09ab0147158db0baeec630407a5e9b892 upstream. If 'jmb38x_ms_count_slots()' returns 0, we must undo the previous 'pci_request_regions()' call. Goto 'err_out_int' to fix it. Fixes: 60fdd931d577 ("memstick: add support for JMicron jmb38x MemoryStick host controller") Cc: stable@vger.kernel.org Signed-off-by: Christophe JAILLET Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/memstick/host/jmb38x_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/memstick/host/jmb38x_ms.c +++ b/drivers/memstick/host/jmb38x_ms.c @@ -949,7 +949,7 @@ static int jmb38x_ms_probe(struct pci_de if (!cnt) { rc = -ENODEV; pci_dev_busy = 1; - goto err_out; + goto err_out_int; } jm = kzalloc(sizeof(struct jmb38x_ms)