Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2681248ybg; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfdX1xRzoK3+j7iBcas0sOI8nPMKZHq6t26ydS88FhN0izGHl2ytbkF1ZVs/A4KvXrZlm3 X-Received: by 2002:a50:afa1:: with SMTP id h30mr17736006edd.126.1572246523850; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572246523; cv=none; d=google.com; s=arc-20160816; b=hSIpeeNmIVyvCM/xHHKGkBZkMqgDcmK05BMS4Xl0mcDuynfdyk0CmGzLukmMOb1yNL CCcy6ks32Bbl9j6t4k+Y6taIGiVlnkzcZF7mNKioyFlWmZDgBCNFFwqJjQadAMKv00UU Jc4lH0hccnopvL2ne65mKaqKEfnv4ix74vmkootVZeFZVbaNdbnJg0o6VFzmjV3waa1c rCpJL+Q0uvP5bt8+3VeySIuRSUQrHsNG/Agm30YbdXRsKNCM+BEMK0PYXIjaqamXWVkN An/SDUgaIdpfVUmYOXV0ZncWPiB2Lzp+yIAGbquAFeBkB811d+P2cAUiDyeiJ9TM4hN5 plMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zKysDNo6cF/J6/mVo/bzyy7b43nWc70Dbj5g5aF32xk=; b=KxOM+lLjRZ0H7I+1goSah91lZFpl0gHDRnU67iIJRfirticc7HS+BysepDtUYebf4a VsZZ4k9vNoQ0Yy7V9D266nkSJ0iHmy5KQ9B41A5wlGIW+rVNrsG9UDmES74wndluVKvP eRmMalZ2qsZPXyhY/F2FHA8YyTZMMcy4dpJI5fxHDrBOogeZeS0UpMKIL8DWaxxjtnl/ e1xf40AZRmLmcD5qJAE6UuZZQl+Exg9GlN7B4j5E+86KwuvxghGNDrcjF27+V8HiRiV/ U4q8UWZkeCHfe4SJHbA7FBNUVTptm1tnIowOWs4VccPExZqB4vdoG5QZAycZPz7JgwjL pikw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l0b+692S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si7615446edj.263.2019.10.28.00.07.46; Mon, 28 Oct 2019 00:08:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=l0b+692S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730894AbfJ0VQq (ORCPT + 99 others); Sun, 27 Oct 2019 17:16:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:36404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730886AbfJ0VQo (ORCPT ); Sun, 27 Oct 2019 17:16:44 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05AD821726; Sun, 27 Oct 2019 21:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211003; bh=LI1+dhirixYEYs7FYCxZTa41ybRrG0gdklv7SZqhNTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l0b+692S2iGNTNfdQy/sQi/jggwGUNE82U/MUtGpaYbfjG/Ogn9JYgwG8Wu9IJywZ LlUokTIfHQcRI+kLJXz4W9vXofiO1zzSmJPvkNAUM5zUCHrYzP6efL5owWqx8GdPQS 5Iyo3oKL/JNE3eBAXkhQKgO65xA+A7MWkVxKqfDs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Waisman , Potnuri Bharat Teja , Jason Gunthorpe Subject: [PATCH 4.19 93/93] RDMA/cxgb4: Do not dma memory off of the stack Date: Sun, 27 Oct 2019 22:01:45 +0100 Message-Id: <20191027203318.790103764@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203251.029297948@linuxfoundation.org> References: <20191027203251.029297948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg KH commit 3840c5b78803b2b6cc1ff820100a74a092c40cbb upstream. Nicolas pointed out that the cxgb4 driver is doing dma off of the stack, which is generally considered a very bad thing. On some architectures it could be a security problem, but odds are none of them actually run this driver, so it's just a "normal" bug. Resolve this by allocating the memory for a message off of the heap instead of the stack. kmalloc() always will give us a proper memory location that DMA will work correctly from. Link: https://lore.kernel.org/r/20191001165611.GA3542072@kroah.com Reported-by: Nicolas Waisman Tested-by: Potnuri Bharat Teja Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/cxgb4/mem.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) --- a/drivers/infiniband/hw/cxgb4/mem.c +++ b/drivers/infiniband/hw/cxgb4/mem.c @@ -274,13 +274,17 @@ static int write_tpt_entry(struct c4iw_r struct sk_buff *skb, struct c4iw_wr_wait *wr_waitp) { int err; - struct fw_ri_tpte tpt; + struct fw_ri_tpte *tpt; u32 stag_idx; static atomic_t key; if (c4iw_fatal_error(rdev)) return -EIO; + tpt = kmalloc(sizeof(*tpt), GFP_KERNEL); + if (!tpt) + return -ENOMEM; + stag_state = stag_state > 0; stag_idx = (*stag) >> 8; @@ -290,6 +294,7 @@ static int write_tpt_entry(struct c4iw_r mutex_lock(&rdev->stats.lock); rdev->stats.stag.fail++; mutex_unlock(&rdev->stats.lock); + kfree(tpt); return -ENOMEM; } mutex_lock(&rdev->stats.lock); @@ -304,28 +309,28 @@ static int write_tpt_entry(struct c4iw_r /* write TPT entry */ if (reset_tpt_entry) - memset(&tpt, 0, sizeof(tpt)); + memset(tpt, 0, sizeof(*tpt)); else { - tpt.valid_to_pdid = cpu_to_be32(FW_RI_TPTE_VALID_F | + tpt->valid_to_pdid = cpu_to_be32(FW_RI_TPTE_VALID_F | FW_RI_TPTE_STAGKEY_V((*stag & FW_RI_TPTE_STAGKEY_M)) | FW_RI_TPTE_STAGSTATE_V(stag_state) | FW_RI_TPTE_STAGTYPE_V(type) | FW_RI_TPTE_PDID_V(pdid)); - tpt.locread_to_qpid = cpu_to_be32(FW_RI_TPTE_PERM_V(perm) | + tpt->locread_to_qpid = cpu_to_be32(FW_RI_TPTE_PERM_V(perm) | (bind_enabled ? FW_RI_TPTE_MWBINDEN_F : 0) | FW_RI_TPTE_ADDRTYPE_V((zbva ? FW_RI_ZERO_BASED_TO : FW_RI_VA_BASED_TO))| FW_RI_TPTE_PS_V(page_size)); - tpt.nosnoop_pbladdr = !pbl_size ? 0 : cpu_to_be32( + tpt->nosnoop_pbladdr = !pbl_size ? 0 : cpu_to_be32( FW_RI_TPTE_PBLADDR_V(PBL_OFF(rdev, pbl_addr)>>3)); - tpt.len_lo = cpu_to_be32((u32)(len & 0xffffffffUL)); - tpt.va_hi = cpu_to_be32((u32)(to >> 32)); - tpt.va_lo_fbo = cpu_to_be32((u32)(to & 0xffffffffUL)); - tpt.dca_mwbcnt_pstag = cpu_to_be32(0); - tpt.len_hi = cpu_to_be32((u32)(len >> 32)); + tpt->len_lo = cpu_to_be32((u32)(len & 0xffffffffUL)); + tpt->va_hi = cpu_to_be32((u32)(to >> 32)); + tpt->va_lo_fbo = cpu_to_be32((u32)(to & 0xffffffffUL)); + tpt->dca_mwbcnt_pstag = cpu_to_be32(0); + tpt->len_hi = cpu_to_be32((u32)(len >> 32)); } err = write_adapter_mem(rdev, stag_idx + (rdev->lldi.vr->stag.start >> 5), - sizeof(tpt), &tpt, skb, wr_waitp); + sizeof(*tpt), tpt, skb, wr_waitp); if (reset_tpt_entry) { c4iw_put_resource(&rdev->resource.tpt_table, stag_idx); @@ -333,6 +338,7 @@ static int write_tpt_entry(struct c4iw_r rdev->stats.stag.cur -= 32; mutex_unlock(&rdev->stats.lock); } + kfree(tpt); return err; }