Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2692589ybg; Mon, 28 Oct 2019 00:21:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGqXI30lJgRiatCxymJlUZIOCG5AQ/jVArV4582sGfGpgjX2PC7OxDPEsg/OWPnBkNLSFf X-Received: by 2002:a17:906:494e:: with SMTP id f14mr13788785ejt.42.1572247273131; Mon, 28 Oct 2019 00:21:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572247273; cv=none; d=google.com; s=arc-20160816; b=HJzP0SrbARueYxgs/OlMp4gjG9fHs7l5wBMNMYSzc+yW68iPmB5937jc0VndIgRy+a loA9u0C0PqrfivLwqfNmm7gFLqDc4xRhwUk8GlMfK6WmqD7WJCiK43MavyZ/hpaOqKyM lXBg/6gnbUjVFkVPnttYMNncotcsqKpGaJf9keP4Hcn6grKPRJ6kVRJXAnyQulgRbgZk mGIYnQndwuHWbArLjx+58JxIFmVtS73K+yYBlv5CJj+UPTnksf+6XYc4X0IgySjUvaat RdEg5iZU8PQtNXn9ZMNQtyO7DcvyBHAo/wsOAOGM9gf9ZgJ10tfwUMi//91as5tMazsR 9nBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dard4+GOPTM+eO/7Cb1xbipnHVVCwhLlFEVAjS/KlYA=; b=yzeDX4kAo/tEgLbiGfgOwOeDM4Cba6hTVtJFULdEqtLY/uEOY9iIjwUqH6CbiA+w20 66MLZRs3uq0PXJawYBvhACogCdy4b4LFqn0IXXmwDiAOD16QkFUo+PsTEfBXrKyhyalT qr/iHWdkXQfkmnZ7x0BnWEEJYxW6SH2xbK9AC5xBm2OIo1myQL8rgwbmK8PxyoZ9tzrb +DpbRLMPBpO0UwReEfDkwxzCNz8Zb7xt9QwlaRF10ZoCPgRpoYP6J0UOCG9lM0mp1Niy 9kngABNb2wQYk9SpJt3XaLLPPSTLHF2+7+ZlWb4TZKbHIIWysrEl2Vs2xScaCaSWHhUQ GauA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vLy0X3hZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si7524828edb.328.2019.10.28.00.20.46; Mon, 28 Oct 2019 00:21:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vLy0X3hZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbfJ0VRw (ORCPT + 99 others); Sun, 27 Oct 2019 17:17:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:37710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731108AbfJ0VRo (ORCPT ); Sun, 27 Oct 2019 17:17:44 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E5CFE2070B; Sun, 27 Oct 2019 21:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211063; bh=oGHknJ1O/6LAjrtCeIttoLqZwSAoc1U8qXk1HVnDHX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vLy0X3hZMa2r6kFjeoSPyUOAhHFW6cg9uyuUxDv+zjAV1GFlxjXkFnSvoW9jJq5ni HfVq/abp5Zih5TWHMoiw4hp6+bPMbWC9c53fW7RlDAY2TvUX2hD8VkA2kFJiEDnW0w TX9agL3kpeHixVyqDA8c9TB1Cz2EtVBZ60zdNHuA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Lowry Li (Arm Technology China)" , Brian Starkey , "James Qian Wang (Arm Technology China)" , Sasha Levin Subject: [PATCH 5.3 002/197] drm: Clear the fence pointer when writeback job signaled Date: Sun, 27 Oct 2019 21:58:40 +0100 Message-Id: <20191027203351.823794615@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lowry Li (Arm Technology China) [ Upstream commit b1066a123538044117f0a78ba8c6a50cf5a04c86 ] During it signals the completion of a writeback job, after releasing the out_fence, we'd clear the pointer. Check if fence left over in drm_writeback_cleanup_job(), release it. Signed-off-by: Lowry Li (Arm Technology China) Reviewed-by: Brian Starkey Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: james qian wang (Arm Technology China) Link: https://patchwork.freedesktop.org/patch/msgid/1564571048-15029-3-git-send-email-lowry.li@arm.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_writeback.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c index ff138b6ec48ba..43d9e3bb3a943 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -324,6 +324,9 @@ void drm_writeback_cleanup_job(struct drm_writeback_job *job) if (job->fb) drm_framebuffer_put(job->fb); + if (job->out_fence) + dma_fence_put(job->out_fence); + kfree(job); } EXPORT_SYMBOL(drm_writeback_cleanup_job); @@ -366,25 +369,29 @@ drm_writeback_signal_completion(struct drm_writeback_connector *wb_connector, { unsigned long flags; struct drm_writeback_job *job; + struct dma_fence *out_fence; spin_lock_irqsave(&wb_connector->job_lock, flags); job = list_first_entry_or_null(&wb_connector->job_queue, struct drm_writeback_job, list_entry); - if (job) { + if (job) list_del(&job->list_entry); - if (job->out_fence) { - if (status) - dma_fence_set_error(job->out_fence, status); - dma_fence_signal(job->out_fence); - dma_fence_put(job->out_fence); - } - } + spin_unlock_irqrestore(&wb_connector->job_lock, flags); if (WARN_ON(!job)) return; + out_fence = job->out_fence; + if (out_fence) { + if (status) + dma_fence_set_error(out_fence, status); + dma_fence_signal(out_fence); + dma_fence_put(out_fence); + job->out_fence = NULL; + } + INIT_WORK(&job->cleanup_work, cleanup_work); queue_work(system_long_wq, &job->cleanup_work); } -- 2.20.1