Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2692785ybg; Mon, 28 Oct 2019 00:21:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqzS6hxoe9ILj+ZXkq4Pz7XyFUvK8S+qQq69A7iQhoVtjvHIAjS5L0y+lHKVsABzYlsoWU1d X-Received: by 2002:a17:906:544d:: with SMTP id d13mr15170666ejp.64.1572247284833; Mon, 28 Oct 2019 00:21:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572247284; cv=none; d=google.com; s=arc-20160816; b=Ok/W29pxJsidN71hNcryNEvqHu/Ywr2pXimoDbegNC7kmF44hn0rXOtBdnxWlaKkZ9 hSCOIK/I2wf+dHy6TL8O5FO3nFdAXdpoI/jgPaiwDsTL8k1u7KwPjfHh10OKEfjwpGQT KSGNhEVp5Jm5aHYKABK2FRjOVMO+g3+mQT2zaswbTpQhdjuCK3SO4dN/yILADq3nJQqc wBugv4SHm97esiLG88/5+8s7NCqF1VMkcv1hzs9R6ChL+BxjlZmKHdNQa+7fbF2kB25m q0foi+sNvJWZOfQi4uep3+ae5rWOP5DSvMCsDfLVVYGGFLdOngsEOTozwADID0atMAlP bnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=f/N7UANuG3kkG/KGMP8/6dcEaxeBsy3rqqizmpu3YOQ=; b=Lseeg3OFz+6gN4CdvNv4OqOohtr0d45m4cpCc6BAYZr4ehWloI/agrda7vOo7yDgWt 6yLRqOGZEv7k131D6sPzrrt0wYA67t4fKKViLyEUU+y8WkaHswxj+q1qdTnyNkSlRO8G shfnfLqszO1+P/TQERu2cMjqpLd/qd0Rdv5aYamLLTfHElwQ9iIfUClNzkRr2usPYO3B gBXaYxQotHO0bN+7geZGiTq6KUZJpHZF0dMcikQeoMevNHYC4M1ArTjWqHDNHZd6yKFu 7qYMLWLLYk3NEJTDqyqncUPArN0Bqb05dzRbXh+EI00ExoBcPcjN1EETuBzdPbPW5Toj igzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G3dJR1au; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h34si7277334ede.247.2019.10.28.00.21.01; Mon, 28 Oct 2019 00:21:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=G3dJR1au; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731229AbfJ0VSK (ORCPT + 99 others); Sun, 27 Oct 2019 17:18:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:38242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731220AbfJ0VSH (ORCPT ); Sun, 27 Oct 2019 17:18:07 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D97C321783; Sun, 27 Oct 2019 21:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211086; bh=gStethqOG4n+/ABM25A8Yq5Q/DFhR8MKCsnZvf4m0hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G3dJR1auGjsjRGUTebgpZj+YmsY/u7NP3c+VrasAL6ActTAi/oi0LMFkoefBARl6D S+KMcL1iLGWNhK+1Q4Yh4LlabDLpDYfFHv3OGSSXQh5xuHWLjaSpmAP9dcxFHCDMhQ Ziz1DchnvKKXP8nJ91Z0Wern7iEBqhOaJky2FyT4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Stefan Schmidt , Sasha Levin Subject: [PATCH 5.3 027/197] ieee802154: ca8210: prevent memory leak Date: Sun, 27 Oct 2019 21:59:05 +0100 Message-Id: <20191027203353.194087339@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost [ Upstream commit 6402939ec86eaf226c8b8ae00ed983936b164908 ] In ca8210_probe the allocated pdata needs to be assigned to spi_device->dev.platform_data before calling ca8210_get_platform_data. Othrwise when ca8210_get_platform_data fails pdata cannot be released. Signed-off-by: Navid Emamdoost Link: https://lore.kernel.org/r/20190917224713.26371-1-navid.emamdoost@gmail.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- drivers/net/ieee802154/ca8210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index b188fce3f6410..658b399ac9eac 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -3152,12 +3152,12 @@ static int ca8210_probe(struct spi_device *spi_device) goto error; } + priv->spi->dev.platform_data = pdata; ret = ca8210_get_platform_data(priv->spi, pdata); if (ret) { dev_crit(&spi_device->dev, "ca8210_get_platform_data failed\n"); goto error; } - priv->spi->dev.platform_data = pdata; ret = ca8210_dev_com_init(priv); if (ret) { -- 2.20.1