Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2693201ybg; Mon, 28 Oct 2019 00:21:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1LQvWAH4+5sArFy4U7EaOQ+yH0HMmHD26yenzc5PPbzy/gl94yMA4RXqunA4MmHb2V2zD X-Received: by 2002:a50:d80c:: with SMTP id o12mr6707223edj.251.1572247309631; Mon, 28 Oct 2019 00:21:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572247309; cv=none; d=google.com; s=arc-20160816; b=eVLnzRvvE8iQTSe590djKuldI0cDpvl9VrZivDGbUjU+xlzwawa8ltgHDhpHrDUFPV TMO7oEI9mQpxYV/IV7mkBRi//X4/BPoBpyMmkp3gcSaPCHepE86I1MTvGGjE2ByJXcAb eSvpXyR/Urwf48jjpAuz1ooi4Nm6pW6JsqLIBT3PAdrhkg2hoMCTDcENG/hkdPGw4t5N 7dq2XYENFLdNfDQoFmcwKGAHL8UrvPVCLgG29FECgJeUlxdn41UOuuxDhceyoQr1B4cX 4UDYSthE+snUIQ+4/EKIoCHJ0YereJ43PQxtd3SOmuqxBC8cZoznhyP8cI0Erln3F6WJ zcAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8OYP42xutqZWAtFDHgJvPyHjDv9BVKmnDf9z2q+LK9E=; b=erDhDGd2NcfgECMLYpF8ZwCYw4Ab+R8/aKvzrc4i7SeZOyqgkGe82NH3toTAcXi33k BeWrh85i+qDoPwnJjmgOjlrDUa3ybQcFviP79OlDlgmUXdzBG14WIlGNThMjMxCZcL4G FhvG8NkuGiOhv5XiqwnXDJf4QzuXt4LU5/vsMpVNylaRo/nQXYtK6G2Y0WrtBLA7uFvn b8qKdpZU/klVFxGwolbVb/B8sel6igtN0Ve3uAuOvOjA16g421rgVHQ7OhUkZUoCJfU4 RqMckUz/SU+55HYYs7te3PaeG6gmVF8nFy+Fnuy6Y9MA07xh4TcNV8xopMfBRazVeujc 78bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DfVDedHP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18si1541837ejm.339.2019.10.28.00.21.25; Mon, 28 Oct 2019 00:21:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DfVDedHP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731341AbfJ0VSt (ORCPT + 99 others); Sun, 27 Oct 2019 17:18:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731336AbfJ0VSq (ORCPT ); Sun, 27 Oct 2019 17:18:46 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E96420717; Sun, 27 Oct 2019 21:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211125; bh=mqorUQN+cdr1Eu4q/RLzx0/E236qnHRyOfcEwcMOZpw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DfVDedHPqBV5pKJJrsM4b5lyLAiOpbATKnkisEJKA03u/JtUcf1snFdkUwgfw9gU4 A00kiNal2s+Qwd5Gz3mps/tStn5LYtV2YSVatsjQh3gSB8Mxh3CvCZKbQL1mfPduP8 HIDJVR8gHnntOHWs5NBo0sY5E1rDiicC6Zq9Lch8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stanley Chu , Bean Huo , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.3 006/197] scsi: ufs: skip shutdown if hba is not powered Date: Sun, 27 Oct 2019 21:58:44 +0100 Message-Id: <20191027203352.032337803@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stanley Chu [ Upstream commit f51913eef23f74c3bd07899dc7f1ed6df9e521d8 ] In some cases, hba may go through shutdown flow without successful initialization and then make system hang. For example, if ufshcd_change_power_mode() gets error and leads to ufshcd_hba_exit() to release resources of the host, future shutdown flow may hang the system since the host register will be accessed in unpowered state. To solve this issue, simply add checking to skip shutdown for above kind of situation. Link: https://lore.kernel.org/r/1568780438-28753-1-git-send-email-stanley.chu@mediatek.com Signed-off-by: Stanley Chu Acked-by: Bean Huo Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 029da74bb2f5c..e674f6148f698 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -8095,6 +8095,9 @@ int ufshcd_shutdown(struct ufs_hba *hba) { int ret = 0; + if (!hba->is_powered) + goto out; + if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) goto out; -- 2.20.1