Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2694079ybg; Mon, 28 Oct 2019 00:22:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsCQGhBfgHc2h2WPAq8/W4pJYPae3q53Rb629PtsWmHIM2lJiQVg7MFzpyNj9LFb6MuVO5 X-Received: by 2002:a05:6402:3072:: with SMTP id bs18mr17966060edb.120.1572247364978; Mon, 28 Oct 2019 00:22:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572247364; cv=none; d=google.com; s=arc-20160816; b=NPJdrLuYXIz9yeRErDZZ1ft6XuKBMOpWEci9lJ36Tq3x2GlZ2kCS0sHVUb6NnI+wxb EGLb5KGZUjMz4081tGNG4JME5Q3bUEXXv/3M61f7Ktj3r1tNbAIdF5grsBjueuEiXNjJ WCJxxrMBR2JuGF1UtOQiVTgC/5sjmJrbkEk6nws1+7+WO82m1AcXR/nsNDftVimrHxsb 4bBkUtlETfqzYIDhhZKPj4Cm1dTfjvg0DzGar74NsYEVGa96mwz14tVlErCbyPZ4J+R0 PlUtFFoyQ9fYeWRFSslzJL48udcQWHYV3N9SJ45X/4CrxhBXr7ZaSWaNMKjz7sLfkbDr qRFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+ULBt7y6axa6poCNcO8u3fXB/97ldACSw/CEOTi8U28=; b=yOTItkc4Ma2kVhlkVct11Fy0dJ+AdkOZikboEQbiEq+3Nv51ktKQ5+YBc/rWEOC7Uw P1aTZ1kdmx27RDx2syJ2TuQJrr70UzOQq6a6ydpA7NJ1HCop4XL5XCbz6B1apnzlJld4 hIw27XwxwM+kblEWNaScaR7uE4g0Kyd1ojjK8XNP1AjUKrN3YlW9UdfiOa0oKM3ppnl7 Vyf23NEDXQFpM/1b8cQM53mxVTVB4hNdH7qjz+4jB3jfGGZVY0Rqm1LvyHAu06Yuh52Y SUpzudN/Trm0pYByjpDsy/sihEr6gGV/j4vpVQ4nAFbKQggS/BWOwK4+Gsn+zS/54iP+ zLuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJhBzu9C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si6724648edc.67.2019.10.28.00.22.21; Mon, 28 Oct 2019 00:22:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJhBzu9C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731159AbfJ0VRz (ORCPT + 99 others); Sun, 27 Oct 2019 17:17:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:37866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731131AbfJ0VRt (ORCPT ); Sun, 27 Oct 2019 17:17:49 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6739C2070B; Sun, 27 Oct 2019 21:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211069; bh=1oXKVfkAFl97KrAILvEm5RI32+UeZ6F9r+7sJe2Yyx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RJhBzu9C94hD9LQMeKrkW953gmtU4vu14bct3HOgDuOgXy6f6HFGB1MrEdNlqaPSv duZ5FRBW+I3E9sZppV7WlYpQTx5QFaI7ScEunLbLe3REkkv9Wa0sZofHlDz3otG6UP eJ38hVQr2AZ10zrFCPLd4n1bmhL+DCf9AAsdeFFw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gabriel Craciunescu , Sagi Grimberg , Sasha Levin Subject: [PATCH 5.3 021/197] Added QUIRKs for ADATA XPG SX8200 Pro 512GB Date: Sun, 27 Oct 2019 21:58:59 +0100 Message-Id: <20191027203352.817988884@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gabriel Craciunescu [ Upstream commit f03e42c6af60f778a6d1ccfb857db9b2ec835279 ] Booting with default_ps_max_latency_us >6000 makes the device fail. Also SUBNQN is NULL and gives a warning on each boot/resume. $ nvme id-ctrl /dev/nvme0 | grep ^subnqn subnqn : (null) I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop. To be sure is not a Laptop issue only, I tested the device on my server board with the same results. ( with 2x,4x link on the board and 4x link on a PCI-E card ). Signed-off-by: Gabriel Craciunescu Reviewed-by: Sagi Grimberg Signed-off-by: Sagi Grimberg Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 19458e85dab34..86763969e7cb0 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3041,6 +3041,9 @@ static const struct pci_device_id nvme_id_table[] = { .driver_data = NVME_QUIRK_LIGHTNVM, }, { PCI_DEVICE(0x10ec, 0x5762), /* ADATA SX6000LNP */ .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, }, + { PCI_DEVICE(0x1cc1, 0x8201), /* ADATA SX8200PNP 512GB */ + .driver_data = NVME_QUIRK_NO_DEEPEST_PS | + NVME_QUIRK_IGNORE_DEV_SUBNQN, }, { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) }, { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) }, { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) }, -- 2.20.1