Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2747546ybg; Mon, 28 Oct 2019 01:31:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJGSLc0EBNSlakkF1fegFSI6np1a8rX4EWSRT/kIOCmVNYnzC+BxpZsjymz/8jJF1WNgLf X-Received: by 2002:a17:906:e8d:: with SMTP id p13mr7868319ejf.159.1572251507811; Mon, 28 Oct 2019 01:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572251507; cv=none; d=google.com; s=arc-20160816; b=Pj1CJrtn4uBQHJjzCYECz6dwyM8m2LTzv3nS5Ec9Qq7xZpveBMbBx0riKRzENaIvE7 ZI0TheM6cSrp7Yfe/lRoH5z1tbaR79WSGwbxy2etBOgbLRm3a0n9/gWCshUs2XS+2l5M tWOyq+AODmonbgboOrxLrg0t71WoSbpgiTbbZa2OQstoBV1p/JrO54BiRnAC33KQJIjE NnflCTL7okgDhhVJ2HasFoxm34nt4MHFxlkpmDky+2T2hihmvWDhHq6uCHhHb46BEI2y lyceMHaI4z209cWrrGZ6DQRkZPMjZnCfdIXKRm9HF28w27vH/cPYWPqeMryMrBuWjlOr 6DcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=auXg/aHQAdafF+WyTppIL+4+a9c87VeVFNsWI/fW9k8=; b=DAQgX+Zkx91eR3nL5/QNfni9L7sphZWbASIHJYfExz1jZDL8pY1ytHqhK7Kz9vb/uy zs0dpbpvLdVhqsk0KpIghTN9x+w2Sk9uXrEL04vQJRay98Y2LRpoY/2A7bVnjbbmzHdd jPb/y79k3SLL7ukdtxO508miGL50YEPBYc/NaNGziIZPa4kc2Zq+jnB4k9pl4ikuM1cl in6YYvNPobcXMRhwt4rBpwb3DnUkf8yHomqy97aj+SfM5sVwcFK9K0zRnOlmLLYckI8O A72j5fVIUtOfvGzLpJ1TJBf/LE7InE5hSjm7/uRAXfRJ96x0Vsw+MFiYMvdgeRLo5A1a HzVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sUdD4eqo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b53si7224143edb.419.2019.10.28.01.31.24; Mon, 28 Oct 2019 01:31:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sUdD4eqo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730883AbfJ0VW2 (ORCPT + 99 others); Sun, 27 Oct 2019 17:22:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732129AbfJ0VWY (ORCPT ); Sun, 27 Oct 2019 17:22:24 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D07921783; Sun, 27 Oct 2019 21:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211344; bh=DE6oLFqWPXUyOeGDl5G6gq5/MeLhyJjImTLVpPE1KSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUdD4eqoRW8LcVPvPS3R5nX4Nl+WFrYakFKxNWZVuVS1Qu8NSRxm9CbtQPpqn3Tdn iBX94W+D4kllvuMZwLpCSLXDP5xdQkbdM9pNl0rlHNkCt6k4OYyP2PSlzL82KQnyDz 2bOqD29oVRNVs8H4AxSFrOuWoosUhlNfaHGXTzVs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dixit Parmar , Martin Kepplinger , Dmitry Torokhov Subject: [PATCH 5.3 117/197] Input: st1232 - fix reporting multitouch coordinates Date: Sun, 27 Oct 2019 22:00:35 +0100 Message-Id: <20191027203358.050781046@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dixit Parmar commit b1a402e75a5f5127ff1ffff0615249f98df8b7b3 upstream. For Sitronix st1633 multi-touch controller driver the coordinates reported for multiple fingers were wrong, as it was always taking LSB of coordinates from the first contact data. Signed-off-by: Dixit Parmar Reviewed-by: Martin Kepplinger Cc: stable@vger.kernel.org Fixes: 351e0592bfea ("Input: st1232 - add support for st1633") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204561 Link: https://lore.kernel.org/r/1566209314-21767-1-git-send-email-dixitparmar19@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/touchscreen/st1232.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/input/touchscreen/st1232.c +++ b/drivers/input/touchscreen/st1232.c @@ -81,8 +81,10 @@ static int st1232_ts_read_data(struct st for (i = 0, y = 0; i < ts->chip_info->max_fingers; i++, y += 3) { finger[i].is_valid = buf[i + y] >> 7; if (finger[i].is_valid) { - finger[i].x = ((buf[i + y] & 0x0070) << 4) | buf[i + 1]; - finger[i].y = ((buf[i + y] & 0x0007) << 8) | buf[i + 2]; + finger[i].x = ((buf[i + y] & 0x0070) << 4) | + buf[i + y + 1]; + finger[i].y = ((buf[i + y] & 0x0007) << 8) | + buf[i + y + 2]; /* st1232 includes a z-axis / touch strength */ if (ts->chip_info->have_z)