Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2785808ybg; Mon, 28 Oct 2019 02:19:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYPv9cI2p2NyadLL9SHgZ5QCcP9XlTWP17rMszyJkaBuQfFPAf6IAKquvOT2XKb3VQnW0T X-Received: by 2002:a17:906:ce39:: with SMTP id sd25mr16096270ejb.331.1572254392573; Mon, 28 Oct 2019 02:19:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572254392; cv=none; d=google.com; s=arc-20160816; b=l+8SJltdetoGtPMUuXxguKbkhLk7BWLq6XMWAljKDD2GWRaM4MFuVhPo5Z57l+8FwJ 9onWhGcv719Zurvd3UYNLhGwOTlixUTcySBRMeedfEWhGWTt4k3iXW6b8y7xeeWF7U4m dNOOzhWWVP+TK2AETBaG2HhNVHvZ67jd8Abkdw8JkT7iaue1TsJD3xkKCQ33SAWSjjk+ TY2qRT+g5Py6VAaZXEC7CSVZWb/frecqG6m7TzdlutnIf9l4k/+qVvz69MCWSiJ+qD5A zKQYinODmN/zpPNvX3ZjttCHqzKxozvvh4JJh0bXy2oHys1QYpk4X0ljZS4cdmjEhvyC eiHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aw39czBDqvZ25z8ETSy9wDdKn+ZMHCqRbnfOERl6dCg=; b=zyqj7YyVrENckVazzh/We/XZ+Ggk4BrXMrd4xh22YYNgEFFMQ2bRGW+RbnBXG1vFD8 56c+CcMxoYxnPSZ3sNsNvH5lYc2CbTVH5QbBh/hfEMxfxBfu1JOv0PchwbxlFLPQgGD/ f5/BY45hy71X5WMK3fiQHNoG32YwrDYMI1dzj/twy7s+DQUVikC1nzEwiwBeTFeDCtpG ZGcJrXZUj/16BBnVhsh29i3Bz/sAnafzPS/2iGcVIk9fGRV+NKMU7NQJUcY8LGBwhrq/ MYsJkAXqygkUH/FAD0RevedwuMH9hXpbWVptMNO43JDJ6FMlXKtjVgSpa+kt7b5XnE3Z gjdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1quUmj5M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h49si7185629edh.2.2019.10.28.02.19.29; Mon, 28 Oct 2019 02:19:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1quUmj5M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732432AbfJ0VYD (ORCPT + 99 others); Sun, 27 Oct 2019 17:24:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:45440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730777AbfJ0VYA (ORCPT ); Sun, 27 Oct 2019 17:24:00 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E51521726; Sun, 27 Oct 2019 21:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211440; bh=PBAuqa8bf6EkANw75Ec/0dC2L0rQjMnIEdBZie01Rg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1quUmj5MLL7g5U7yGuCHlnbPUnO55ko3H+5bV6P3csLHHATTgnfmN5P7CR/AmBu6U iz6dL12ekIx+n7jE4Sp7EubJF8scCGTkG9bWeWjBxEzHVExcWXbTA+2QHSH2DRfxc8 nGnhn+ftn2Xl01oxK4W4qAPK+HTWuEDzLFoUyoCA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mike Rapoport , Adam Ford , Catalin Marinas , Christoph Hellwig , Fabio Estevam , Lucas Stach , Andrew Morton , Linus Torvalds Subject: [PATCH 5.3 152/197] mm: memblock: do not enforce current limit for memblock_phys* family Date: Sun, 27 Oct 2019 22:01:10 +0100 Message-Id: <20191027203359.893319012@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Rapoport commit f3057ad767542be7bbac44e548cb44017178a163 upstream. Until commit 92d12f9544b7 ("memblock: refactor internal allocation functions") the maximal address for memblock allocations was forced to memblock.current_limit only for the allocation functions returning virtual address. The changes introduced by that commit moved the limit enforcement into the allocation core and as a result the allocation functions returning physical address also started to limit allocations to memblock.current_limit. This caused breakage of etnaviv GPU driver: etnaviv etnaviv: bound 130000.gpu (ops gpu_ops) etnaviv etnaviv: bound 134000.gpu (ops gpu_ops) etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops) etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108 etnaviv-gpu 130000.gpu: command buffer outside valid memory window etnaviv-gpu 134000.gpu: model: GC320, revision: 5007 etnaviv-gpu 134000.gpu: command buffer outside valid memory window etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0 Restore the behaviour of memblock_phys* family so that these functions will not enforce memblock.current_limit. Link: http://lkml.kernel.org/r/1570915861-17633-1-git-send-email-rppt@kernel.org Fixes: 92d12f9544b7 ("memblock: refactor internal allocation functions") Signed-off-by: Mike Rapoport Reported-by: Adam Ford Tested-by: Adam Ford [imx6q-logicpd] Cc: Catalin Marinas Cc: Christoph Hellwig Cc: Fabio Estevam Cc: Lucas Stach Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- mm/memblock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1356,9 +1356,6 @@ static phys_addr_t __init memblock_alloc align = SMP_CACHE_BYTES; } - if (end > memblock.current_limit) - end = memblock.current_limit; - again: found = memblock_find_in_range_node(size, align, start, end, nid, flags); @@ -1469,6 +1466,9 @@ static void * __init memblock_alloc_inte if (WARN_ON_ONCE(slab_is_available())) return kzalloc_node(size, GFP_NOWAIT, nid); + if (max_addr > memblock.current_limit) + max_addr = memblock.current_limit; + alloc = memblock_alloc_range_nid(size, align, min_addr, max_addr, nid); /* retry allocation without lower limit */