Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2786072ybg; Mon, 28 Oct 2019 02:20:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/DV3hRs5UKW9NkJA/WCcYi/eDJitebJv/PPqtX19YN0Pug8IBQVY+lTyWGiyQ+78HYimV X-Received: by 2002:a50:af44:: with SMTP id g62mr18560238edd.164.1572254409365; Mon, 28 Oct 2019 02:20:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572254409; cv=none; d=google.com; s=arc-20160816; b=Qd2TeBfUPDKY/vohu+LEAzfp88ZSt9hcgCG7/GQVETPctIz8rWHmNid4baPLtw1GpP vQmQ5mRuyN0h5JOUkQHpAxwnytMrw11CigEZoUTvQhyb1s3zBNxpZeg0gD7j+5h8gUot xrAU/56kT4428IFlBMdyIB0Dx9BhfrfSLhHOlAuzJLf/xjhADfBBn8ZQE8scG1qXbHZ7 FzUg1U/ajSGOlB42XpPvNZp0m9cSL8kOG8jEWdDNbB13t6Lh+4hSyFbANgI7j93LX5Vi 1aIynZ7jOPsHsxLSI0ybwogMKqFqh4mnmsvUqyqsrdxyMXAoM8BOQjOmmq7UfolKPSnR PbBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HNt0CViv+kBNDFUJx56b63FbWcSAzndXRIltXfEgRzk=; b=bADpg19IXw8//8XegRrQ4bDzUBcDl+wHrNR/jMJAAZIpiLwz3vjEE57Ofb45J8WWp3 ug0e6ILLTZFn7KEOu3Eb0ym/MvKXvF9gxyCZDAOUvSTOpZzIWfILmN2u4mctitMNbQSo zAqiw3zm18qvGHvz1Qeg4DeucP2xnc+0y6UYvVpFBRYhjv5dwE2SkxVwRHswq2uObUjK MlG5L8dxG9J+iBthADlhXfpKaekLnKXNEFCtasA0GCUX5pr4qODs7CURC+qlz0FLZkv/ +roBxbl7PJsrEqODIyFjXOWGqx+o3wNbyD8t6V261E/GjYJIGMmeTfloLlA4No4QrZRs NP9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bvXUK1uU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t26si7844076edc.102.2019.10.28.02.19.46; Mon, 28 Oct 2019 02:20:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bvXUK1uU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732447AbfJ0VYG (ORCPT + 99 others); Sun, 27 Oct 2019 17:24:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:45526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732428AbfJ0VYD (ORCPT ); Sun, 27 Oct 2019 17:24:03 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22FBC2184C; Sun, 27 Oct 2019 21:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211442; bh=Z13k9Rr+oBpf3ED7rjGzDOEk10lgri0uRu9QWWRnjeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bvXUK1uUHmvOc7qES7FO1eFiFi3RdaxEw/JZWiZzTtjPx71EUuS+edSpRqAW7udH+ QZjfBp7iAccmAu86WCG2VQ7JIxffJ5UR+6dX8ZPusoR8a23TxHXmKwvcvwlPQBDkXO 7Gh+59DsIIdbuT368RBCRAnxBw1bg2/dLPnjG8W4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Hildenbrand , Michal Hocko , Michal Hocko , Mike Kravetz , Anshuman Khandual , Andrew Morton , Linus Torvalds Subject: [PATCH 5.3 153/197] hugetlbfs: dont access uninitialized memmaps in pfn_range_valid_gigantic() Date: Sun, 27 Oct 2019 22:01:11 +0100 Message-Id: <20191027203359.945985294@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Hildenbrand commit f231fe4235e22e18d847e05cbe705deaca56580a upstream. Uninitialized memmaps contain garbage and in the worst case trigger kernel BUGs, especially with CONFIG_PAGE_POISONING. They should not get touched. Let's make sure that we only consider online memory (managed by the buddy) that has initialized memmaps. ZONE_DEVICE is not applicable. page_zone() will call page_to_nid(), which will trigger VM_BUG_ON_PGFLAGS(PagePoisoned(page), page) with CONFIG_PAGE_POISONING and CONFIG_DEBUG_VM_PGFLAGS when called on uninitialized memmaps. This can be the case when an offline memory block (e.g., never onlined) is spanned by a zone. Note: As explained by Michal in [1], alloc_contig_range() will verify the range. So it boils down to the wrong access in this function. [1] http://lkml.kernel.org/r/20180423000943.GO17484@dhcp22.suse.cz Link: http://lkml.kernel.org/r/20191015120717.4858-1-david@redhat.com Fixes: f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") [visible after d0dc12e86b319] Signed-off-by: David Hildenbrand Reported-by: Michal Hocko Acked-by: Michal Hocko Reviewed-by: Mike Kravetz Cc: Anshuman Khandual Cc: [4.13+] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- mm/hugetlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1084,11 +1084,10 @@ static bool pfn_range_valid_gigantic(str struct page *page; for (i = start_pfn; i < end_pfn; i++) { - if (!pfn_valid(i)) + page = pfn_to_online_page(i); + if (!page) return false; - page = pfn_to_page(i); - if (page_zone(page) != z) return false;