Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2787200ybg; Mon, 28 Oct 2019 02:21:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2qNPYbR/liLB7TJ14Mzb3po8aA4JGjjrf0Jp+EukJL4ItcUktEadMv6eF8kjcu0ExmrKs X-Received: by 2002:a17:907:105c:: with SMTP id oy28mr15563896ejb.299.1572254488844; Mon, 28 Oct 2019 02:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572254488; cv=none; d=google.com; s=arc-20160816; b=bO/4MFdM/Hmf+YgVzhC1+eT1N5/3ewInWWdq0uBIB0Xit4K+3JVqI2PGoobtkzLP2f q1WpiHE2B+6Ps0topt0NZcsVBHayqLKW4rsHmPilMA0ZanqpsALB0Kye0kQwuQxWRi9Z LqztAm9lwt2LrFApKsqur6g9EGd5p+aJ+k+AX3vxuKoLFI/vlwElSMlMjgulCIMCzh5R UjXiTqbTMtKD+PsWAT3cDrC55oyWAH+gIoOE1SXQUyhXHX1kW86Vsxmgi9/gQ2etidey umEjTXUohO/TYNMoe1Nz3p2l7avIS56Y1eawb7Kr2kdKYY5bmwewAM9b2vm8cJjSJ0lJ W75A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=O89KrXzyMwsFKVoyfsAU57biqc7X4n2mAW+aFsKnwZM=; b=DUN8S32bBm/FqrUEzELZZAd/+L9az810psUiWOp8vqC+eMYj7W85RQRl/znCsCxHai Hgn9+/7qIXogRNl6RXVwvOAW1QHTAq82w6gZQcf1jMt04/+jCyCxf4q8tzS6LRutef42 l1cy+pl+dSTFmdo+3YHacyCI0uyRCikNsDCcX7Gpwrjcnol9GqgP7bic0UN4CMMMtgeP /hq27AhcjZaYI9GLU+pMuQaKij2l2wHzp00pe7BoRbtZwhFyC/qXTzG13tkPUktYvSiV O89c5rXOIx0omEabd1EwhKS33RJKXhvUHmJgmu3SGZvlcfPDnecVYH7Erk1hJyA/DsDl n1PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EmlUvbIx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si5966421ejt.282.2019.10.28.02.21.05; Mon, 28 Oct 2019 02:21:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EmlUvbIx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732600AbfJ0VYr (ORCPT + 99 others); Sun, 27 Oct 2019 17:24:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:46452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732581AbfJ0VYp (ORCPT ); Sun, 27 Oct 2019 17:24:45 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65C39222C2; Sun, 27 Oct 2019 21:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211484; bh=Ylppbfu16KHMXB+7ecukrBDTkQE1TIOrkKxPPDpLHY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EmlUvbIxhKsFCq3yvyjorWbkZDsQKgyeBbTqv4MDP1/lrRm5Il3eFD24ceDQ491Vu fZW68+CTpqJIQ3wDq0thNK8hhRhtaNYSay6erwwMZ2VVfCgCOudDSiOa88fPVJOv6W pHHkmuchAPO42zn48Nsnk7FfsLn+I/OhWN2B1uPE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roberto Bergantinos Corpas , Ronnie Sahlberg , Aurelien Aptel , Steve French Subject: [PATCH 5.3 167/197] CIFS: avoid using MID 0xFFFF Date: Sun, 27 Oct 2019 22:01:25 +0100 Message-Id: <20191027203403.359847100@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roberto Bergantinos Corpas commit 03d9a9fe3f3aec508e485dd3dcfa1e99933b4bdb upstream. According to MS-CIFS specification MID 0xFFFF should not be used by the CIFS client, but we actually do. Besides, this has proven to cause races leading to oops between SendReceive2/cifs_demultiplex_thread. On SMB1, MID is a 2 byte value easy to reach in CurrentMid which may conflict with an oplock break notification request coming from server Signed-off-by: Roberto Bergantinos Corpas Reviewed-by: Ronnie Sahlberg Reviewed-by: Aurelien Aptel Signed-off-by: Steve French CC: Stable Signed-off-by: Greg Kroah-Hartman --- fs/cifs/smb1ops.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/cifs/smb1ops.c +++ b/fs/cifs/smb1ops.c @@ -171,6 +171,9 @@ cifs_get_next_mid(struct TCP_Server_Info /* we do not want to loop forever */ last_mid = cur_mid; cur_mid++; + /* avoid 0xFFFF MID */ + if (cur_mid == 0xffff) + cur_mid++; /* * This nested loop looks more expensive than it is.