Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lm75: add lm75b detection
To:     Rain Wang <Rain_Wang@Jabil.com>, Jean Delvare <jdelvare@suse.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20191026081049.GA16839@rainw-fedora28-jabil.corp.JABIL.ORG>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <7a2ddf42-8bbe-59e0-dae8-85b184ea0da0@roeck-us.net>
Date:   Sun, 27 Oct 2019 16:03:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191026081049.GA16839@rainw-fedora28-jabil.corp.JABIL.ORG>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/26/19 1:10 AM, Rain Wang wrote:
> The National Semiconductor LM75B is very similar as the
> LM75A, but it has no ID byte register 7, and unused registers
> return 0xff rather than the last read value like LM75A.
> 
> Signed-off-by: Rain Wang <rain_wang@jabil.com>

I am quite hesitant to touch the detect function for this chip.
Each addition increases the risk for false positives. What is the
use case ?

Thanks,
Guenter

> ---
>   drivers/hwmon/lm75.c | 17 +++++++++++++++--
>   1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 5e6392294c03..a718f9eb4d72 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -760,6 +760,7 @@ static int lm75_detect(struct i2c_client *new_client,
>   	int i;
>   	int conf, hyst, os;
>   	bool is_lm75a = 0;
> +	bool is_lm75b = 0;
>   
>   	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
>   				     I2C_FUNC_SMBUS_WORD_DATA))
> @@ -780,8 +781,12 @@ static int lm75_detect(struct i2c_client *new_client,
>   	 * register 7, and unused registers return 0xff rather than the
>   	 * last read value.
>   	 *
> +	 * The National Semiconductor LM75B is very similar as the
> +	 * LM75A, but it has no ID byte register 7, and unused registers
> +	 * return 0xff rather than the last read value like LM75A.
> +	 *
>   	 * Note that this function only detects the original National
> -	 * Semiconductor LM75 and the LM75A. Clones from other vendors
> +	 * Semiconductor LM75 and the LM75A/B. Clones from other vendors
>   	 * aren't detected, on purpose, because they are typically never
>   	 * found on PC hardware. They are found on embedded designs where
>   	 * they can be instantiated explicitly so detection is not needed.
> @@ -806,6 +811,13 @@ static int lm75_detect(struct i2c_client *new_client,
>   		is_lm75a = 1;
>   		hyst = i2c_smbus_read_byte_data(new_client, 2);
>   		os = i2c_smbus_read_byte_data(new_client, 3);
> +	} else if (i2c_smbus_read_byte_data(new_client, 4) == 0xff
> +		 && i2c_smbus_read_byte_data(new_client, 5) == 0xff
> +		 && i2c_smbus_read_byte_data(new_client, 6) == 0xff) {
> +		/* LM75B detection */
> +		is_lm75b = 1;
> +		hyst = i2c_smbus_read_byte_data(new_client, 2);
> +		os = i2c_smbus_read_byte_data(new_client, 3);
>   	} else { /* Traditional style LM75 detection */
>   		/* Unused addresses */
>   		hyst = i2c_smbus_read_byte_data(new_client, 2);
> @@ -839,7 +851,8 @@ static int lm75_detect(struct i2c_client *new_client,
>   			return -ENODEV;
>   	}
>   
> -	strlcpy(info->type, is_lm75a ? "lm75a" : "lm75", I2C_NAME_SIZE);
> +	strlcpy(info->type, is_lm75a ?
> +		"lm75a" : (is_lm75b ? "lm75b" : "lm75"), I2C_NAME_SIZE);
>   
>   	return 0;
>   }
>