Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3130693ybg; Mon, 28 Oct 2019 07:59:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqypOZMPSgLiAdO1xKEbOEhvX8y2g3ETf8CrMGEt01ElSSjtjSlHzweh3vJ8m4VvVT7tftBR X-Received: by 2002:a17:906:6bc4:: with SMTP id t4mr9789106ejs.1.1572274749322; Mon, 28 Oct 2019 07:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572274749; cv=none; d=google.com; s=arc-20160816; b=MAKTdJWNU5xJtscJgq8M4Xvs6GqEgK5Td3+pPEn2z6It0J9u3IIeRUFKqtafSoh9cI 3jycNX23bM01zJ9RCKC+IfOZOL7JOgx8iF1MkdxrSmKvIrWYFdcUGWqdG6bXUDEG71dd FlAekGLVR0RwClDYRiz8uPQpgx4YZ/OX7BHs1+VRDrDHqxSFgorH62wJKpz666cH2aUh OuawAgmsVxuNfLwo5LH29zJmK2GpxP/bgSIquh5/Ork8yyylAJx0VBC0wdk+I8BV1VZU DHMk2A3LTMtGwdS0LjiMPlrlLOy/UTMJ7tqKqJcKas3PdIe3qUlb5peb4ZBIBFEIpYhi +6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature; bh=AJebXuWkSb9KcSn0Sp2CRuMZDKNl7IOAVN3qhl4l1J8=; b=NKH+rbpHdfLafYIeTveOmssR7wTVkEifIRzRFN1V8MGrlYR8+DksBCPq8eiR9+viKw D7JupcC1GkqK3J1M6vQzdDi6vc6+K87E+V9PBCE8BjNCTgJJY2+qjDtQw0LdKf4uK5ds 5Sqcclr8YcxbaMpnPyLsiunVuKTu4lf+fBxxQWFA+zV/UJM+LlboCA1DhZ0F6Z1LgdOe zgalieKHmETU016fn2EGblO/jLxQ4OFp7CCI1fHarJ6lSFbKy6KMRnpspx8tF3JbTZLf SDDPYplrxa1gl4YPKZDn3BPVx/XauTtOszz65H4EY6agX8V717uXj1manxNoQ65ojsjd 0eIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ky5pIumV; dkim=pass header.i=@codeaurora.org header.s=default header.b=cA8REEa9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id os27si6339147ejb.71.2019.10.28.07.58.45; Mon, 28 Oct 2019 07:59:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=ky5pIumV; dkim=pass header.i=@codeaurora.org header.s=default header.b=cA8REEa9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731286AbfJ1Duk (ORCPT + 99 others); Sun, 27 Oct 2019 23:50:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44934 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729328AbfJ1Duj (ORCPT ); Sun, 27 Oct 2019 23:50:39 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4920660B6E; Mon, 28 Oct 2019 03:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572234639; bh=RJ5p8lSM8JQFxANAulacrnApspWJ3qXOe0QjHj7b2DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ky5pIumVxXOkyNCgoqhY2mvkXmkC8SPawKc8E4M2bG8ooVBlFIkMqN8j5SiI2WMTR D2NC4El1Dl+VdReqrCUak7EkoFmbdwYeimPJZ06yE6p2UtCYP1RLI7QX/RgBgTIl75 TPFoZoQ3868v7iLa5+fu4YhzizIEAyepaj+B5rLc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 73B3660A34; Mon, 28 Oct 2019 03:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572234638; bh=RJ5p8lSM8JQFxANAulacrnApspWJ3qXOe0QjHj7b2DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cA8REEa9z7q9Zr3rffjSbzulfZwcqlpk0OOKCWGmklooeo7eFhCp4Eoz9op1ns4QE thcGRdaXM24xSovDayg2HH2nh5Y8IBX05d/Rw4NLozJdAkHUCbfS4c6xcl1RpILf1Y QJefrDuF49vfubM9zMqEeSIEUAcX+GffwhTCZ6RU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 73B3660A34 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Subhash Jadavani , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v1 3/5] scsi: ufs: Release clock if DMA map fails Date: Sun, 27 Oct 2019 20:50:05 -0700 Message-Id: <1572234608-32654-4-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1572234608-32654-1-git-send-email-cang@codeaurora.org> References: <1572234608-32654-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In queuecommand path, if DMA map fails, it bails out with clock held. In this case, release the clock to keep its usage paired. Change-Id: Ia3e3e19086c58a27ed2a794fcbbac341e584a474 Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 101b4d0..6e9236a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -2480,6 +2480,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) if (err) { lrbp->cmd = NULL; clear_bit_unlock(tag, &hba->lrb_in_use); + ufshcd_release(hba); goto out; } /* Make sure descriptors are ready before ringing the doorbell */ -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project