Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191028024101.26655-1-nickhu@andestech.com>
In-Reply-To: <20191028024101.26655-1-nickhu@andestech.com>
From:   Greentime Hu <green.hu@gmail.com>
Date:   Mon, 28 Oct 2019 15:01:14 +0800
Message-ID: <CAEbi=3cs1h4pOU9TcP3JCp921Jj4qYiGtqWCkJ2VKby0YFbbXg@mail.gmail.com>
Subject: Re: [PATCH v4 0/3] KASAN support for RISC-V
To:     Nick Hu <nickhu@andestech.com>,
        Greentime Hu <greentime.hu@sifive.com>
Cc:     aryabinin@virtuozzo.com, Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, corbet@lwn.net,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Thomas Gleixner <tglx@linutronix.de>,
        gregkh@linuxfoundation.org, alankao@andestech.com,
        Anup.Patel@wdc.com, atish.patra@wdc.com,
        kasan-dev@googlegroups.com, linux-doc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-riscv@lists.infradead.org, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Nick Hu <nickhu@andestech.com> =E6=96=BC 2019=E5=B9=B410=E6=9C=8828=E6=97=
=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8810:41=E5=AF=AB=E9=81=93=EF=BC=9A
>
> KASAN is an important runtime memory debugging feature in linux kernel wh=
ich can
> detect use-after-free and out-of-bounds problems.
>
> Changes in v2:
>   - Remove the porting of memmove and exclude the check instead.
>   - Fix some code noted by Christoph Hellwig
>
> Changes in v3:
>   - Update the KASAN documentation to mention that riscv is supported.
>
> Changes in v4:
>   - Correct the commit log
>   - Fix the bug reported by Greentime Hu
>
> Nick Hu (3):
>   kasan: No KASAN's memmove check if archs don't have it.
>   riscv: Add KASAN support
>   kasan: Add riscv to KASAN documentation.
>
>  Documentation/dev-tools/kasan.rst   |   4 +-
>  arch/riscv/Kconfig                  |   1 +
>  arch/riscv/include/asm/kasan.h      |  27 ++++++++
>  arch/riscv/include/asm/pgtable-64.h |   5 ++
>  arch/riscv/include/asm/string.h     |   9 +++
>  arch/riscv/kernel/head.S            |   3 +
>  arch/riscv/kernel/riscv_ksyms.c     |   2 +
>  arch/riscv/kernel/setup.c           |   5 ++
>  arch/riscv/kernel/vmlinux.lds.S     |   1 +
>  arch/riscv/lib/memcpy.S             |   5 +-
>  arch/riscv/lib/memset.S             |   5 +-
>  arch/riscv/mm/Makefile              |   6 ++
>  arch/riscv/mm/kasan_init.c          | 104 ++++++++++++++++++++++++++++
>  mm/kasan/common.c                   |   2 +
>  14 files changed, 173 insertions(+), 6 deletions(-)
>  create mode 100644 arch/riscv/include/asm/kasan.h
>  create mode 100644 arch/riscv/mm/kasan_init.c
>
Hi Nick,

I have tested KASAN feature with test_kasan.ko based on commit
cd9e72b80090a8cd7d84a47a30a06fa92ff277d1 (tag: riscv/for-v5.4-rc3) and
it passed in Qemu and Unleashed board.
Thank you for fixing the bug. :)

Tested-by: Greentime Hu <greentime.hu@sifive.com>