Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3237040ybg; Mon, 28 Oct 2019 09:33:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9hTRuASVGXmNJ90xtYuafuCcTfZNGF8OI8FALZfltGVGXTM0vulT6UcHuGtLh5hDesEfL X-Received: by 2002:a17:906:1604:: with SMTP id m4mr7453219ejd.124.1572280419910; Mon, 28 Oct 2019 09:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572280419; cv=none; d=google.com; s=arc-20160816; b=J6PRmFRQL9ZlPoqteCR38oqsBcIKklFXxSLVsgczlqekN0WZ2yXClwNhgJx7/oEANw PKiRQSiY3ojKWfr9UQmk/GWIp3+Ri3+uH3JPax9ltrxhbPwC8NhrgvCaoyqIXXY1CIHe 26h6QNCORACTDbVLUKEgZAx0TlSIbAEAFpl1BMQaoAsWrqcV38DkXLGWhLK9Yf8TxcqK xcaKm7edm/6jlR6F0PLhO1+0Fqxz+4e4mux3LSRtjDOXqzHWpPrAZshbCI/6sGZhWC2/ 1wOpvGwXCOkc7KrTq5F0zBI2j7DQrq+Oy7iORlBIwvwWClCTqIuw+JCN52MkAZkU4Iy3 9+Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=70HmlurglAAJniJsVRSXqyyvPjG5hWGb7QIptsE5/dw=; b=bd/noc5S3Crd9nniIaP+sReWJ2Uefc2/9qi7j3UWVnlFBtpf8i3pTSeiZ0trco69T4 P0lvVgh2i9tgmZZW5iMo2pi70bZ22NDU5dUrwUkqFzmO0ZrVtoNlNNrfiFK2d/oXDtNT jxalI7dGANIhQnxnpGqL+mX2pIWY8Q3s2To+Krypo7ySv4VjztFG+R/0G94YVd+Acond J23VuzD6i2blax7ztBOKEdt4UGtcuxle3l/5AGzrmHs5fR7l0f4couNbHeRUsTPzlRX8 DgHlW62x/V/KEO+/CMC3deI3TipCspp5sPjvWJu1XAlS+ZXwnRk1m6vg9Y4NBcLzUANb y0Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gpwTNv9L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m19si6065189ejd.180.2019.10.28.09.33.15; Mon, 28 Oct 2019 09:33:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gpwTNv9L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731045AbfJ1Hqq (ORCPT + 99 others); Mon, 28 Oct 2019 03:46:46 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46488 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729695AbfJ1Hqq (ORCPT ); Mon, 28 Oct 2019 03:46:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=70HmlurglAAJniJsVRSXqyyvPjG5hWGb7QIptsE5/dw=; b=gpwTNv9LlrjBzgxTbn2JJCgfx yo2KmFz4Ql2+VRN6InGivZiXsCqgEFHRSaL2RwSgnPt+LasNjvuxfNE8gkKzxXPqUP933RsJKgkUM C2g5gPcOEfgE7Zz12IVRJQQzVBKmH+APEObKsCMvxwGX4VWd95Gq/Vz8MTv7zMm8Ukya9w22hZhI8 sNZX2S5hXFKY9tFdNPz8fH7qnZ86sXFXxW+ruKzTXNq93h/t/PlGKKIwU7bhotVwanxjJ1eZCtzL5 SI+hDOOs+atLJNmFcStMa1H/Huuo3YjPXoKGuID+95tSMpMkBY5G5Jr56UI2gVx8NnZLMI7pvbcoN BMB783yiw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOzje-0001kr-Sp; Mon, 28 Oct 2019 07:46:42 +0000 Date: Mon, 28 Oct 2019 00:46:42 -0700 From: Christoph Hellwig To: John Stultz Cc: lkml , Sandeep Patil , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Andrew Morton , Yue Hu , Mike Rapoport , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , dri-devel@lists.freedesktop.org Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module Message-ID: <20191028074642.GB31867@infradead.org> References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025234834.28214-2-john.stultz@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area); Please CC the dma maintainer. And no, you have no business using this. Even if you did, internals like this should always be EXPORT_SYMBOL_GPL.