Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Oct 2019 07:27:40 +0100
Message-ID: <s5hpnihmlk3.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
Cc:     emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu,
        Clemens Ladisch <clemens@ladisch.de>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix memory leak in __snd_usbmidi_create
In-Reply-To: <20191027221007.14317-1-navid.emamdoost@gmail.com>
References: <20191027221007.14317-1-navid.emamdoost@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 27 Oct 2019 23:10:06 +0100,
Navid Emamdoost wrote:
> 
> In the implementation of __snd_usbmidi_create() there is a memory leak
> caused by incorrect goto destination. Go to free_midi if
> snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints()
> fail.

No, this will lead to double-free.  After registering the rawmidi
interface at snd_usbmidi_create_rawmidi(), the common destructor will
be called via rawmidi private_free callback, and this will release the
all resources already.


thanks,

Takashi

> 
> Fixes: 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
>  sound/usb/midi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index b737f0ec77d0..22db37fbfbbd 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,
>  	else
>  		err = snd_usbmidi_create_endpoints(umidi, endpoints);
>  	if (err < 0)
> -		goto exit;
> +		goto free_midi;
>  
>  	usb_autopm_get_interface_no_resume(umidi->iface);
>  
> -- 
> 2.17.1
>