Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3289961ybg; Mon, 28 Oct 2019 10:24:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEQDb7xvloD+JCqQsGWXGs9lxOtyhPb5bpoRHf8oZd1UDut9D1C6CoG7UmOn0qVpO4uFOa X-Received: by 2002:a17:906:4cd2:: with SMTP id q18mr17317754ejt.319.1572283484515; Mon, 28 Oct 2019 10:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572283484; cv=none; d=google.com; s=arc-20160816; b=K1B5QCKuUC8nYfqaDWR0C5SDu1cEfXyQy7ctQ8YNH1nLsAn5jaxYZtXy6/Y2QCJuDI jqPNtLPfdVd0RXkZN8tSX7hbdEzoTCaGdZEsdY7ok2D22yWV/kvt5Mr5myqFppIKNkOx QbEz+T0yuGVaAlVexfThvIug+N5DU448cgfS+X5x2z/zEnf9etv1NUL7fb8pm/bSut0B A9l/CoO+HM9ph/pwNr2vYUQpPFMcssNhQbjL2SqJvudsvLcpMZ3Plh88ddP+xBxz39zx FPi5DAwrZmb6wX3pu5aP5sZLswa/ndvgMKhEJGkcXKQzOzSqo1OsQPvkR03mAKiwcRcD xglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2jaVhbWEKnwTRNhO5TvPb/W0pSJqU1SXaED0JRlx5oY=; b=XjEViOPcPnf4bmxEpzfCrl5wHw5O/bI3pCnXHDFTolFe++t1kkVeD6L7DCqFtjlwpI 4g59XZmsDkyTOnvkfKSAaFCpIyYxnMbqT7KCBcSXw51/eeSlESGeCFpBO++q2z2/mSqi y5/u2Z44ORQg90aEY9mu/ovhbdmrB5VIgyHl0V0EXbXNd7MixK+9DebTfFMbh9I4+I7m B+N6XB9VGEPqgNwhnJjlU/rS6gT5MY/KcNvLsnjV/7liSI/qVKDziR+1di0dK3MfwXDJ YJt6Ab7XPw7fNoBpdJtvBaJ3DeoleWYtrWVZY7kEk82qj6IYmdG2SZ0vMNzy6yTEM2gr eH2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si9390157eda.319.2019.10.28.10.23.45; Mon, 28 Oct 2019 10:24:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732205AbfJ1HHR (ORCPT + 99 others); Mon, 28 Oct 2019 03:07:17 -0400 Received: from mga18.intel.com ([134.134.136.126]:19783 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732191AbfJ1HHR (ORCPT ); Mon, 28 Oct 2019 03:07:17 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 00:07:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="205111216" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2019 00:07:15 -0700 From: Alexander Shishkin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Alexander Shishkin , Andy Shevchenko Subject: [GIT PULL 1/7] intel_th: gth: Fix the window switching sequence Date: Mon, 28 Oct 2019 09:06:45 +0200 Message-Id: <20191028070651.9770-2-alexander.shishkin@linux.intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191028070651.9770-1-alexander.shishkin@linux.intel.com> References: <20191028070651.9770-1-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 8116db57cf16 ("intel_th: Add switch triggering support") added a trigger assertion of the CTS, but forgot to de-assert it at the end of the sequence. This results in window switches randomly not happening. Fix that by de-asserting the trigger at the end of the window switch sequence. Signed-off-by: Alexander Shishkin Reviewed-by: Andy Shevchenko --- drivers/hwtracing/intel_th/gth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hwtracing/intel_th/gth.c b/drivers/hwtracing/intel_th/gth.c index fa9d34af87ac..f72803a02391 100644 --- a/drivers/hwtracing/intel_th/gth.c +++ b/drivers/hwtracing/intel_th/gth.c @@ -626,6 +626,9 @@ static void intel_th_gth_switch(struct intel_th_device *thdev, if (!count) dev_dbg(&thdev->dev, "timeout waiting for CTS Trigger\n"); + /* De-assert the trigger */ + iowrite32(0, gth->base + REG_CTS_CTL); + intel_th_gth_stop(gth, output, false); intel_th_gth_start(gth, output); } -- 2.23.0